101 Commits

Author	SHA1	Message	Date
cucadmuh	09f24beb32	feat(audio): hi-res transition blend rate for crossfade, AutoDJ, and gapless (#1171)	2026-06-24 21:04:42 +03:00
cucadmuh	15cecb5d7d	feat(server): custom HTTP headers for reverse-proxy gates (#1095) (#1156)	2026-06-22 16:25:28 +03:00
cucadmuh	4225146a16	feat(autodj): smooth skip and interrupt blend transitions (#1128)	2026-06-19 04:52:15 +03:00
cucadmuh	a6ee0668c8	feat(crossfade): AutoDJ — content-aware silence-trimming crossfade (#1122) ... * feat(crossfade): add "trim silence between tracks" toggle New persisted setting `crossfadeTrimSilence` (default off; existing installs rehydrate off via the persist default-merge). Surfaced in Settings -> Audio and in the crossfade popovers of the queue toolbar and the mini-player. Crossfade buttons now separate the two actions: left-click toggles crossfade on/off, right-click opens the settings popover (seconds + trim). Shared the mini popover positioning into useMiniAnchoredPopover (now backing both volume and crossfade). Mini bridge carries crossfadeSecs/crossfadeTrimSilence and gains mini:set-crossfade-secs / mini:set-crossfade-trim-silence. The actual silence-trimming playback behaviour is wired in a follow-up; this commit only persists the user intent. i18n added across 9 locales. * feat(crossfade): trim silence between tracks (waveform-driven) Wire the actual silence-aware crossfade behind the (default-off) crossfadeTrimSilence toggle. Detection is derived on the fly from the cached 500-bin waveform + track duration — no new analysis pass or cache fields. - waveformSilence.ts: computeWaveformSilence(bins, duration) → lead/trail silence + content bounds, using the peak curve, a low absolute cut and a per-side cap. Unit-tested. - A-tail (JS): handleAudioProgress advances the crossfade early, at contentEnd - crossfadeSecs, when the current track ends in real trailing silence, so the fade overlaps music. Guarded once per play generation. - B-head: audio_play gains an additive optional start_secs; the freshly built source is try_seek'd past the next track's leading silence before append, then seek_offset/samples_played are re-anchored so position is content-relative. Non-seekable / cold sources degrade to today. - Pre-buffer: crossfade next-track download + B-head probe moved to crossfadePreload.ts with a fixed ~30 s budget before the track needs to play (widened by trailing silence so the early advance keeps the budget). Also fired right after a seek into the window so jumping near the end still buffers in time. Checks: tsc, vitest (store suite + new units), cargo test/clippy for psysonic-audio. * feat(crossfade): recommend hot cache for trim; probe B-head regardless Add a "for reliable results, enable the Hot playback cache" note to the trim-silence toggle description across all 9 locales — hot cache keeps the next track on disk so it starts instantly past its lead silence. Fix: the leading-silence probe (B-head) now runs even when hot cache is on; only the redundant byte pre-download is gated on !hotCache. Without this, enabling hot cache (the recommended setting) would have skipped the probe and disabled leading-silence trimming. * feat(crossfade): content-driven smart crossfade overlap Smart crossfade derives the per-transition overlap purely from the waveform envelopes — max(A outro fade, B intro rise) clamped 0.5–12s — instead of the fixed crossfadeSecs ("work by fact"). The JS early advance arms the computed overlap and audio_play applies it through a new crossfade_secs_override (capping only this swap's fade); plain loud→loud endings fall back to the engine crossfade at crossfadeSecs. * feat(crossfade): "Crossfade | Smart crossfade" mode switch in UI Replace the standalone "trim silence" toggle with a Crossfade / Smart crossfade segmented control in settings and both crossfade popovers (queue toolbar + mini-player). Classic Crossfade shows the seconds slider; Smart crossfade is content-driven with no duration to set. Adds smartCrossfade / smartCrossfadeDesc strings to all nine locales and the "smart crossfade" search keyword. * feat(crossfade): don't double-fade a track that already fades out Decouple the outgoing track's fade-out from the incoming fade-in. When A carries its own recorded fade-out (outroFadeA ≥ 1s and ≥ B's intro rise), planCrossfadeTransition now sets outgoingFadeSec = 0; the engine then skips A's TriggeredFadeOut so A keeps full gain and its recording carries it down while B rises underneath — no more double attenuation that made A vanish early and B blare in. Hard-cut endings still get an engine fade over the overlap. audio_play gains outgoing_fade_secs_override (Some(0) = ride A's own fade), threaded via SinkSwapInputs.outgoing_fade_secs; the JS advance arms it alongside the overlap. * feat(crossfade): rename the smart crossfade mode to "AutoDJ" User-facing rename of the content-driven crossfade mode from "Smart crossfade" to "AutoDJ" across the settings segmented switch, the queue and mini-player popovers, all nine locales, and the settings search keywords. The underlying store flag (crossfadeTrimSilence) is unchanged. * feat(crossfade): standard ~2s blend for hard loud→loud meetings When AutoDJ trims a track's protective trailing silence and the loud ending butts straight into a loud intro, neither edge fades, so the old 0.5s anti-click floor sounded like an abrupt cut. Use a standard ~2s equal-power crossfade for that case (both edges analysed, nothing fades); real fade-outs/buildups keep their longer content-driven span, and the bare floor only survives when an envelope is missing. * fix(crossfade): keep B's fade-in across the B-head start-offset seek EqualPowerFadeIn::try_seek jumped straight to unity gain for any seek ≥100ms, which also hit the initial start-offset seek that skips the incoming track's leading silence — so a crossfaded track with trimmed lead silence popped in at full gain instead of fading in. Only skip the fade-in for mid-playback seeks (sample_count > 0); a seek before any audio has played keeps the fade-in. * feat(crossfade): gate AutoDJ early fade on next-track readiness The early, content-driven advance now fires only when the next track's audio is actually available — in the engine RAM preload slot (enginePreloadedTrackId) or local on disk (offline library, favourite-auto or hot-cache ephemeral) — via isCrossfadeNextReady(). Analysis alone is not enough: a cold, still-buffering stream would fade in over silence. When B isn't ready the gen guard stays unset so it re-checks on later ticks; if B never readies, the plain engine crossfade handles the transition (graceful degrade) instead of a broken fade. A RAM preload copy suffices — the full track need not be cached to disk. * feat(crossfade): suppress engine auto-crossfade for AutoDJ + eager preload With the hot cache off the readiness gate alone wasn't enough: the engine's progress task autonomously fires its crossfade audio:ended ~crossfadeSecs before the end, independently of JS, and would start a still-buffering next track and fade over it — an audible jump. - Engine: add autodj_suppress_autocrossfade flag (audio_set_autodj_suppress); the progress task treats it like crossfade-off, so the early timer never fires and audio:ended only comes from real source exhaustion / watchdog. - JS drives the transition: set the flag when a content fade is pending (wantEarly) and clear it for plain loud→loud / non-AutoDJ, so the normal engine crossfade is preserved there. When the next track never readies, A plays out and we degrade to a clean sequential start instead of a jump. - audio_preload gains an `eager` flag; the crossfade/AutoDJ pre-buffer passes it to skip the 8s start throttle so the RAM slot fills before the fade. * docs(changelog): AutoDJ content-aware crossfade (PR #1122) Add the 1.49.0 Added entry and the cucadmuh credits line for AutoDJ.	2026-06-18 02:15:20 +03:00
Psychotoxical	028eb65f7d	feat(titlebar): selectable window button styles + minimize toggle (#1083) ... * feat(titlebar): selectable window button styles + minimize toggle Custom title bar (Linux) gains a window-button style picker, mirroring the seekbar style picker pattern. Six form-named styles: dots, dotsGlyph, flat, pill, outline, glyph. All buttons now carry minimize/maximize/close glyphs for clear, colour-blind-friendly iconography; dots reveal glyphs on hover, dotsGlyph always shows them. - New authStore state windowButtonStyle (default dots) + showMinimizeButton, with rehydrate validation falling back to dots on unknown values. - WindowButtonPreview reuses the real .titlebar-btn classes for WYSIWYG tiles. - Picker + minimize toggle render under the Custom title bar setting, gated on the toggle being on. - Monochrome styles use --text-primary glyphs and stronger borders for contrast on dark themes. - Dev-build grey marker scoped to the real title bar so previews show true colours. - i18n keys in all 9 locales; setter and rehydrate tests. * docs(changelog): window button styles (#1083)	2026-06-13 23:52:56 +02:00
cucadmuh	891ab0dd5b	feat(now-playing): OpenSubsonic playbackReport for live now-playing (#1080) ... * feat(now-playing): adopt OpenSubsonic playbackReport for live now-playing Drive a small playback state machine (starting → playing ↔ paused → stopped) on the Subsonic-server channel when the server advertises the OpenSubsonic `playbackReport` extension (Navidrome ≥ 0.62), giving `getNowPlaying` a real transport state and an extrapolated position. Reports send `ignoreScrobble=true` so play counts stay on the existing `scrobble.view` 50% path (no double count), and the effective playback speed is included so the server extrapolates position correctly with the speed feature on. - New `playbackReportSession` FSM mirrors the existing `playListenSession` lifecycle hooks and is wired at the same player call sites (start / gapless switch / queue restore / resume / 15s heartbeat / pause / seek / stop / ended / error / app quit). Servers without the extension degrade to the unchanged legacy `scrobble.view?submission=false` presence call. - Gated through the existing serverCapabilities framework: a new `FEATURE_PLAYBACK_REPORT` (auto, extension-detected). The OpenSubsonic extensions probe now stores the full advertised list once and serves both AudioMuse `sonicSimilarity` and `playbackReport` from it, without disturbing the legacy Instant Mix opt-in on pre-0.62 servers. - Now Playing dropdown shows a live position bar and a paused indicator. - reportPlayback uses the real request params (mediaId / mediaType / positionMs). Tests: FSM transitions + gating + legacy fallback, capability resolution, extension-list probe storage/decoupling. Full suite green; no Tauri-boundary changes. * feat(now-playing): glide the Live position bar between polls Extrapolate the position of `playing` entries locally (elapsed × reported playbackRate from the last 10 s poll) and re-render once a second, so the Live progress bar advances smoothly instead of jumping on each refresh. Paused and position-less entries stay frozen. A linear width transition matched to the tick keeps the fill gliding. Only applies to clients that report a position via the playbackReport extension. * fix(now-playing): tighten Live timer layout and report resume immediately Keep the progress-bar width stable without a wide empty gap before the timer: reserve ~2ch inside the current-time span only (right-aligned), not on the whole clock block. Report `playing` to the server as soon as resume() runs, matching the immediate `paused` report on pause instead of waiting for the Rust `audio:playing` event. * docs: CHANGELOG and credits for playbackReport live now-playing (PR #1080)	2026-06-13 05:31:26 +03:00
Psychotoxical	1a82376f8c	feat(music-network): unified scrobble & enrichment framework (replaces hard-wired Last.fm) (#1066) ... * feat(music-network): core domain types and wire contracts Foundation for the Music Network framework: provider-agnostic domain types, capability model, typed errors, and account shapes under src/music-network/core, plus the ScrobbleWire / EnrichmentWire / PresetManifest / AuthStrategy contracts. No runtime wiring yet. * feat(music-network): generic audioscrobbler/listenbrainz/maloja transports Generalize the Rust remote layer for the Music Network framework. Add provider-agnostic transports parameterized by base_url: - audioscrobbler_request: Audioscrobbler v2 with caller-supplied endpoint (Last.fm, Libre.fm, Rocksky, custom GNU FM, Maloja compat share it) - listenbrainz_request: Token-header JSON (direct + Maloja LB compat) - maloja_request: native /apis/mlj_1 JSON lastfm_request stays as a thin transition delegate against the fixed host; it is removed once the framework owns all call sites. Wiremock tests cover audioscrobbler_request with a custom base_url and API-error mapping. * feat(music-network): audioscrobbler wire with last.fm + libre.fm presets Add the Audioscrobbler v2 wire, the behavioural successor to the legacy src/api/lastfm.ts, implementing the full EnrichmentWire surface (scrobble, now playing, love/unlove, loved sync, similar artists, track/artist stats, top lists, recent tracks, user profile, urls). - client.ts: transport wrapper over audioscrobbler_request, classifying failures into MusicNetworkError without touching any store - sign.ts: TS mirror of the api_sig base-string ordering rule (unit-tested) - auth/tokenPoll.ts: browser token-poll connect flow as a reusable strategy - presets/lastfm.ts, presets/librefm.ts: bundled, enrichment-capable, token-poll presets (both endpoints verified live) Extends WireContext with profileBase and ConnectContext with authBase so URL builders and connect flows need no preset lookup. * feat(music-network): listenbrainz + maloja-native wires, paste-auth presets Add the scrobble-destination wires and presets: - ListenBrainz wire (scrobble + now playing via playing_now), backing both the direct api.listenbrainz.org preset and the Maloja /apis/listenbrainz compat preset (one wire, two presets, differing only by base URL) - Maloja native wire (/apis/mlj_1/newscrobble, scrobble only — Maloja has no now-playing endpoint) - Shared api_key_only paste-auth strategy (token/key/session-key paste); the Audioscrobbler wire now dispatches token-poll vs paste by preset - Presets: listenbrainz, maloja_listenbrainz, maloja_native, rocksky (scrobble-only, session-key paste, bundled keys — verified live), and custom_gnufm (token-poll, user-supplied url/key/secret) - Contracts: ConnectContext.authStrategy, PresetManifest.selfHostedApiSuffix maloja_compat (the {url}/apis/audioscrobbler mode) is intentionally omitted: its protocol cannot be verified and is almost certainly the legacy handshake, not the 2.0 web API; Maloja is covered by the native and ListenBrainz modes. * feat(music-network): registry, orchestrator, enrichment router + runtime facade Wire the framework together behind a single facade: - registry: wireRegistry (WireId -> wire), presetRegistry (the 7 built-in presets), registerBuiltinWires (one-time side-effect registration) - CapabilityProbe: wire probe overlaid by manifest staticCapabilities as the final authority (lets two presets on one wire diverge, e.g. Rocksky's nowPlaying:false over the Audioscrobbler wire's optimistic yes) - ScrobbleOrchestrator: best-effort fan-out; flips the per-account session-error flag on AUTH_SESSION_INVALID and clears it on next success - EnrichmentRouter: resolves the single primary to its EnrichmentWire; the type guard rejects non-enrichment wires (Maloja/ListenBrainz) - MusicNetworkRuntime: the only app entry point — accounts, roles, fan-out, enrichment, urls, probe. Reads/writes state through the MusicNetworkStore port (Phase 5 backs it with the auth store) and a RuntimeHost for side effects - getMusicNetworkRuntime singleton + index.ts public barrel Tests cover fan-out, master toggle, capability gating, session-error flip/clear, primary eligibility, and enrichment routing. * feat(music-network): auth-store state + lossless legacy migration + runtime bridge Add the persisted Music Network state to the auth store and wire the runtime, all additively — nothing existing breaks yet. - authStoreTypes: musicNetworkAccounts / enrichmentPrimaryId / scrobblingMasterEnabled + actions; legacy lastfm* fields kept until Phase 6 - authMusicNetworkActions + defaults/wiring (synchronous localStorage) - accountPersistence: migrateLegacyLastfm (lossless — preserves session key, username and scrobbling preference; fills bundled Last.fm key from the preset; sets the migrated account as enrichment primary) + sanitizeAccounts - authStoreRehydrate: one-shot migration guarded by a sentinel so a later disconnect cannot resurrect the account from still-present legacy fields - musicNetworkBridge: backs the MusicNetworkStore port with the auth store and the RuntimeHost with the Tauri shell; initialized in pre-React bootstrap nowPlayingEnabled stays a global toggle (not a lastfm* field); the Phase 6 playback call-site will gate dispatchNowPlaying on it, preserving behaviour. * feat(music-network): route playback, enrichment and love through the runtime Migrate every Last.fm call-site onto the Music Network runtime, preserving behaviour: - playback (audioEventHandlers, playTrackAction): scrobble@50% and now-playing via dispatchScrobble/dispatchNowPlaying; loved-fetch via isTrackLoved. Now- playing follows scrobbling (as Last.fm did), Navidrome now-playing keeps the nowPlayingEnabled gate - enrichment: useArtistSimilarArtists, useNowPlayingFetchers, Statistics, and the ArtistDetail similar-artists gate now use the runtime, gated on an enrichment primary - love: PlayerBar, PlayerTrackInfo, all context menus, useNowPlayingStarLove and the startup loved-sync route through setTrackLoved / toggleNetworkLove - player store: lastfmLoved/lastfmLovedCache -> networkLoved/networkLovedCache; lastfmActions -> networkLoveActions; loved cache storage renamed with a lossless legacy-key fallback - getMusicNetworkRuntimeOrNull() for best-effort callers so they no-op (not throw) before the runtime is initialized src/api/lastfm.ts and the Integrations UI still use the legacy path; they are migrated and removed in the next phase. * feat(music-network): manifest-driven Integrations UI + scrobble batch format Replace the Last.fm Integrations card with a manifest-driven Music Network section, and fix Audioscrobbler scrobbling to the batch/array shape. - settings/musicNetwork/: MusicNetworkSection (master toggle, destination cards, enrichment-primary picker, Maloja proxy warning, add-a-service list) driven entirely off the preset registry; icon map from PresetManifest.icon - IntegrationsTab delegates to MusicNetworkSection (Discord/Bandsintown/ Navidrome now-playing unchanged) - i18n: musicNetwork.* across all 9 locales, incl. a per-field help hint for Rocksky's CLI session-key flow (rocksky login) - scrobble now uses the documented array form (artist[0]/track[0]/…); the bare single form is only tolerated by Last.fm, Rocksky requires the indexed form - auth-error detection keys off the response message (not the ambiguous numeric code) so a Rocksky server-500 no longer flips the account to a reconnect state - PresetManifest.PresetField gains an optional helpKey Rocksky's server rejects some non-ASCII track metadata with a 500 — a Rocksky backend bug; the client call is correct (verified). * fix(music-network): clearer Integrations layout + scrobble batch fix Address UI feedback on the Music Network section: - per-account scrobble toggle moves inside its account block (was a loose row between cards — unclear which account it belonged to) - master toggle and the primary-service picker are now boxed blocks at the top, not bare rows - primary-service copy reworked: 'Primary service' + a line spelling out that liked tracks/similar artists/stats come from it while scrobbling still goes to all enabled services - distinct zones separated by dividers (master/primary · connected · add) Also folds in the verified scrobble fixes: documented array form (artist[0]/track[0]/…) so Rocksky accepts scrobbles, and auth-error detection by message rather than the ambiguous numeric code (a Rocksky server-500 no longer flips the account to a reconnect state). Rocksky session-key field gains a CLI help hint (rocksky login), all 9 locales. * feat(music-network): indicator + remove legacy lastfm path Phase 7b/7c — finish the cutover and delete the old Last.fm path. - LastfmIndicator -> MusicNetworkIndicator (shows the enrichment primary's status, click -> Integrations) - delete src/api/lastfm.ts; remove Rust lastfm_request (remote.rs + lib.rs) - remove legacy authStore lastfm* fields, actions and types; delete authLastfmActions.ts; rehydrate migration reads the legacy blob via a cast - migrate the remaining NowPlaying call-sites (NowPlaying.tsx + the now-playing fetchers/prewarm/star-love hooks) off lastfmSessionKey/lastfmUsername onto the enrichment primary (gate + cache key) - type imports LastfmTrackInfo/LastfmArtistStats -> music-network TrackStats/ ArtistStats; drop 8 stale api/lastfm test mocks and the obsolete Last.fm auth tests; update settingsTabs + src/CLAUDE.md No lastfm imports remain outside src/music-network/; lastfm_request removed (acceptance §12). tsc clean, 1947 frontend tests + remote rust tests green. * test(music-network): cover scrobble shape + error classification, drop dead i18n keys Remove the 14 unused legacy scrobble/connection i18n keys across all 9 locales (settings.lfm*/scrobble*, connection.lastfm*); the live love, profile-link and now-playing keys stay. Add regression tests for the parity-critical transport logic: the indexed batch/array scrobble body, the auth-vs-network error classification (numeric codes collide across providers), and the manifest-overrides-probe capability merge. * feat(music-network): provider-agnostic UI + Maloja Audioscrobbler & Koito presets - de-hardcode the single provider name across every enrichment surface (love labels, now-playing badge, stats title); derive it from the enrichment primary and interpolate via {{provider}} i18n params - surface a toast when a paste-auth connect probe fails — a static 'supported' capability flag no longer masks a runtime probe error - add the Maloja Audioscrobbler (GNU FM) preset (the third Maloja wire mode) and a Koito preset (ListenBrainz-compatible), both data-only - generalise PRIVACY.md and the scrobbling help entry to the framework - rename residual lfm* identifiers to network*; strip legacy flat lastfm* fields from the persisted blob; neutral transport error prefix - tests: error classification, scrobble body, capability probe, registry * fix(music-network): validate paste-auth keys on connect + UI polish - AudioscrobblerWire.probe now validates an api_key_only session with a signed call and reports scrobble:'error' only on a genuine auth failure (a scrobble-only service that rejects user.getInfo is not a bad key), so an invalid Maloja Audioscrobbler / Rocksky key surfaces a connect toast instead of failing silently; WireContext carries the preset authStrategy - drop the unreachable Statistics empty-state branch and its dead lfmNotConnected i18n key; use the useEnrichmentPrimaryLabel hook there - drive the love-button glyph from the enrichment primary's manifest icon; neutral Music Network section icon; remove a dead LastfmIcon import - tests: paste-auth vs token-poll probe behaviour * chore(music-network): rename showLastfmSimilar → showNetworkSimilar, refresh stale comments Post-parity polish: the similar-artists toggle now sources from the generic enrichment runtime, so rename the lingering lastfm-flavoured identifier; drop stale 'Mirrors today's LastfmX' doc comments referencing the removed legacy types, and generalise the scrobble-point comment. * docs(changelog): Music Network entry (PR #1066) Co-Authored-By: cucadmuh <49571317+cucadmuh@users.noreply.github.com> * fix(music-network): bound request timeout on the provider transports audioscrobbler_request / listenbrainz_request / maloja_request built a reqwest client with no timeout, so a hung provider left scrobble / probe / loved-sync promises unresolved. Add a shared provider_http_client() with a 15s timeout, matching the sibling fetch_* commands. Addresses review C3. * refactor(music-network): dedupe wire transport + no-enrichment helpers The three provider clients repeated the same invoke -> classify-error -> MusicNetworkError boilerplate, and the three probe() bodies repeated the "mark every enrichment capability no" loop. Extract wires/shared/invokeTransport() (each wire keeps its own arg shape + auth rule) and markNoEnrichment() in core/capabilities.ts. Addresses review C4. * refactor(music-network): drop write-only malojaWireMode dead state malojaWireMode was written on connect but never read — the wire is resolved by wireId and the Maloja base URL by the preset's selfHostedApiSuffix. Remove the field, the MalojaWireMode type, the malojaWireModeFor helper, the AccountPatch entry, the PresetField union member, and the export. Addresses review C1. * refactor(music-network): one useEnrichmentPrimary hook, drop lastfm fallback The enrichment-primary lookup (accounts.find by enrichmentPrimaryId) was duplicated across two hooks and inlined in the indicator and both context-menu builders, two of them with a hardcoded 'lastfm' icon fallback. Add one music-network/ui/useEnrichmentPrimary() returning {account,label,icon}|null; useEnrichmentPrimaryLabel/Icon delegate to it and the indicator + context menus consume it directly. Icon fallback is the neutral 'custom' glyph, never a provider (provider-agnostic, §7.3). Addresses review C2. --------- Co-authored-by: cucadmuh <49571317+cucadmuh@users.noreply.github.com>	2026-06-11 22:56:30 +02:00
Psychotoxical	cfc9419de7	feat(themes): sidebar notice when an installed theme has an update (#1041) ... * feat(themes): sidebar notice when an installed theme has an update Adds a dismissible sidebar pill (sibling of the What's New banner) shown while an installed community theme has a newer version in the store. Clicking opens Settings -> Themes; dismiss hides it until a new update changes the set. The theme registry is now refreshed from source once per app launch instead of only when the Theme Store tab is opened, so newly published themes and updates surface without a manual refresh -- and feed this notice. * docs: add CHANGELOG entry for PR #1041 * feat(themes): in-place update control on installed theme cards Themes with a newer version in the store now show a centered update icon on their card in Settings -> Themes; clicking it fetches and reinstalls in place. Extracts the shared installThemeFromRegistry helper (fetch -> validate -> install) used by both the store list and the card control, and surfaces the full registry entry from useThemeUpdates so the card can update directly.	2026-06-09 01:02:32 +02:00
cucadmuh	6118b3940f	feat(server): capability framework, AudioMuse sonic routing & PsyLab Connections (#1033) ... * feat(server): probe AudioMuse via OpenSubsonic and add PsyLab Connections tab Navidrome ≥0.62: detect sonicSimilarity extension for reliable plugin signal; older servers keep the legacy getSimilarSongs probe. PsyLab gets a Connections tab with session, endpoint, and active-server capability details. * feat(psylab): polish Connections tab, admin role probe, and tab bar layout Status badges and Navidrome admin/user validation in Connections; prevent PsyLab tab row from vertically collapsing under the Logs flex layout. * docs: add CHANGELOG and credits for PR #1032 * feat(settings): auto-enable AudioMuse on Navidrome 0.62+ with status indicator Replace the per-server manual toggle with a probe-driven badge when sonicSimilarity is available; pre-0.62 Navidrome keeps the legacy toggle. * feat(server): capability framework with AudioMuse sonic routing Add a declarative server-capability catalog (src/serverCapabilities/) that picks a feature strategy per server generation, runs only the needed probes, and routes API calls. AudioMuse Instant Mix now prefers the OpenSubsonic sonicSimilarity endpoint (getSonicSimilarTracks) on Navidrome 0.62+ and falls back to legacy getSimilarSongs. - catalog/context/resolve: eligibility, detection, activation, call routing - storeView: read facade over the existing per-server probe maps - getSonicSimilarTracks API client + fetchSimilarTracksRouted router - route Instant Mix and Lucky Mix through the resolver - ServersTab + PsyLab Connections read the resolver (auto status vs toggle) - tests: resolve, storeView, router * docs: update CHANGELOG and credits for PR #1033 Renamed branch supersedes PR #1032: point changelog/credits at #1033 and document the server-capability framework, auto-managed AudioMuse indicator, and sonic Instant Mix routing. * refactor(server): address PR #1033 review — idempotent probe, drop dead code - Make scheduleInstantMixProbeForServer idempotent: skip when a definitive result is cached; re-probe only on force (add/edit/test server), a prior error, or a server version/type change (invalidated in setSubsonicServerIdentity). Removes the steady-state 120 s re-probe, the present→probing→present flicker, and the momentary legacy-fallback routing window. - Remove now-dead identity helpers (showAudiomuseNavidromeServerSetting, isAudiomusePluginAutoManaged, isNavidromeSonicSimilarityEligible, resolveAudiomusePluginProbeUiStatus + type) and the superseded probeAudiomusePluginWithCredentials; the catalog is the single source of truth. - Drop the never-emitted 'unsupported' AudiomusePluginProbeResult variant. - Fill audiomuseStatus* keys in all 8 non-en locales. - Tests: probe idempotency + version-change invalidation; retarget OpenSubsonic test to fetchOpenSubsonicExtensionsWithCredentials.	2026-06-08 23:16:29 +02:00
cucadmuh	2d3c723a6e	feat(offline): unify local playback, offline library, and favorites sync (#1008) ... * feat(local-playback): LP-1 media layout and download_track_local Add library-index-backed path builder in psysonic-core and a unified Tauri download command that writes under media/{cache|library}/ with layout fingerprints; legacy hot/offline commands unchanged for now. * feat(local-playback): LP-2 localPlaybackStore and media tier Rust helpers Add unified Zustand index with legacy offline/hot-cache import, media_layout TS mirror, and Rust commands for tier size/purge/delete/promote. * feat(local-playback): LP-3 wire prefetch and playback to unified index Route downloads through download_track_local, delegate hot/offline shims to localPlaybackStore, and update resolve/promote/prefetch plus key rewrite. * feat(local-playback): LP-4–LP-6 offline UI, invalidation, and mediaDir Offline Library loads pinned groups via library index; sync-idle invalidates stale paths; Settings uses a single mediaDir with cache/library tier sizes. * feat(local-playback): migrate legacy offline files to media/library layout Move flat psysonic-offline downloads into nested media/library paths using library index metadata, with retry on sync-idle when tracks are not yet indexed. * feat(local-playback): simplify offline disk migration and restore Offline Library UI Scan psysonic-offline on disk and relocate by library track id; restore pinSource and cover art for migrated pins; add find_live_by_id for segment/key resolution. * feat(local-playback): disk-first offline reconcile and fast library tier discovery Reconcile library-tier index against on-disk files using candidate track IDs instead of scanning the full catalog. Refresh Offline Library from disk on open and focus so deleted folders drop out of the UI. Add Rust discover/prune helpers and wire album/server reconcile through the unified path. * fix(offline): resolve local playback URLs across server index-key variants Offline Library play failed when library-tier files were indexed under a host key while playback looked up only the active profile UUID. Use findLocalPlaybackEntry for URL resolution, pin queueServerId to the card server, and build play queues from tracks that still have on-disk bytes. * fix(offline): playlist cards, playback from Offline Library, and local URL routing Show playlists with name and quad/custom cover instead of the first track's album artist. Build play queues with library-batch fallback and offline-only server switch. Prefer library-tier URLs in playTrack; add playback-unavailable toast and missing trackToSong import. * fix(cache): ephemeral disk reconcile, empty-dir prune, and Storage UI Sweep media/cache after eviction (orphan files, stale index, empty folders). Settings: split media folder from cover cache; in-browser image cache lives under Cover art cache with aligned columns; clear only IndexedDB images. * feat(offline): show library disk usage in Offline Library header Query media/library tier size on reconcile and display it in a right-aligned stat block beside the page title and album count. * fix(cache): defer unindexed hot-cache eviction; drop legacy offline size cap Reconcile ephemeral cache without deleting files from other app instances; evict unindexed hot-cache files oldest-first only when over hotCacheMaxMb. Remove the hidden maxCacheMb gate and offline-full banner on album pages. * feat(offline): play-all cache card and stable Offline Library grid rows Add a shuffle-and-play card for all on-disk library pins plus hot-cache tracks when buffering is enabled. Fix virtual row height for offline cards and reserve the year line so grid rows no longer overlap. * feat(offline): queue-cache grid card limited to media/cache Replace the full-width play-all banner with a playlist-style grid tile. Shuffle/enqueue only ephemeral hot-cache tracks when buffering is enabled, not offline library pins. * chore(licenses): regenerate bundled OSS list for 1.48.0-dev Set GPL-3.0-or-later on workspace crates and extend cargo-about accepted licenses so generate-licenses.mjs runs; refresh src/data/licenses.json. * feat(favorites): auto-sync starred tracks into separate media/favorites tier Keep manual Offline Library in media/library/ and favorites offline in favorite-auto/index + media/favorites/ so toggling sync cannot purge user-pinned bytes; playback resolves library before favorites. * feat(favorites): compact offline toggle with disk icon and sync semaphore Move control to the page header (disk + switch, tooltips); show red/yellow/green LED when enabled instead of the full-width save-offline card. * fix(favorites): trigger offline sync on star/unstar from anywhere Hook star/unstar API so favorites offline reconcile runs globally (songs, albums, artists); optimistic unstar removes local bytes; drop Favorites-page-only sync. * fix(cache): skip hot-cache prefetch when favorites or library bytes exist Treat favorite-auto tier like offline library for prefetch, stream promote, and same-track replay so synced favorites are not duplicated in media/cache. * fix(favorites): reconcile offline files on merged track union only Dedupe artist/album/song stars into one target set per track id; drop eager unstar deletes so overlapping favorites do not remove bytes still needed. * feat(offline): add Favorites card to Offline Library Mirror queue-cache card for favorite-auto tier with play, enqueue, and navigation to Favorites on card click. * feat(offline): show library+favorites disk total with icon breakdown Sum media/library and media/favorites in the On disk widget and open an icon popover on hover with per-tier sizes for screen readers and sighted users. * feat(favorites): enable offline Favorites tab when auto-save is on Keep Favorites in the sidebar when disconnected, land on /favorites without manual pins, and load starred rows from the local library index. * feat(favorites): cross-server offline browse with per-server covers When auto-save is on, Favorites merges starred items from every indexed server and syncs each server independently. Detail links carry ?server= for offline album/artist pages; cover art resolves disk cache by entity serverId instead of the active server only. * feat(playback): mixed-server queue scope and cross-server favorites sync Per-ref server identity for playback (URL index key in queue refs, profile UUID for API): trackServerScope, playbackServer helpers, gapless/scrobble/covers by playing ref. Remove cross-server enqueue block; remap queueItems on URL remigration. Favorites: star/unstar and favorite-auto sync target the owning serverId (not only active); queueSongStar passes server through pending sync. * fix(offline): suppress Subsonic calls during favorites and local playback Add reachability guards so offline favorites browse, album detail, queue sync, scrobble, and Now Playing metadata skip network when the server is down or the track plays from psysonic-local. Load starred albums/tracks from the library index only (not the full artist table), refresh favorites from index first, and pass server scope in favorites navigation. * fix(queue): export share and playlist save for active server only Mixed-server queues now filter queue refs by the browsed server profile before copying a share link or saving/updating a playlist from the toolbar. * fix(offline): complete album pins and resume interrupted downloads Prefer full getAlbum track lists when online so partial library index does not truncate offline pins; refresh songs before pin from album detail. Resume incomplete persisted pins after reconcile and reconnect, cancel in-flight work on delete, and chunk library batch fetches past 100 refs. * fix(offline): pin queue, queued UI, and re-pin after remove Serialize album and playlist offline pins so parallel enqueue no longer drops in-flight work. Show an explicit queued state on album and playlist actions with dequeue on repeat click, sidebar tooltips for long labels, and clear stale cancel flags so Make available offline works after remove. * fix(offline): remove Offline Library cards without full page reload Optimistically drop the deleted card from local grid state, show the loading spinner only on first visit, and ignore stale disk refreshes so pin updates no longer flash the whole library view. * fix(offline): artist discography pin state and queue handling Detect cached/queued/downloading from persisted album pins instead of ephemeral bulkProgress, skip already offline or in-flight albums when enqueueing discography, and show the correct hero button after revisit. * fix(local-playback): address LP-1 review handoff (B1, M1–M7) Harden media path sanitization and tier containment, align Rust/TS layout fingerprints, serialize per-track downloads, and fix favorites re-enable, multi-server debounce, prev-track promote key, now-playing reachability, and ephemeral prefetch soft-skip for unindexed tracks. * fix(offline): cancel in-flight favorites downloads on unstar Abort Rust streams with the real favorites downloadId when sync is rescheduled or disabled, and drop completed bytes that no longer belong in the starred set so unstar does not leave orphan files on disk. * fix(build): resolve TypeScript errors blocking prod nix build Align mediaLayout with LibraryTrackDto camelCase, extend analysis-sync reasons, fix OfflineLibrary grid cover typing, and tighten vitest mocks so `tsc && vite build` passes under the flake beforeBuildCommand. * fix(rust): satisfy clippy too_many_arguments for CI Bundle offline-library analysis and local path/migration helpers into parameter structs so `cargo clippy -D warnings` passes on the branch. * fix(settings): show correct hot-cache track count in Buffering section Count ephemeral localPlayback rows instead of prefix-matching index keys, which always missed host:port server segments and showed zero tracks. * fix(media-layout): align truncation threshold on code points (M1) Rust sanitize_and_truncate_segment now uses char count like TS so long non-ASCII metadata does not diverge layout fingerprints; add Cyrillic parity tests and clarify ephemeral cold-miss doc on download_track_local. * fix(test): use numeric cachedAt in hotCacheStore count test Align test fixture with LocalPlaybackEntry type so tsc passes in CI. * docs: add CHANGELOG and credits for offline experience PR #1008 * feat(offline): auto-sync manually cached playlists when track list changes Re-download new tracks and prune removed ones for playlist pins only, triggered from updatePlaylist, playlist detail load, smart-playlist polling, and reconnect. * docs: note cached-playlist sync in CHANGELOG and credits for PR #1008 * fix(offline): exclude smart playlists from manual offline cache and sync Hide cache-offline for psy-smart-* playlists, block download/sync paths, and document the distinction in CHANGELOG. * feat(offline): auto-sync cached albums and artist discographies Generalize pinned playlist reconcile into pinnedOfflineSync so manually pinned albums and artist discographies re-download added tracks and prune removed ones on reopen, reconnect, and catalog changes. * feat(offline): split pinned sync triggers by pin kind Album and artist pins reconcile after library index sync and reconnect; regular playlists reconcile hourly and on in-app playlist edits only. Remove reconcile-on-open for album, artist, and playlist detail views. * fix(offline): address PR #1008 review (N1, tests, pin queue) Scope playlist reconcile to the owning server via getPlaylistForServer. Add artist discography and mixed-server playlist tests; dedupe pending sync jobs; skip pinTasks overwrite during active downloads.	2026-06-06 22:43:03 +03:00
cucadmuh	40db6b08d2	chore(playback): remove Preload Next Track setting (#1007) ... * chore(playback): remove Preload Next Track setting The configurable next-track RAM preload duplicated hot cache and is obsolete now that ranged streaming starts playback sooner. Gapless and crossfade still use the internal audio_preload backup when hot cache is off. * docs: add CHANGELOG entry for Preload Next Track removal (PR #1007)	2026-06-06 01:01:08 +03:00
Frank Stellmacher	dc4eef1a97	feat(fullscreen-player): rebuilt static fullscreen player (#1001) ... * feat(player): static media-center fullscreen player (v1) New lean fullscreen player: sharp full-bleed background (artist photo, cover fallback), no blur / no continuous animations. Bottom-left big cover bottom- flush with a full-width semi-transparent text bar (title with queue position, artist, year/genre + rating stars, next-up); control row of transport · center time · actions; full-width seekbar; live clock. Only the seekbar, time readout and clock update at runtime, each owning its state (no per-tick re-render). Reuses FsSeekbar/FsPlayBtn, the cover/artist hooks, idle-fade and queue helpers. Wired in AppShell; old player kept for A/B. * feat(fullscreen-player): true waveform seekbar instead of thin bar Replace FsSeekbar with the real WaveformSeek (cucadmuh's idea). The taller canvas grows the bottom cluster upward, shifting the info/control rows up. Height clamped to 32-52px. * feat(fullscreen-player): up-next popover + control-bar styling - Queue button opens a semi-transparent 'Up next' popover anchored bottom right; clicking a row jumps to that queue item. - Larger bottom-right action buttons. - Control row gets its own darker semi-transparent bar (touches the info bar above) for contrast; play button matches the plain transport buttons (no white circle, same size). * feat(fullscreen-player): high-res (2000px) background cover Fetch the full-screen background cover at the 2000px tier via the existing on-demand fullRes path (same getCoverArt fetch, saved as a high-res WebP outside the backfill pipeline) instead of the low-res 500px pipeline tier. usePlaybackCoverArt now forwards a fullRes option to useCoverArt. * feat(fullscreen-player): scrolling lyrics overlay + control-bar polish - Lyrics button next to Queue toggles a centered, dark semi-transparent scrolling-lyrics overlay (reuses FsLyricsApple). - Control bar darkened to match the lyrics overlay (0.88). - Close button sized down to harmonize with the clock. * feat(fullscreen-player): make rating stars clickable The rating stars next to the year were display-only. Wire them to queueSongRating (same path as the player bar / context menu): click to set, click the current value to clear, with a hover preview. Keeps the lucide outline look to match the rest of the control bar. * fix(fullscreen-player): stable, high-res album cover The foreground cover was keyed per track, so Navidrome's per-track `mf-<id>` coverArt re-triggered the distinct-disc heuristic and reloaded the cover on every song change within the same album. Key it on albumId (via useAlbumCoverRef) so it stays put while the album is unchanged. It also used the low-res tier; reuse the fullRes 2000px cover already fetched for the background so the foreground is crisp and both share a single fetch/decode. * refactor(fullscreen-player): remove the old player and its settings The static rebuild is now the only fullscreen player. Delete the old FullscreenPlayer component, its old-only parts (FsArt, FsPortrait, FsSeekbar, FsLyricsRail, FsLyricsMenu, useFsDynamicAccent) and its test. Remove the now-orphaned settings (showFullscreenLyrics, fsLyricsStyle, showFsArtistPortrait, fsPortraitDim) along with the Appearance 'Fullscreen player' section and its search entry. The new player always shows the artist photo with cover fallback and has its own lyrics toggle. Shared building blocks used by the static player (FsLyricsApple, FsPlayBtn, FsClock, FsTimeReadout, FsQueueModal, useFsArtistPortrait) are kept. * i18n(fullscreen-player): translate the new player's strings Wire the static player's previously English-only strings through i18n across all 9 locales: now-playing label, track position, up-next label, queue/lyrics/shuffle controls, and the queue overlay (title, empty, close). Reuses existing queue.title / common.close keys; adds six new keys to the player namespace. * docs(changelog): note fullscreen player rebuild (#1001)	2026-06-05 14:23:47 +02:00
Frank Stellmacher	c39465dfad	feat(sidebar): toggle to pin Now Playing to the top (#1000) ... * feat(sidebar): add toggle to pin Now Playing to the top The fixed Now Playing entry can now be pinned to the very top of the sidebar (above the Library label) instead of sitting above the bottom spacer. Adds a persisted `nowPlayingAtTop` setting (default off, so existing layouts are unchanged) and a toggle in the sidebar customizer next to the Mix-navigation split. The entry stays non-hideable and keeps its playing indicator in both positions. * i18n(settings): Now Playing-at-top toggle strings (9 locales) * docs(changelog): note Now Playing top toggle (#1000)	2026-06-05 12:35:39 +02:00
Frank Stellmacher	1de2b0e850	feat(queue): switchable queue display mode (Queue vs Playlist) (#922) ... * feat(queue): add queueDisplayMode setting with rehydrate (default queue) * feat(queue): render upcoming-only or full timeline by mode, with header toggle * feat(settings): add queue display mode toggle to Personalisation * i18n: queue display mode strings across all locales * test(queue): display-mode rendering and absolute index mapping * docs: changelog + credits for queue display mode (#922)	2026-05-30 00:26:07 +02:00
Frank Stellmacher	455aec4def	feat(discord): show track title in Discord member list (configurable name template) (#885) ... * feat(discord): override activity name in member list with track title (configurable template) The Discord member list and the collapsed Rich Presence card display the activity's `name` field next to the music icon. Without an override Discord falls back to the registered application name ("Psysonic"), so the line reads "Psysonic" while every track plays instead of the actual track title that comparable players show. Add a fourth user-configurable template `discordTemplateName` (Settings -> Integrations -> Discord Rich Presence). The Rust side passes it through `Activity::new().name(...)` when the rendered template is non-empty; an empty template falls back to Discord's default application name. Default template is "{title}". Tauri boundary: additive optional `nameTemplate` field on the existing `discord_update_presence` command. Existing call sites that omit it keep working -- the Rust handler applies the same "{title}" fallback. * i18n(settings): discord name template label in all locales Adds the discordTemplateName label across en, de, fr, es, nl, nb, ro, zh, ru -- shown next to the new "User list line (name)" template input under Discord Rich Presence. * docs(release): CHANGELOG and credits for discord name template (PR #885)	2026-05-28 20:32:41 +02:00
Frank Stellmacher	403979b35d	feat(input): opt-in WebKitGTK focus repaint workaround for Linux (#342, #782) (#884) ... * feat(input): opt-in WebKitGTK focus repaint workaround for Linux (#342, #782) Some Linux users on WebKitGTK 2.50.x report a freeze when clicking text fields: the field receives focus (right-click paste still works) but the canvas never redraws until the window is resized. Likely a layer-flush / composition scheduling bug in 2.50.x's Skia rendering pipeline. Off by default. When enabled in Settings -> System -> Behavior, every input/textarea focus triggers a sync reflow read plus a one-frame translateZ(0) toggle on the input's parent so WebKit re-evaluates the layer tree. Side-effect: search-icon siblings flicker briefly on focus -- accepted trade-off, only paid by users who opt in. The toggle row is gated on IS_LINUX and sits next to the existing Linux WebKitGTK options. The effect subscribes to the auth store and re-attaches the focusin handler whenever the flag flips, so toggling off cleanly removes the listener. * i18n(settings): linux input repaint toggle in all locales Adds linuxWebkitInputForceRepaint label + description across en, de, fr, es, nl, nb, ro, zh, ru. * docs(release): CHANGELOG and credits for linux input freeze workaround (PR #884)	2026-05-28 20:01:25 +02:00
Frank Stellmacher	9fa086c428	feat(server): dual server address (LAN + public) per profile (#880) ... * feat(server): ServerProfile.alternateUrl + shareUsesLocalUrl Additive optional fields on ServerProfile to back the dual-address work. 'alternateUrl' is the optional second endpoint (e.g. LAN counterpart of a public 'url' or vice versa); 'shareUsesLocalUrl' chooses which of the two goes into Orbit / entity / magic-string shares when both are set. Pure schema change — no runtime consumers yet. Single-address profiles keep the same persisted shape; the optional fields are simply absent. * feat(server): serverEndpoint module with LAN classification + IPv6 Introduces a single home for connect-/share-layer URL utilities that the dual-address work will build on: * normalizeServerBaseUrl(raw) — aligned with serverProfileBaseUrl * isLanUrl(url) — IPv4 (unchanged) + IPv6: ::1 loopback, fe80::/10 link-local, fc00::/7 ULA, and IPv4-mapped (both dot-decimal and the URL-API-normalized hex form, since new URL() rewrites ::ffff:1.2.3.4 to ::ffff:HHHH:HHHH) * allNormalizedAddresses(profile) — deduped [url, alternateUrl?] * serverAddressEndpoints(profile) — LAN-first ServerEndpoint[] isLanUrl moves out of useConnectionStatus.ts (the hook now imports + re-exports it for backward compatibility); OrbitStartModal points at the new path directly. 38 unit tests cover the IPv4/IPv6 matrix, dedupe, ordering, and edge cases. * feat(server): pickReachableBaseUrl with in-memory connect cache Adds the runtime connect layer on top of serverEndpoint: * pickReachableBaseUrl(profile) — sequential LAN-first ping via the existing pingWithCredentials; first OK wins. * ensureConnectUrlResolved(profile) — boot / switch / online-event entry point (same mechanism, intent-named). * In-memory cache keyed by profileId; sticky behaviour tries the cached endpoint first, falls back to the natural order on miss. * invalidateReachableEndpointCache(profileId?) — single-profile and whole-cache flushes for profile-edit / credentials-change / online. * getCachedConnectBaseUrl(profileId) — sync getter for getBaseUrl fallback path (next commit). The cache is **session-only**, never persisted. Single-address profiles keep the same shape (one endpoint, one ping). 9 new unit tests cover single + dual address, LAN-first preference, fallthrough, unreachable + stale-cache clear, sticky hit, and the two invalidate flavours. * feat(server): getBaseUrl reads connect cache, falls back to primary url Dual-address profiles need 'getBaseUrl' to return the runtime-probed connect URL (LAN at home, public elsewhere), not the literal primary 'url'. To keep the sync getter shape that ~60 call sites depend on, the store now reads 'getCachedConnectBaseUrl(server.id)' from the serverEndpoint cache. If no probe has run yet (very early boot, before switchActiveServer populates the cache), it falls back to the normalized primary URL — identical to today's behaviour. Single-address profiles see no difference; their cache entry equals serverProfileBaseUrl(url). * feat(server): switch + connection-status probe via ensureConnectUrlResolved Both surfaces that previously called pingWithCredentials(server.url, ...) directly now route through the dual-address connect layer: * switchActiveServer awaits ensureConnectUrlResolved(server), reads the identity (type/serverVersion/openSubsonic) off the returned ping, and hands probe.baseUrl (not server.url) to scheduleInstantMixProbeForServer so the AudioMuse probe also hits the reachable endpoint. * useConnectionStatus.check() does the same on every 120 s tick — sticky cache fast-paths the steady state, and a network change naturally flips the active endpoint without a manual retry. * useConnectionStatus.retry() and the 'online' event flush the cached entry for the active profile first, so the next probe starts from the natural LAN-first order instead of revalidating a stale URL. Single-address profiles behave identically: one endpoint in the list, one ping per check. No behaviour change for them. * feat(server): PickReachableResult.ping + connectBaseUrlForServer helper Two additive extensions to the serverEndpoint surface that the upcoming CONNECT migrations all need: * 'ping: PingWithCredentialsResult' on the OK branch of PickReachableResult so callers (switchActiveServer, useConnectionStatus) can read type/serverVersion/openSubsonic from the same probe instead of issuing a second pingWithCredentials. * connectBaseUrlForServer(server) — sync getter for the connect URL of *any* saved profile (active or not). Reads the cache, falls back to normalized primary url on miss. Becomes the canonical helper for non-active-server HTTP traffic (apiForServer, stream URLs, cover fetches, library bind session). Tests: pingOk() fixture now returns identity fields; the single toEqual-asserting test in pickReachableBaseUrl became a guarded read to keep equality concise while still asserting on the new ping field. * feat(connect): apiForServer + stream URLs route via connectBaseUrlForServer Non-active-server HTTP traffic (the apiForServer entry point, used by QueuePanel cross-server cover fetches and share-paste resolution) and the stream-URL builders previously read 'server.url' directly, bypassing the dual-address connect cache. Both now go through connectBaseUrlForServer, which serves the cached LAN/public endpoint when one exists and falls back to the normalized primary url otherwise. buildStreamUrl(id) now uses the baseUrl it already pulled from getBaseUrl() (which is connect-cache aware as of 2a6d8283) instead of re-normalizing server.url — same value for single-address profiles, correctly dual-address for the rest. Single-address callers see no behaviour change. * feat(connect): cover fetch + cover-cache ensure use connect URL Both cover-fetch surfaces previously read 'scope.url' / 'server.url' straight into HTTP requests, which would freeze the cover pipeline on the primary URL even when a LAN endpoint was reachable: * buildCoverArtFetchUrl(ref, tier) — for the 'server' scope (queue rows cached against a non-active profile) and the 'playback' scope (cross-server playback) now resolves the connect URL via connectBaseUrlForServer before handing off to buildCoverArtUrlForServer. * ensureArgsFromRef in coverCache.ts — restBaseUrl for the Tauri 'cover_cache_ensure' invoke now uses the cached connect URL for both 'server' and 'active'/'playback' scopes. Scope.url itself remains the index-stable primary URL — that's what storageKeys (INDEX) consume. Only the HTTP base shifts to the connect endpoint, exactly the split the spec calls out. * feat(connect): library bind + server-test probe via ensureConnectUrlResolved Two more 'rebind / re-test an existing saved server' paths still pinged the literal primary URL — both go through the dual-address connect layer now: * bindIndexedServer (librarySession.ts): used to ping server.url then pass serverProfileBaseUrl(server) as the bind 'baseUrl' to Rust. Now: one ensureConnectUrlResolved call covers both — probe.baseUrl feeds librarySyncBindSession directly, so Rust's per-server library sync uses whichever endpoint actually answered. Drops the pingWithCredentials and serverProfileBaseUrl imports. * testConnection (ServersTab.tsx): same shape — probe via the connect layer, read identity from probe.ping, hand probe.baseUrl to scheduleInstantMixProbeForServer so the AudioMuse probe also hits the connect endpoint. Single-address profiles still ping once. Add/edit save handlers (handleAddServer / handleEditServer) keep the direct pingWithCredentials against the user-entered data.url — that flow is the dual-address verify hook, which PR 2 extends. * feat(server): serverShareBaseUrl — public-by-default share URL picker Adds the share-layer companion to connectBaseUrlForServer. Different intent: connect picks the reachable endpoint for HTTP, share picks the URL that goes into Orbit invites / entity share payloads / queue share links / magic strings — where a guest opening the link is not on the host's LAN. Logic per spec §5.1: * Single-address profile → that one address (normalized). * Both set, default flag → public. * Both set, shareUsesLocalUrl flag → local. * Edge cases (both LAN, both public, missing one of the two): fall back to the first endpoint in the list so the function is total. Empty profile returns the normalized url (possibly empty) — defensive, never throws. 7 unit tests pin all six branches plus the empty case. Call-site migration (Orbit, copyEntityShareLink, QueuePanel, magic string srv field, findServerIdForShareUrl, Orbit LAN warning) lands in the next commits. * feat(share): Orbit + entity + queue shares use serverShareBaseUrl Four share-encoding surfaces previously read 'getBaseUrl()' (connect) or the raw 'server.url' (primary) when embedding the host into outgoing share links — both wrong for a dual-address profile: * copyEntityShareLink (track / album / artist / composer) — was getBaseUrl(); now reads serverShareBaseUrl(active). Guests opening the link are off-LAN, so public is the right default. * OrbitStartModal — was raw server?.url for both 'buildOrbitShareLink' and the LAN warning. Now goes through serverShareBaseUrl; the LAN warning correspondingly reflects the address the guest will see, not the host's primary. * OrbitSharePopover — same fix on the host-only share popover. * QueuePanel.handleCopyQueueShare — was getBaseUrl(); same migration. Single-address profiles return exactly the same string from serverShareBaseUrl as serverProfileBaseUrl(server.url) did before, so no behaviour change for the common case. shareUsesLocalUrl flips the default to LAN for the rare 'share into a LAN-only group' use; that checkbox lands with the form UI in the next sub-phase. findServerIdForShareUrl + paste-side share matchers are migrated in the next commit (read-side of the same contract). * feat(share): paste-side resolves dual-address profiles + connect URL Read-side counterpart to the encode-side migration: * findServerIdForShareUrl(servers, shareSrv) now matches a profile when shareSrv normalizes to either profile.url OR profile.alternateUrl. Without this, a paste of a link generated against the host's LAN address (shareUsesLocalUrl=true) would fail to find the local saved profile even though it's the same server. * resolveSharedSong / resolveShareSearchAlbum / resolveShareSearchArtist in enqueueShareSearchPayload now hand connectBaseUrlForServer(lookup.server) to the *WithCredentials HTTP calls instead of the raw lookup.server.url. The looked-up profile may be dual-address; this routes the song / album / artist fetch through whichever endpoint is currently reachable. Indirect consumers (shareServerOriginLabel, shareQueueServerContext) read the same findServerIdForShareUrl, so no code change needed there — they now match both addresses transparently. * feat(verify): serverFingerprint + same-server verification Pure-logic core of dual-address verify. Three exports: * fetchServerFingerprint(baseUrl, user, pass) — one ping (envelope 'version' extracted alongside type/serverVersion/openSubsonic) plus four soft-fail optional calls in parallel (getMusicFolders, getUser, getLicense, getIndexes). Optional failures collapse to null fields, not whole-fingerprint failure. Subsonic-generic — never branches on type === 'navidrome'. indexesDigest is a hash of letter-count plus sorted first 20 artist ids, so two probes against the same library see the same digest without comparing full payloads. * compareFingerprints(a, b) — strict on the ping triple (type case-insensitive, serverVersion exact, openSubsonic boolean); envelope apiVersion informational only. Body signals counted only when both sides have a non-null value; empty musicFolders [] on both sides still counts as a matching signal. Result: 'match' (>=1 common signal all agreeing) / 'mismatch' (any common differs) / 'insufficient' (0 common). No 'save anyway' for insufficient in v1. * verifySameServerEndpoints(profile, user, pass) — single-address short-circuits to ok:true (nothing to verify). Otherwise parallel fingerprint probes, then pairwise compare. Ping-fail on any endpoint reports the offending host for the UI. 20 unit tests cover the compare matrix (every body signal in every direction), Navidrome- vs minimal-Subsonic-shape probes, ping-fail, and all four verify outcomes (ok / unreachable / mismatch / insufficient). HTTP mocked via vi.stubGlobal('fetch') + plain-object Response shape (avoiding any Response-polyfill dependency). * feat(boundary): resolve_host_addresses Tauri command + TS wrapper Adds one additive invoke for dual-address form hints. Spec §9.1 + contracts.md §6. Rust side (src-tauri/src/lib_commands/app_api/network.rs): * #[tauri::command] resolve_host_addresses(hostname: String) -> Result<Vec<String>, String> * tokio::net::lookup_host with a port suffix (':0'); discards the port from each SocketAddr, dedupes addresses via HashSet. * strip_port helper handles 'host:port', 'ipv4:port', '[ipv6]:port', '[ipv6]' (no port), and bare 'ipv6' (left as-is for lookup_host to wrap). 7 unit tests cover each shape. * Lookup failure → Ok(vec![]) so a DNS hiccup doesn't surface as an error toast or block the save flow — form-hint only. Frontend wrapper (src/api/network.ts): * resolveHostAddresses(hostname) — trims, invokes, swallows errors to an empty array so consumers get a clean total function. §04 boundary note: additive command, no breaking change. Added to the invoke_handler! generate_handler list in lib.rs at the natural alphabetical-ish slot near migration_run. * feat(form): AddServerForm — second optional address + share flag + DNS hint UI side of dual-address. AddServerForm now carries the four new moving parts spec §6 calls out: * Second address field ('Second address (optional)') under the primary URL. Placeholder flips to suggest the opposite kind of address based on the primary's LAN classification. * Contextual hint under the second field when it's empty — 'add a public address for outside-home use' (primary is LAN) or 'add a local address for faster home access' (primary is public). Hint disappears once the field has content. * Two-LAN client-side check on submit: when both addresses classify as LAN, save is blocked with a toast. Reverse case (both public) intentionally allowed per spec §6.3. * shareUsesLocalUrl checkbox — visibility rule per spec §5.3: hidden until the second address has content; shows with the persisted value on edit; cleared when the user empties the second address before save. DNS hint: on primary-URL blur we call the Tauri resolve_host_addresses command and classify the response by isLanUrl. Literal IPs skip DNS (already classified locally). DNS miss → no hint surfaces (never blocks save). Used only for the hint text — connect still goes through pingWithCredentials. i18n: 9 new keys in en + ru (serverAlternateUrl*, shareUsesLocalUrl*, serverBothLanError). Other locales fall back to English. onSave signature widened to 'void | Promise<void>' — ServersTab / Login both accept that already. The save flow itself still calls the legacy pingWithCredentials path; verify wiring lands in 2e. * feat(verify): wire verifySameServerEndpoints into add + dual-edit flows Save flow now blocks persisting a dual-address profile that fails the same-server check. Spec §6.4 + §7.4. handleAddServer: * When data.alternateUrl is non-empty, runs verifySameServerEndpoints BEFORE the existing ping. mismatch / insufficient / unreachable each surface a localized toast and abort the save (no addServer call). * Single-address adds keep the legacy single-ping path — no extra network round-trip when there's nothing to verify. handleEditServer: * Unconditional save remains the default — but if the edit either introduces / changes alternateUrl OR changes url / username / password while alternateUrl is set, verify runs first and may block. * After persist, invalidates the reachable-endpoint cache for this profile id so any sticky cached connect URL from before the edit is re-probed on the next access (credentials may have changed, alternate may have appeared). i18n: 4 new toast keys in en + ru (dualAddressVerifying placeholder for future progress UI, plus mismatch / insufficient / unreachable). Other locales fall back to English. announceVerifyResult helper keeps the toast routing in one place so handleAddServer and handleEditServer share the same surface. * i18n(settings): dual-address keys across all 9 locales Adds the 13 new dual-address keys to the remaining 7 locales: de · fr · es · nl · nb · ro · zh. * serverAlternateUrl + placeholderPublic / placeholderLocal * serverAlternateUrlHintAddPublic / HintAddLocal (contextual hints under the second-address field) * serverBothLanError (client-side two-LAN validation) * dualAddressVerifying / Mismatch / Insufficient / Unreachable (toast strings; Unreachable carries the {{host}} interpolation) * shareUsesLocalUrl + Desc (checkbox label + short description) Placeholders (example.com URL / 192.168.1.100:4533) kept identical across all locales — same shape the existing serverUrlPlaceholder already uses. Single coordinated sweep so every supported language ships dual- address fully translated rather than falling back to English. * feat(cover): cover_cache_rename_server_bucket Tauri command Adds the disk-side companion to the upcoming URL-change remigration flow (dual-server-address spec §8.3). When a user edits the primary url so the derived index key changes, the SQLite migration already re-tags rows via the existing migration_run command — this command moves the cover-cache bucket on disk so cached WebP tiles stay reachable under the new key. Behaviour: * old_key == new_key → no-op. * Old bucket missing → no-op success (nothing to migrate). * New bucket missing → simple fs::rename (fastest path). * Both exist → recursive merge with 'prefer existing' on file collision (the newer bucket wins; data is never lost). * Emits 'cover:bucket-renamed' with {oldKey, newKey} on success so the frontend disk-src cache can invalidate stale URLs. Sanitization: rejects empty, backslash, and '..' path segments at the FS boundary. Forward slashes are legitimate (a Navidrome mounted at a subpath like 'music.example.com/navidrome' produces an index key with one); they're handled by Path::join. 4 unit tests cover key sanitization (accepts real keys, rejects traversal/backslash) and the merge semantics (unique-file move + prefer-existing on collision). Registered in lib.rs invoke handler. * feat(remap): rewriteFrontendStoreKeysForRemap — explicit oldKey→newKey path Adds the URL-change remigration entry point next to the existing UUID→indexKey migration. Same plumbing (offline store, hot cache, analysis-strategy maps) but driven by explicit { oldKey, newKey }[] mappings instead of being derived from the current servers list. Also folds in the player-side cleanup the existing path didn't have: * queueServerId — if currently bound to a remapped index key, repoint to the new one so playback continues through the rename instead of looking unbound. * analysisStrategyStore — runs the same map-key swap inline (the 'migrateServerOverrides' helper handles UUID→indexKey, not indexKey→indexKey). Same prefer-existing-on-collision semantics as the disk-side cover_cache_rename_server_bucket — if a destination key already carries data, we keep it. 8 unit tests cover no-ops, the four store rewrites, the queue repoint, the 'leave other servers untouched' guarantee, and the collision case. * feat(remap): serverUrlRemigration orchestrator — 4-stage pipeline Single-file orchestrator that runs the full URL-change remigration when a profile edit shifts the primary url's derived index key. Spec §8 + contracts.md §4. Two exports: * indexKeyRemapForUrlChange(prev, next): IndexKeyRemap | null — short-circuits scheme-only edits ('http://x' ↔ 'https://x'), trailing-slash differences, and alternateUrl-only changes by normalizing both sides through serverIndexKeyFromUrl and returning null when they match. Empty urls also return null. * runIndexKeyRemigration(remap): Promise<IndexKeyRemigrationResult> — runs inspect → run → frontend-rewrite → cover-rename in order, aborts on the first failure and reports the offending stage. Failure ordering rationale: * inspect / run failures stop the destructive step — DB is untouched, the caller can retry safely. * frontend rewrite swallows errors (best-effort; zustand persist catches up on rehydrate next session). * cover-rename failure is reported but does NOT roll back the DB rows (that would be even more destructive); covers under the old key recover via the existing cover backfill on next access. 10 tests cover the detect logic (5 cases including the path-suffix case) plus all four pipeline stages with mocked Tauri invoke — including verifying the legacyId/indexKey mapping shape lands on both inspect and run calls. * feat(remap): wire URL-change remigration into ServersTab edit flow handleEditServer now detects a primary-url index-key change BEFORE any other save logic (verify, persist, etc.) and orchestrates the full remigration when one is needed. Flow: * indexKeyRemapForUrlChange(prev, next) — null for scheme-only edits / alternateUrl-only edits / no-op edits, so the common case falls straight through without prompting the user. * On a real remap → confirm modal via useConfirmModalStore.request (danger style, plain-language oldKey → newKey copy, explicit 'cannot be undone'). User cancel → abort save entirely. * On confirm → runIndexKeyRemigration pipeline. Failure surfaces a stage-specific toast (inspect / run / cover-rename — wording per spec §8.4 + the recoverability matrix in serverUrlRemigration.ts). * On success → fall through to the existing dual-address verify, then auth.updateServer + invalidate cache + ping (unchanged). i18n: 7 new keys (urlRemigrationTitle / Message with oldKey + newKey interpolation / Confirm / Progress / FailureInspect / FailureRun / FailureCoverRename) — full sweep across all 9 locales (en, de, ru, fr, es, nl, nb, ro, zh). Test fixup: the offline-store collision test in rewriteFrontendStoreKeys needed an 'as unknown as' cast — the existing OfflineTrackMeta type doesn't carry the test-only marker property, and a one-step cast TS rejected as not overlapping enough. * feat(magic): magic-string v2 encode/decode with dual-address fields Adds the v2 wire format for server invites. Spec §10 + contracts.md §5.2. Encode is opportunistic: payloads with alternateUrl set OR shareUsesLocalUrl=true emit v2; everything else stays v1 byte-identical. This means single-address profiles keep producing exactly the same invite they did before — older receivers can't tell the difference. v2 shape: { v: 2, url, alt?, shareLocal?, u, w, n? } * url — the host's share URL (public by default; LAN if shareLocal), NOT necessarily the host's primary URL. Receiver treats it as the primary of the new profile (their own index key). * alt — the host's alternate address (the other half of the pair). * shareLocal — mirrors the host's shareUsesLocalUrl preference so onward shares from the receiver behave the same way. Decode accepts both v1 and v2. v2-only fields are left undefined when decoding a v1 payload (no '|| undefined' shim — kept absent so zustand persist diffs stay clean). Defensive: an empty alt on a v2 invite decodes as if the field were absent, never as ''. Test updates: 'rejects a payload with the wrong version' now targets v: 3 (v: 2 became valid). 7 new tests cover the v1/v2 wire-format choice, both v2 round-trip shapes, the v1-decode-into-v2-fields- undefined backward-compat case, and the empty-alt edge. * feat(magic): wire magic-string v2 through invite-encode + paste consumers Five surfaces now produce / accept v2 invites with the dual-address fields end-to-end: Encode side (admin → user invite): * MagicStringModal — looks up the saved profile that matches the serverUrl prop (primary OR alternateUrl normalize-match) and encodes through serverShareBaseUrl + alternateUrl + the share flag. Falls back to plain v1 for single-address profiles. * UserForm — same lookup + encode plumbing on the in-form 'Save & get magic string' flow. Decode side (paste invite into form): * AddServerForm useEffect (initialInvite from outer state) + handleMagicStringChange (live paste) both pull alternateUrl and shareUsesLocalUrl off the decoded payload into form state, so the second-address field + checkbox surface immediately on a v2 paste. * Login form state gains hidden alternateUrl + shareUsesLocalUrl fields (not user-editable — Login stays single-address by design); v2 paste / initial-invite both populate them so they persist with the new profile via addServer. handleQuickConnect likewise forwards the existing dual-address shape for already-saved profiles. * attemptConnect signature widened with the two optional fields; addServer / updateServer call sites conditionally include them only when alternateUrl is non-empty so single-address profiles keep their lean persisted shape. Both encode helpers share the same magicPayloadAddressFields lookup (MagicStringModal + UserForm) — the duplication is acceptable for two co-located small files but a single shared helper would be the natural place to consolidate if a third encoder appears. * fix(form): magic-string submit forwards decoded alternateUrl + share flag AddServerForm.submit's magic-string branch was forwarding only name/url/username/password from the decoded payload, silently dropping alternateUrl + shareUsesLocalUrl. A v2 invite pasted into the magic-string field and saved would land in the store as a single- address profile even though handleMagicStringChange had already populated the dual-address fields into form state for display. Now the magic branch picks the dual-address fields off the decoded payload (same conditional spread as the non-magic branch a few lines down) so v2 invites round-trip end-to-end through the form. * fix(verify): extractUserId drops username fallback to avoid false mismatches Spec §7.2 footnote: 'fallback (normalized username) only if no id on either side'. The old extract unconditionally fell back to the authenticated username whenever user.id was empty — but the comparator can't tell username-fallback apart from a server-supplied id. So a server pair where endpoint A returns user.id='42' and endpoint B only returns user.username='frank' would land in compare with userId values '42' vs 'frank' and report mismatch on what is actually the same user on the same server. Now extractUserId returns null when user.id is absent. Both sides returning null means compareFingerprints skips userId as a common signal (correct behaviour per the §7.3 'both sides have a value' rule). One new test pins it; the call site drops the redundant fallbackUsername argument. * fix(remap): rewriteFrontendStoreKeysForRemap migrates coverStrategyStore Spec §8.2 lists 'analysis/cover strategy maps' as targets of the URL-change remigration. The For-Remap path covered analysis but missed cover — a user-set cover strategy override (e.g. 'aggressive' for one server) would silently drop when the user edited that profile's primary URL, because the key tagged under the old index key never made it to the new one. Same shape as the analysis remap inline: prefer-existing on collision (newer key wins), delete the legacy entry afterwards. One new test pins the move; setup adds a fresh useCoverStrategyStore reset between cases. * fix(cover): is_safe_index_key rejects absolute paths + drive letters Defense-in-depth gap in cover_cache_rename_server_bucket. The old sanitizer only rejected backslashes and '..' segments — '/etc/passwd' on Unix and 'C:\Windows' on Windows both passed. Path::join with an absolute argument REPLACES the base path, so root.join('/etc/passwd') on Unix would walk out of cover-cache entirely. Real index keys never reach this state — they come out of serverIndexKeyFromUrl which strips schemes and trailing slashes, so no leading separator and no drive-letter prefix is ever produced. But the comment promises 'defense in depth' and that defense is worth completing. Now rejects: * empty keys (would join to the cover-cache root itself) * leading '/' or '\' * Windows drive-letter prefix 'X:' (case-insensitive ASCII letter) * backslashes anywhere (separators are forward-slash only) * '..' segments after split('/') One new Rust test covers all four cases. * fix(connection): isLan badge reflects active endpoint, not primary url useConnectionStatus.isLan was reading isLanUrl(server.url) — the *primary* address — so a dual-address profile that had fallen over to its public alternate kept advertising 'LAN' in the badge until the user looked at the server URL itself. Spec call-site-checklist line 25: 'active endpoint kind for badge (LAN vs extern)'. Now: ensureConnectUrlResolved returns probe.endpoint.kind on success; the hook tracks the latest kind in local state and surfaces that. Pre-first-probe fall-through keeps the old primary-URL classification so the badge has something to render at mount time. Three tests pin the three states (LAN-active after probe, public- active after fallback, primary-fallback before first probe completes); plus one for the online-event handler that invalidates the cache and re-probes. * fix(server): dedupe concurrent pickReachableBaseUrl calls for same profile Multiple call sites probe on roughly the same beat — useConnectionStatus 120-s tick + online handler + initial mount, switchActiveServer, bindIndexedServer, and ServersTab.testConnection. Two near-simultaneous probes for the same profile both observed an empty cache, both pinged every endpoint, and raced to write the sticky URL with last-write-wins. On a dual-address profile the slower probe could stomp the correct LAN sticky a millisecond after it was set. Now: an in-flight Map<profileId, Promise<PickReachableResult>>; a second call for the same id during an active probe returns the same promise instead of starting a fresh one. The finally-clear keeps the dedup window narrow (one settled probe → next call probes fresh). invalidateReachableEndpointCache deliberately doesn't touch the in-flight map — the racing probe's own finally will clean up. Three tests pin it: two concurrent calls share one ping; a fresh call after the previous settled does ping again; plus the existing shareBaseUrl two-LAN-with-flag-on test + the two-public-default test for completeness. * refactor(magic): extract magicPayloadAddressFields to single shared helper The lookup that turns a serverUrl into the v2-encode-ready { url, alternateUrl?, shareUsesLocalUrl? } shape was duplicated byte-identically between MagicStringModal.tsx and UserForm.tsx — both Navidrome admin user-mgmt encode sites. Workdocs §03 / §1a 'one source of truth for behavior'. Now lives in src/utils/server/serverMagicString.ts as a named export. Both call sites import + pass the current servers list (via useAuthStore.getState().servers) — keeps the helper pure so it's straight to unit-test if a third encoder ever appears. * fix(cover): wire cover:bucket-renamed listener for URL-change remigration cover_cache_rename_server_bucket emits cover:bucket-renamed on successful rename / merge, but no frontend listener was wiring it in. After a URL-change remigration the in-memory disk-src cache still held entries pointing at `{root}/{oldKey}/…/.webp` paths the disk no longer carries — the next read would serve a stale URL until the entry naturally aged out. New: forgetDiskSrcForServer(serverIndexKey) in diskSrcCache drops every cover entry under one server key in one pass (the existing forgetDiskSrcPrefix needs a non-empty coverArtId and can't blanket- clear a server). useCoverArtBridge subscribes to cover:bucket- renamed and calls it with oldKey. Tests: forgetDiskSrcForServer happy path, empty-key defensive no-op, no-match no-op; plus a regression-pin on the existing forgetDiskSrcPrefix so the two helpers don't drift in semantics. * test(dual-server): fill the high-impact coverage gaps from the branch review Adds the tests the review identified as missing on the hot-path UI flows + the partial-fail / alt-only edges: * AddServerForm.test.tsx (new) — five component tests: single-address save / dual-address save / two-LAN block-with- toast / v2 magic-string paste forwarding alt + share flag / edit-flow stripping alt+flag when the field is emptied. * Login.test.tsx (new) — v2 invite paste persists alternateUrl + shareUsesLocalUrl onto the saved profile; v1 invite leaves those fields undefined. * shareLink.test.ts — alternateUrl-only match for findServerIdForShareUrl (the dual-address paste case where the host shared the LAN URL via shareUsesLocalUrl=true); 'first hit wins' across two profiles where both match. * serverFingerprint.test.ts — partial-fail mix (folders+user ok, license+indexes rejected) so a Promise.allSettled regression wouldn't go silent. * cover_cache/mod.rs — rename_bucket_inner extracted as a testable FS-only helper (the Tauri command wrapper now just locks state + calls it + emits the event), plus six tests covering empty/unsafe keys, no-op-when-missing, no-op-when- equal, simple-rename, merge-with-prefer-existing. Also: every test fixture that I authored on this branch using 'frank' / 'frank@example.com' as a stand-in username/email swapped to 'tester' / 'tester@example.com' — keeping personal names out of test data is the codebase convention (see factories.ts) and is now a memory rule. * fix(test): typed mock access for pingWithCredentials in useConnectionStatus vi.mocked(...) returns the mock typed properly — bare .mock fails tsc because the imported function signature isn't a vi.Mock at import time. * docs(changelog): dual server address (PR #880) * fix(test): align diskSrcCache tests with main cover storage key API After rebase onto main, forgetDiskSrcPrefix takes a CoverArtRef-shaped argument and storage keys include cacheKind; merge coverDiskUrl tests from main with dual-address forgetDiskSrcForServer coverage.	2026-05-28 14:36:25 +03:00
cucadmuh	418b25914a	feat(cover): unify cover pipeline and stabilize mainstage/now-playing (#870) ... * chore(cover): scaffold cover module and rust cover_cache stub Wave 0: src/cover/ skeleton per contracts.md §12, stub IPC commands in cover_cache/mod.rs (no-op returns until phase B). * feat(cover): add unified cover module and tier resolver (phase A) Wave 1A: tiers, storage keys, resolveJs with cold/sibling races, useCoverArt, CoverArtImage, layoutSizes, playback scope helpers, coverSiblings tier ladder, deprecated shims on subsonicStreamUrl. * feat(cover): rust disk cache and tier-ready events (phase B) Wave 1B: cover_cache module with WebP tier encode, HTTP canonical 800 fetch, cover_cache_* commands, cover:tier-ready / cover:evicted events, disk layout tests. * feat(cover): prefetch hook, tier-ready handoff, library backfill IPC (phase B/C) Wave 2: useCoverArtPrefetch, cover:tier-ready/evicted bridge, one-time IDB cover key clear, prefetch registry drain, MainApp wiring. * feat(cover): migrate dense grids to CoverArtImage and prefetch (phase D) Wave 3A: dense surfaces use layout-native displayCssPx, surface=dense, coverPrefetchRegister on Home/Albums/search; AlbumCard cell width from grid. * feat(cover): migrate sparse surfaces and integrations (phase E sparse) Wave 3B: sparse CoverArtImage/useCoverArt, lightbox tier 2000, ArtistHeroCover, MPRIS/Discord/export integrations, playback chrome and detail heroes. * feat(cover): revalidation scheduler and disk pressure gate (phase E+) Wave 4: coverCacheMaxMb settings (en/ru), StorageTab disk usage, cover_cache_configure, useCoverRevalidateScheduler, playbackServer uses cover fetchUrl; pressure watermarks. * docs: CHANGELOG and credits for cover art pipeline PR #869 * fix(cover): stop webview getCoverArt storm on dense grids (429) Dense surfaces no longer put rotating getCoverArt URLs in img src; load disk via Rust ensure + convertFileSrc. Tier-ready notifies listeners instead of invalidating IDB. Throttle background prefetch and cap Home registry. * fix(cover): omit empty img src until cover URL is ready React 19 warns on src=""; CoverArtImage uses undefined until disk/IDB resolves; queue current track shows placeholder when src is still empty. * fix(cover): disk cache by host index key, parallel ensure, asset protocol Bind cover storage to serverIndexKey (library host), rename cover IPC/events, fix REST base URL and Tauri flat args, enable protocol-asset for disk paths, add prioritized ensure queue, and wipe legacy profile-UUID cache once. Limit Vite dep scan to index.html so research/target HTML is ignored. * fix(cover): WebP tiers, disk peek, home cache, asset URLs for mainstage Encode lossy WebP (~82), write only missing tiers, library cover backfill, and cover_cache_peek_batch for fast paint from disk. diskSrcCache + CSP asset protocol; no IDB fallback when server is up. Session Home feed cache with warm peek on return; BecauseYouLike deduped cover hook and high prefetch. * feat(cover): per-server cache strategy and native library backfill Move cover disk cache settings to Offline & cache with Lazy/Aggressive per server, per-server clear, and no size cap. Run full-catalog backfill on the Rust runtime (sync-idle wake, bounded HTTP, bulk 800px writes without flooding the webview). Drop global prefetch limits from auth store and waveform clear from the offline storage block. * fix(build): CSP connect-src for Subsonic API; quieter prod nix build Prod webview blocked axios ping after cover CSP (missing connect-src). Drop cargo tauri -v in flake build, raise Vite chunk limit, ignore tsbuildinfo. * fix(cover): complete WebP ladder in library bulk backfill Aggressive backfill now writes all derived tiers (128–800), skips IDs only when the full ladder exists (not 800 alone), avoids fetch-failed markers on bulk HTTP errors, and stops the pass when the active server changes. * fix(cover,home): navigation-priority backfill and Because You Like UX Pause library cover backfill while navigating; split peek/ensure traffic so grids and rails win over bulk work. Disk src lookup, grid warm hooks, and non-blocking mainstage prime for faster visible covers. Because You Like: session snapshot, staggered horizontal skeleton row, text hidden until cover is ready, and layout aligned with loaded cards. * feat(random-albums,library): local-first album fetch + cover art pipeline Random Albums теперь запрашивает локальный SQLite-индекс (ORDER BY RANDOM() LIMIT N) вместо сетевого запроса к серверу. При готовом индексе спиннер исчезает практически мгновенно; сеть используется только как фолбэк. - advanced_search.rs: добавляет `("random", _) => RANDOM()` в allowlist сортировок - browseTextSearch.ts: runLocalRandomAlbums — SQLite-рандом для Albums - RandomAlbums.tsx: doFetchRandomAlbums local-first для обоих путей (без жанра и с жанром через runLocalAlbumsByGenres + JS-shuffle); speculative reserve прогревает следующий батч в фоне после каждого Refresh Также: обновление пайплайна обложек (coverTraffic, peekQueue, ensureQueue, diskSrcLookup, warmDiskPeek, prefetchRegistry, useCoverArt, useWarmGridCovers, useCoverNavigationPriority, resolveIntersectionScrollRoot и сопутствующие компоненты/хуки). * fix(random-albums): prevent double-load on Zustand rehydration useEffect([selectedGenres, load]) fired twice on every visit: first with default store values, then again ~50 ms later when Zustand rehydrated mixMinRatingFilterEnabled/minAlbum/minArtist from localStorage. Previously this was invisible because the first network fetch took ~1.5 s, so loadingRef.current was still true on the second fire. With the new local-first SQLite path the first load completes in ~50 ms, leaving the guard cleared before rehydration triggers a second random batch. Fix: ref-pattern — keep loadRef.current fresh on every render, effect depends only on selectedGenres. Manual Refresh and genre-filter changes still call the latest closure correctly. * fix(random-albums): stop warmCoverDiskSrcBatch in fillReserve from causing visual flash fillReserve вызывал warmCoverDiskSrcBatch для обложек резервного батча, что вызывало bumpDiskSrcCache() для каждой новой обложки (~30+ вызовов). Это будило всех подписчиков useCoverArt на текущей странице, провоцируя видимую перерисовку примерно через ~1.5 с после загрузки (когда filterAlbumsByMixRatings делает сетевые запросы к рейтингам артистов). - fillReserve: убран warmCoverDiskSrcBatch — обложки прогреваются лениво при consume резерва через primeAlbumCoversForDisplay - reserve-путь в load(): добавлен primeAlbumCoversForDisplay перед setAlbums (аналогично non-reserve пути; при уже прогретом кэше — мгновенно) * feat(because-you-like): reserve-first pattern — instant display on return visits Каждый визит на Mainstage после первого теперь отдаёт готовую заготовку мгновенно, вместо spinner → сетевые запросы → контент. Архитектура: - resolvePicks / fetchBecauseYouLike вынесены на уровень модуля (выход из замыкания useEffect); читают текущий localStorage, возвращают { anchor, recs, nextAnchorHistory, nextPicksHistory } - fillBecauseReserve — fire-and-forget фоновая функция: запускается сразу после отображения результата, кладёт следующий батч в _becauseReserve. Covers намеренно не прогреваются (bumpDiskSrcCache на текущей странице не нужен); они прогреваются через primeAlbumCoversForDisplay при consume. - useLayoutEffect: если reserve готов — не сбрасывает стейт в skeleton (контент появляется без мигания) - useEffect: reserve-first path — consume → primeCovers → setState → fill; full-fetch path сохранён как fallback при первом визите или промахе Поведение: - Визит 1: full fetch (как раньше) → показ → fillReserve R1 - Визит 2+: consume R1 → мгновенный показ → fillReserve R2 - При сетевом сбое: restore из session cache (как раньше) * fix(because-you-like): initialise state from reserve — no skeleton flash on remount При ремаунте компонент стартовал с refreshing=true/anchor=null/recs=[] и показывал skeleton на один тик до того как useEffect отработает. Теперь useState() использует lazy initializers, которые читают _becauseReserve прямо в первом рендере: если reserve валиден — state сразу refreshing=false, anchor=X, recs=[...] и skeleton не показывается вообще. Covers уже в diskSrcCache (из предыдущего показа) и появляются без дополнительных запросов. useLayoutEffect упрощён: вызывает hasValidReserve() и сбрасывает в skeleton только если reserve отсутствует (для случая navigation без ремаунта). * fix(because-you-like): apply reserve in useLayoutEffect to handle async pool arrival Lazy initializers не могли применить reserve при первом рендере, потому что mostPlayed/recentlyPlayed/starred приходят из Home.tsx асинхронно — pool=[] на первом рендере, poolKey не совпадает с reserve. useLayoutEffect теперь активно ставит стейт из reserve (а не просто не сбрасывает): когда pool обновляется до реальных данных, useLayoutEffect срабатывает синхронно до paint, проверяет reserve и сразу применяет anchor/recs/refreshing=false. При отсутствии reserve — сбрасывает в skeleton как прежде. * fix(because-you-like): reserve > cache > skeleton — eliminate skeleton flash on mount Корневая причина: Home.tsx загружает mostPlayed асинхронно через useEffect, поэтому на первом рендере pool=[], poolKey=''. Reserve хранится с реальным poolKey → mismatch → lazy initializers запускали skeleton. Теперь двухуровневый fallback без зависимости от poolKey: 1. reserve (serverId + poolKey совпадают) → мгновенный новый батч 2. becauseYouLikeCache (только serverId) → stale-while-revalidate, контент доступен сразу с mount, обновляется тихо в фоне 3. skeleton → только при полном отсутствии данных (первый визит) Применяется одинаково в lazy useState initializers, useLayoutEffect и full-fetch path useEffect (не сбрасывать в skeleton пока есть cached контент). * fix(because-you-like): key reserve by serverId only; guard useEffect on empty pool Проблема: reserve хранился с poolKey, но на первом рендере pool=[] → poolKey='' → mismatch → показывался кэш (предыдущий набор) ~500ms пока Home.tsx не загружал mostPlayed. Исправления: - BecauseReserve: убран poolKey — reserve валиден для любого pool-состояния на том же сервере. Pool (топ-артисты) меняется медленно; один раз показать reserve с чуть устаревшим anchor лучше чем показывать предыдущий набор 500ms - hasValidReserve: проверяет только serverId - fillBecauseReserve: убран poolKey из сигнатуры и хранилища - useEffect: guard pool.length === 0 → возврат без fetch/consume; effect перезапустится когда pool заполнится (реальные deps изменятся) → reserve применяется из useLayoutEffect ещё до pool, без стале-флэша Итоговый порядок: reserve (instant, serverId) > cache (stale-while-revalidate) > skeleton (только первый визит) * fix(home): remove mix-rating deps from feed useEffect — prevent Zustand rehydration double-fetch Корень: useAuthStore(mixMinRatingFilterEnabled/Album/Artist) были в deps useEffect. Zustand persist реhydrates асинхронно — сначала activeServerId, потом mix-rating значения. Это вызывало двойной запуск эффекта: - Первый запуск: homeFeedCache hit → показывает набор предыдущего просмотра - Второй запуск (после rehydration): cache miss или повторный fetch с реальными mix-настройками → ~500ms → новый набор Итог: Hero, AlbumRow, BecauseYouLikeRail показывали предыдущий набор первые ~500ms при каждом возврате на Mainstage. Fix: убраны mixMinRatingFilterEnabled/Album/Artist из deps. getMixMinRatingsConfigFromAuth() читается внутри эффекта через getState() — всегда актуальные значения без пересоздания замыкания. Mix-настройки по-прежнему применяются при fetch, но не вызывают двойной запуск при rehydration. * feat(home): local-first discover songs via SQLite ORDER BY RANDOM() Добавлена runLocalRandomSongs (аналог runLocalRandomAlbums для треков) в browseTextSearch.ts — использует libraryAdvancedSearch с sort random, field уже поддерживается Rust-кодом через wildcarded ("random", _) ветку. В Home.tsx: discoverSongs теперь сначала пробует локальный индекс, и только при недоступности (индекс не готов, ошибка) падает обратно на getRandomSongs.view. Ускоряет первую загрузку Mainstage — треки берутся из SSD вместо сети. * fix(home): pre-populate state from cache at mount — eliminate empty-state flash on return visits Причина: Home.tsx размонтируется при навигации. При возврате первый рендер всегда с пустыми массивами (heroAlbums=[], mostPlayed=[] и т.д.), потом useEffect читает homeFeedCache и заполняет state. Даже один кадр с пустым состоянием вызывает перерисовку Hero и BecauseYouLikeRail (pool=[]). Решение: getInitialHomeFeed() читает homeFeedCache синхронно через useAuthStore.getState() (не hook) в lazy useState initializers. К моменту повторного визита store уже rehydrated — все state получают кэшированные данные до первого рендера. Дополнительно: wasPrePopulated предотвращает повторный applyFeedSnapshot в useEffect когда state уже заполнен — иначе новые ссылки на массивы вызывали бы ненужные ре-рендеры дочерних компонентов с теми же данными. * fix(mainstage): keep refresh without return flicker Keep Home and Because You Like visually stable during a single visit while still refreshing data for the next re-enter. Improve mainstage cover warmup by ensuring and pre-decoding above-the-fold artwork so hero and top rails appear instantly after navigation. * fix(mainstage): stabilize because rail and hero background framing Measure Because You Like layout before first paint to avoid width snap flicker, and render hero background as centered cover-fit images so the frame no longer jumps from top to middle on mount. * fix(now-playing): prewarm track data and prevent stale carry-over Warm Now Playing fetch caches and playback cover art on track change so entering the page no longer waits on first-load requests. Gate key-based sections (top songs, tour, Last.fm) by the active track/artist keys to avoid briefly rendering values from the previous track. * fix(cover,test): refresh playback scope and default tauri cover mocks Recompute playback cover scope when queue/server context changes so now-playing art resolves against the correct server after handoffs. Add default cover-cache invoke handlers to the shared Tauri test harness to prevent unhandled rejections in suites that mount cover-aware UI. * fix(cover,now-playing,test): align prewarm scopes and tighten tauri mocks Make cover-cache invoke defaults opt-in for tests, align radio prewarm scope with active rendering scope, and add targeted hook tests for prewarm + playback-scope reactivity. Also harden Rust cover URL building to avoid panic on malformed base URLs. * test(cover): hoist mocked useCoverArt and clean EOF whitespace Fix the new playback-scope hook test to use a hoisted vi.mock-safe stub and keep branch-wide diff checks clean by removing an accidental trailing blank line. * fix(cover): align playback ensure auth and harden backfill retry flow Use playback-server credentials for playback-scoped cover ensures, persist fetch-failed markers for bulk library backfill failures, and avoid advancing backfill cursor when UI-priority hold interrupts a batch. * fix(ci): resolve clippy lint and update frontend node runtime Move fetch helper before the test module to satisfy clippy's items-after-test-module rule, and modernize frontend CI to setup-node v6 with lts/* instead of pinned Node 20. * chore(settings): simplify cover and analytics strategy copy Move strategy summaries below tables, simplify Lazy/Aggressive wording, keep analytics warning always visible, and localize Russian texts to plain language without technical jargon.	2026-05-26 19:35:08 +03:00
Frank Stellmacher	02b2df1589	feat(lyrics): make lyrics fully disablable (independent YouLyPlus toggle) (#855) ... * feat(lyrics): independent YouLyPlus toggle + all-sources-off state Replace the binary lyricsMode ('standard' | 'lyricsplus') with an independent youLyPlusEnabled flag so YouLyPlus and the standard sources are no longer mutually exclusive — turning one off no longer forces the other on. YouLyPlus (when on) is tried first with the enabled sources as fallback; off uses only the enabled sources. When YouLyPlus is off and no source is enabled, useLyrics fetches nothing (issue #810). Fresh installs ship with every source off; the rehydrate migration only restores the old on-by-default set for genuine upgrades, not new installs. * feat(lyrics): YouLyPlus toggle UI + queue 'no sources' hint Settings: single YouLyPlus toggle replacing the two mutually exclusive mode switches; the source list is always visible with a context hint (fallback vs primary). Queue lyric tab shows a hint when no source is active. en + de strings; other locales fall back to en. * docs(changelog): lyrics fully disablable (#855)	2026-05-22 21:06:04 +02:00
cucadmuh	70c2fdfbf9	Linux: session-native GDK/WebKit mitigations and in-page browse scroll (#731) ... * feat(linux): session GDK defaults, nvidia-quirk, optional x11-legacy wrap Ship PSYSONIC_ALLOW_NATIVE_GDK from Nix/AUR instead of pinning WEBKIT_DISABLE_* and GDK x11. Add flake psysonic-x11-legacy for the old wrap; alias gdk-session to psysonic. Startup uses webkit2gtk-nvidia-quirk and Wayland-aware compositing; refresh Help (a45) and nixos-install docs. * fix(linux): session GDK and nvidia-quirk only; drop wrapper env heuristics Remove PSYSONIC_ALLOW_NATIVE_GDK and devShell GDK/WEBKIT exports; stop synthesizing GDK/WebKit vars in main.rs. Update Nix/AUR wrappers, install docs, CHANGELOG, and help FAQ with practical user-facing workarounds. * fix(linux): X11-pinned GDK uses DMABUF quirk path, not Wayland explicit-sync When GDK_BACKEND is forced to x11 on a wayland user session, webkit2gtk-nvidia-quirk would still apply __NV_DISABLE_EXPLICIT_SYNC and gray out the webview. Map that case to WEBKIT_DISABLE_DMABUF_RENDERER like native X11. * fix(ui): stabilize WebKitGTK/Wayland hover paint for nav and media cards Sidebar nav links avoid transition:all and promote icons with translateZ(0). Artist rows and album/artist/song cards use compositing hints; card shadows and borders no longer interpolate so cover zoom can stay smooth without jitter. * fix(ui): isolate artist/album card text and cover paint on WebKitGTK Promote cover blocks with contain/paint and text stacks with translateZ(0); use artist-card-info on the artists grid for the same layout as other cards. * feat(artists): in-page overlay scroll and locked main viewport Move list/grid into an inner OverlayScrollArea, stop sticky toolbar from owning the route scroll, align the rail with the main panel edge, and skip the main-route overlay thumb when the viewport cannot scroll vertically. * feat(browse): extend in-page overlay scroll to more library routes Reuse the locked main viewport pattern from Artists for Albums, Composers, Lossless albums, and New releases; wire VirtualCardGrid and scroll chrome to the matching in-page viewport ids. * fix(linux): improve Wayland GPU compositing text clarity in WebKitGTK Use on-demand hardware acceleration on main and mini webviews when the session is Wayland and compositing stays on; gate subpixel body AA on the same conditions via new Tauri probes. Document PSYSONIC_SKIP_WAYLAND_FONT_TUNING for opt-out and changelog. * fix(rust): satisfy clippy needless_return in Linux webkit helpers * fix(linux): tune Wayland text rendering with HW policy env and CSS Allow PSYSONIC_WEBKIT_WAYLAND_HW_POLICY to select WebKit hardware acceleration policy (never/always vs default on-demand). Extend Wayland font CSS to #root with geometricPrecision and text-size-adjust on html. * feat(linux): Wayland text presets in settings, safe WebKit apply, CPU default Persist profile to app config; apply WebKit policy at startup/mini only to avoid WebKitGTK hangs on live toggles. UI + CSS preview stays live; default preset is sharp (CPU-friendly). * fix(linux): map Wayland sharp preset to OnDemand WebKit policy HardwareAccelerationPolicy::Never at startup broke main-viewport wheel scrolling on WebKitGTK+Wayland; sharp vs balanced remains a CSS AA path. Use PSYSONIC_WEBKIT_WAYLAND_HW_POLICY for a true Never policy. * fix(rust): gate Linux-only Wayland WebKit helpers for Windows builds Re-export startup helpers only under cfg(linux) and drop non-Linux stubs so Windows compiles without unused-import and dead-code warnings. * chore(release): CHANGELOG + credits for Linux session/WebKit work (PR #731) Consolidate scattered incremental changelog notes into two [1.47.0] entries with PR link; remove duplicate Linux blocks from [1.46.0] Fixed. Append settings credit line for cucadmuh.	2026-05-18 21:00:46 +03:00
Frank Stellmacher	606a150e01	feat(settings): clock format setting (Auto / 24h / 12h) (#742) ... * feat(settings): clock format setting (Auto / 24h / 12h) Reported on the Psysonic Discord — the Queue side panel's ETA label and the sleep-timer preview both render via `formatClockTime`, which just calls `toLocaleTimeString` and so follows the user's system locale. On en-US that means AM/PM, with no in-app way out. Add a tri-state **Clock Format** setting under **Settings → System → App Behavior**: * `auto` (default) — keep the existing locale-driven behaviour, so bestehende installs are unaffected on first launch. * `24h` — force 24-hour wall-clock output everywhere `formatClockTime` is used. * `12h` — force AM/PM output. Wired through `authStore` (`clockFormat`, `setClockFormat`), exposed via `CustomSelect` in `SystemTab`, and threaded into the two consumers (`QueueHeader`, `PlaybackDelayModal`) so they re-render on change. `formatClockTime` itself stays a pure helper — it accepts the setting as an optional second argument and maps it to `hour12`. Locale coverage: all nine bundled locales (en, de, es, fr, nl, nb, ru, zh, ro) get the four new settings strings. Pin tests added for the `setClockFormat` setter and the `hour12` mapping in `formatClockTime`. * docs(changelog): clock format setting + contributors (PR #742)	2026-05-17 01:26:40 +02:00
Frank Stellmacher	ccf4d5d8cb	feat(queue): persist queue header duration mode (#724) ... * feat(queue): persist header duration mode (#625) The queue header chip cycles total / remaining / ETA, but the choice lived in QueuePanel `useState` and reset to 'total' on every app launch. Move it into `authStore` (persisted under `psysonic-auth`) so the chosen mode survives restarts like other UI preferences. - `DurationMode` consolidated in `authStoreTypes` (re-exported from `queuePanelHelpers` so existing component imports stay valid). - New `queueDurationDisplayMode` field + `setQueueDurationDisplayMode` setter wired through `createUiAppearanceActions`, default `'total'`. - `computeAuthStoreRehydration` validates the persisted value against the three known modes (pattern matches the existing seekbarStyle block) — garbage, null, undefined, or a missing key map back to `'total'` so the chip never receives an unknown mode. - `QueuePanel` reads / writes via `useAuthStore` selectors instead of local `useState`. - Tests: trivial-setter coverage in `authStore.settings.test.ts` and a new `authStoreRehydrate.test.ts` covering corrupt, missing, and valid rehydration cases. Reuses kveld9's design from PR #625; not merged because the 1.46 refactor split locales and reshuffled queue-helper exports. Credited via Co-Authored-By trailer. Co-Authored-By: Kveld. <kveld912@proton.me> * docs(changelog): queue header duration mode persistence (#724) Adds the CHANGELOG entry + kveld9 credits line referencing the real PR numbers (no #TBD placeholder) — feedback.md §2.7+§2.8 workflow: commit docs as a second push onto the open PR. --------- Co-authored-by: Kveld. <kveld912@proton.me>	2026-05-15 19:14:06 +02:00
Frank Stellmacher	651a3f276a	feat(settings): global Advanced Mode toggle + playlist page layout (#556) (#720) ... Adds a per-element visibility toggle for the playlist detail page (Add Songs, Import CSV, Download ZIP, Cache Offline, Suggestions) and reworks the way uncommon options are surfaced: instead of a per-tab collapsible group, a global "Advanced" toggle in the Settings header reveals all `advanced` sub-sections across every tab and marks each one with a small badge. Sets the pattern up so any future advanced option lives in its natural tab, gated by the same switch. - New `advancedSettingsEnabled` boolean on `authStore` (UiAppearance slice, persisted with the rest of the store). - `SettingsSubSection` gains an `advanced?: boolean` prop. Hidden when the toggle is off; renders an "Advanced" pill in the header when on. - Settings header gets a Toggle-Switch next to the search lupe. - `PersonalisationTab` flattens — Sidebar + Home stay always visible; Artist sections, Queue Toolbar, and the new Playlist layout get `advanced` and disappear by default. `PersonalisationAdvancedGroup` component + CSS removed. - New `playlistLayoutStore` (Zustand + persist, items[{id,visible}] + rehydrate sanitize) following the queueToolbarStore pattern. - `PlaylistHero` and `PlaylistSuggestions` gate the four toolbar buttons and the suggestions rail on the store directly. - One-time migration in MainApp on mount: if the user had opened the old per-tab Advanced group (`psysonic_personalisation_advanced_open === 'true'`) OR already customised any of the three sub-sections, Advanced Mode auto-enables on first launch. Idempotent via a localStorage flag; legacy key removed afterwards. - New i18n keys `settings.advancedMode`, `settings.advancedModeTooltip`, `settings.advancedBadge`, `settings.playlistLayout*` in all 9 locales. Reuses kveld9's design from PR #556; not merged because the locale split landed afterwards. Credited under the existing kveld9 entry in settingsCredits.ts. Co-authored-by: Kveld. <kveld912@proton.me>	2026-05-15 15:55:11 +02:00
Maxim Isaev	0f5ece6d03	feat(settings): library card grid max columns in Appearance (4–12, default 6) ... Persist libraryGridMaxColumns, wire useCardGridMetrics and card grid layout, add i18n and settings search index; document performance hint in copy.	2026-05-15 02:19:20 +03:00
Frank Stellmacher	acdb0ae795	refactor(auth): E.47 — extract onRehydrateStorage migration block (#612) ... The persist middleware's `onRehydrateStorage` callback was ~100 LOC of legacy-shape migrations: hot-cache/preload mutual-exclusion reset, lyricsServerFirst+enableNeteaselyrics → lyricsSources one-time migration, Linux smooth-scroll one-shot, seekbar `'waveform'` → `'truewave'` rename, animationMode/reducedAnimations cruft strip, loudnessPreIsRefV1 reference recalibration, enableAppleMusicCoversDiscord → discordCoverSource enum migration, plus the sanitizers for mixMinRating / randomMixSize / skipStarManualSkipCountsByKey. Moved into `computeAuthStoreRehydration(state) → Partial<AuthState>` in `authStoreRehydrate.ts`; the store's callback is now a four-line wrapper. Pure code-move — same migration logic, same call order. authStore.ts: 270 → 158 LOC (−112). Total Phase-E-auth journey: 889 → 158 LOC (−82%). All non-trivial content is now out of the authStore body; what remains is state-init, 13 factory spreads, 2 derived getters, persist config, and the thin onRehydrate wrapper.	2026-05-12 23:50:48 +02:00
Frank Stellmacher	2c0aef9538	refactor(auth): E.46 — extract logic-bearing factories (#611) ... Three factories for the actions that carry real logic (not just `set({ field: v })` pass-through): - `createSkipStarActions` — skip-to-1★ counter with threshold check and per-`<activeServerId><trackId>` storage key. Disabling the feature wipes the counter map so a re-enable doesn't resume from stale partial counts. Crossing the threshold deletes the key so the next session starts fresh. - `createMusicLibraryActions` — `setMusicFolders` falls back to `'all'` when the persisted filter points at a folder the server no longer reports; `setMusicLibraryFilter` bumps `musicLibraryFilterVersion` so subscribed pages refetch. - `createPerServerCapabilityActions` — `setEntityRatingSupport`, `setAudiomuseNavidromeEnabled`, `setSubsonicServerIdentity`, `setInstantMixProbe`, `setAudiomuseNavidromeIssue`. Each branch knows which neighbouring per-server maps to wipe when the input invalidates them (identity not AudioMuse-eligible / probe empty / audiomuse disabled). Pure code-move. authStore.ts: 384 → 270 LOC (−114). All trivial-setter and logic-bearing action bodies are now out of the store body; only the persist config + `onRehydrateStorage` migration block remains as a non-factory chunk (target for E.47).	2026-05-12 23:44:17 +02:00
Frank Stellmacher	fe6acdaa4c	refactor(auth): E.45 — extract seven settings factories (#610) ... Seven small domain-eng factories peel ~53 trivial setters out of the authStore body: - `createCacheStorageActions` — disk caches (max cache MB, download folder, offline download dir, hot-cache enable/MB/debounce/dir). - `createDiscordSettingsActions` — rich presence, cover source, Bandsintown toggle, three template strings. - `createUiAppearanceActions` — visual chrome: tray, titlebar, sidebar toggles, fullscreen-lyrics rendering, changelog banner, seekbar style, queue collapse, kinetic scroll, mini-player preload. - `createLyricsSettingsActions` — lyrics fetch pipeline (server-first, netease enablement, source order, mode, static-only). - `createTrackPreviewActions` — preview enable + per-location + start ratio (clamped 0…0.9) + duration (clamped 5…120s). - `createDiscoveryActions` — mix min-rating filters (clamped 0…3), random-mix size (snapped to allowed bucket), lucky-mix visibility, random-nav mode, infinite-queue, preserve-play-next-order. - `createPlumbingSettingsActions` — logging mode, getNowPlaying toggle, preload mode + custom seconds, audiobook exclusion, genre blacklist. Pure code-move. authStore.ts: 428 → 384 LOC (−44).	2026-05-12 23:38:09 +02:00
Frank Stellmacher	b8ddb09b78	refactor(auth): E.44 — extract server-profile + lastfm + audio-settings factories (#609) ... Three action-factories peel ~25 setters out of the authStore body, following the playerStore action-factory pattern from Phase E: - `createServerProfileActions` — `addServer`, `updateServer`, `removeServer` (the non-trivial one — drops every per-server map entry for the removed id), `setServers`, `setActiveServer`, `setLoggedIn`, `setConnecting`, `setConnectionError`, `logout`. - `createAuthLastfmActions` — credentials + session connect/disconnect + error flag + master scrobbling toggle. Network calls (love / scrobble) stay in the playerStore-side `lastfmActions.ts`. - `createAudioSettingsActions` — replay-gain / normalization / loudness mode toggles (each calls `usePlayerStore.getState() .updateReplayGainForCurrentTrack()` so a running track catches up), plus crossfade / gapless / hi-res / audio-output (no engine callback needed). Pure code-move; no behaviour change. authStore.ts: 518 → 428 LOC (−90).	2026-05-12 23:30:28 +02:00
Frank Stellmacher	4d564e5016	refactor(auth): E.43 — extract authStore types + defaults + helpers (#608) ... First slice of the authStore split. Pure code-move: no behaviour change. - `authStoreTypes.ts` — `ServerProfile`, `AuthState`, plus all union types (`SeekbarStyle`, `LoggingMode`, `NormalizationEngine`, `DiscordCoverSource`, `LoudnessLufsPreset`, `LyricsSourceId`, `LyricsSourceConfig`, `TrackPreviewLocation`, `TrackPreviewLocations`). - `authStoreDefaults.ts` — `LOUDNESS_LUFS_PRESETS`, `DEFAULT_LOUDNESS_PRE_ANALYSIS_ATTENUATION_DB`, `TRACK_PREVIEW_LOCATIONS`, `DEFAULT_TRACK_PREVIEW_LOCATIONS`, `DEFAULT_LYRICS_SOURCES`, `MIX_MIN_RATING_FILTER_MAX_STARS`, `RANDOM_MIX_SIZE_OPTIONS`. - `authStoreHelpers.ts` — `generateId`, `sanitizeLoudnessLufsPreset`, `sanitizeLoudnessPreAnalysisFromStorage`, `clampMixFilterMinStars`, `clampRandomMixSize`, `clampSkipStarThreshold`, `skipStarCountStorageKey`, `sanitizeSkipStarCounts`. 12 external call sites migrated to direct imports from the new modules (no re-export shims left in authStore.ts — applies the [feedback_prevent_god_modules] rule 5: avoid re-export debt). authStore.ts: 889 → 518 LOC (−371).	2026-05-12 23:22:28 +02:00
Frank Stellmacher	ddb1f29af9	refactor(settings): remove redundant Animations 3-state setting (#495) ... * refactor(settings): remove redundant Animations 3-state setting under Seekbar Style The `animationMode` setting (Full / Reduced / Static) duplicated work the perf-flag system and OS-level reduced-motion preference already covered: - `perfFlags.disableMarqueeScroll` already kills marquee scrolling on demand, replacing what `static` mode used to gate. - The `data-perf-disable-animations` html-level switch already strips every `*` animation, replacing what `static` mode used to do globally. - `@media (prefers-reduced-motion: reduce)` honours the OS setting for every user that asked for it via system preferences. - The 30 fps cap that `reduced` mode applied to the seekbar wave was better served by per-feature perf toggles cucadmuh added later. Removed: - `AnimationMode` type, `animationMode` field + setter from auth store. - Settings UI block (3 buttons + hint text) under Appearance > Seekbar Style. - `animationMode === 'static'` short-circuit in WaveformSeek's rAF effect; `isReduced` skip-every-other-frame logic; `static`-checks in `drawNow` / `needsDirectDraw`. - `animationMode !== 'static'` guard and `data-anim-mode` attribute in MarqueeText. - `[data-anim-mode="static"]` and `[data-anim-mode="reduced"]` rules in layout.css. - Seven i18n keys (animationMode + 6 variants) across all eight locales. Migration: the persist layer strips `animationMode` (and the legacy `reducedAnimations` boolean predecessor) so anyone who had `'reduced'` or `'static'` selected silently lands on the former `'full'` path on first launch after upgrade. No user-facing prompt — the missing setting just stops existing. cucadmuh's PR #472 (FPS overlay), #476 (preview-freeze main seekbar, sleep-recovery hooks, card-hover removal) and #486 (interpolation anchor reset on resume) are all preserved untouched — they live in separate effects / files and were not driven by `animationMode`. * docs(changelog): add Removed section for animationMode setting (PR #495) * docs(changelog): refine animationMode removal rationale (drop prefers-reduced-motion overstatement)	2026-05-07 12:53:19 +02:00
Frank Stellmacher	0fab2849e5	feat(queue): preserve Play Next order toggle (#464) ... * feat(queue): add preservePlayNextOrder setting + playNext store action - New Track.playNextAdded flag (analogous to autoAdded / radioAdded). Stale flags behind queueIndex are harmless — only forward streak scan. - New playerStore action playNext(tracks): tags incoming tracks and delegates to enqueueAt for unified undo + server sync. - New authStore boolean preservePlayNextOrder (default false). When on, playNext appends behind the existing Play-Next streak (Spotify-style) instead of inserting directly after the current track. * refactor(context-menu): centralise Play Next; add Settings toggle + i18n - Replace 3 inline splice/enqueueAt call sites in ContextMenu with the new playNext action. Side-benefit: the single-song path now goes through enqueueAt and gets undo + queue sync (previously missing). - Settings → Audio → Playback: new toggle below Gapless. - 8 locales: preservePlayNextOrder + preservePlayNextOrderDesc. * docs(contributors): credit + changelog entry for #464	2026-05-05 22:33:15 +02:00
Sayykii	e1f2cb4c37	feat(discord): add server cover art source (#462) ... * feat(discord): add server cover art source The old Apple Music toggle is replaced with a radio selector which let's you choose between Apple Music, Server and no image. It's important to note that the server needs to be publicly accessible. Translations have been added for all locales * feat(discord): toggle UI for cover source and tightened defaults - Replace cover-source radio buttons with three indented sub-toggles (none / server / apple) under Discord Rich Presence; mutex via setDiscordCoverSource — turning one on flips the others off. - Default discordCoverSource is now 'server' for fresh installs (opt-in friendly: own server, no third-party data leak). Existing users keep their state via the legacy bool migration. - Tighten template defaults: details {artist}, state {title}, largeText unchanged. Existing users keep their persisted values. * docs(contributors): credit Sayykii + changelog entry for #462 --------- Co-authored-by: Psychotoxical <171614930+Psychotoxical@users.noreply.github.com>	2026-05-05 21:30:23 +02:00
Frank Stellmacher	3b4d54431b	feat(random-mix): playlist size selector + filter panel layout cleanup (#445) ... * feat(random-mix): playlist size selector + filter panel layout cleanup Adds a 5-button playlist-size picker (50/75/100/125/150) at the top of the Random Mix filter panel, persisted via authStore. Clicking a size immediately reruns the current mix (genre-scoped or All Songs) at the new size — no second click on Remix needed. Filter panel layout cleaned up: - Two sub-sections "MIX SETTINGS" and "EXCLUSIONS" with a divider between them so the panel reads cleanly with the new size row. - Larger panel-level headers (FILTERS / GENRE MIX) so the hierarchy panel-title > sub-section is visually unambiguous. - Italic muted note under MIX SETTINGS calling out that large mix sizes may return fewer unique tracks if the server's random pool runs short — sets honest expectations instead of users wondering why a 150 request returned ~126. fetchRandomMixSongsUntilFull now scales batch size, max-batch ceiling and dup-streak budget with target size; when no Settings-level mix filter is active, the first call asks for the full target so a 150 mix can finish in a single round-trip on most libraries. The loop falls through to top up with deduped follow-up calls if the server returns fewer than requested. * docs(changelog): add #445 Random Mix playlist size selector entry * chore(credits): add #445 to Psychotoxical contributions	2026-05-03 19:57:08 +02:00
Frank Stellmacher	98ff73d17a	feat(perf): 3-state animation mode (Full / Reduced / Static) (#441) ... * feat(perf): 3-state animation mode (Full / Reduced / Static) Replaces the boolean `reducedAnimations` toggle with a three-way `animationMode` setting, suggested by Viktor Petrovich after the Windows audio fix (PR #426) shipped and confirmed a measurable GPU drop: - `full` (default): native frame rate, marquee scrolls normally - `reduced`: 30 fps cap on the animated seekbar wave; player marquee runs at half speed - `static`: rAF loop disabled; the seekbar repaints from the ~2 Hz audio:progress heartbeat. Player title/artist truncate with ellipsis instead of scrolling. Migration in `onRehydrateStorage` maps legacy `reducedAnimations: true` to `'reduced'`, anything else to `'full'`. Static is opt-in only. Settings UI follows the ReplayGain Auto/Track/Album pattern with a contextual hint that explains what each mode does. i18n: 5 new keys across 8 locales, 2 legacy keys removed. * docs(changelog): add #441 3-state animation mode entry * chore(credits): add #441 to Psychotoxical contributions	2026-05-03 14:12:27 +02:00
Frank Stellmacher	fca8fc5318	fix(seekbar): blank canvas after update from legacy build (#432) ... After PR #316 split the 'waveform' seekbar style into 'truewave' / 'pseudowave', users who carried any other unrecognised persisted value (legacy variants, undefined, tampered strings) ended up with a blank seekbar — the rehydrate migration matched only the literal 'waveform' string, and the drawSeekbar dispatcher had no default branch, so an unknown style drew nothing. Two-layer fix: * authStore migration now treats *any* value not in the current SeekbarStyle union as legacy and resets it to 'truewave'. * drawSeekbar gains a default case that falls back to the truewave renderer, so even if a future style mismatch slips through the store-level guard the user still sees a usable seekbar. Visible to affected users on next app start (rehydrate runs once per session). Clicking a style in Settings has always worked around the issue; this fix removes that workaround.	2026-05-02 22:50:22 +02:00
Frank Stellmacher	e44e6dcdf4	fix: restore audio refactor + features lost in #419 squash-merge (#429) ... The squash-merge of PR #419 was performed against an outdated PR base that predated several main-side refactors and features. The resulting squash inadvertently re-introduced files that had already been removed (`src-tauri/src/audio.rs` monolith, `app-icon.png`) and reverted main's content for ~20 files (`src-tauri/src/lib.rs` decompose, `src/App.tsx` animation-pause, `src/components/AlbumRow.tsx` headerExtra, etc). This commit: * Restores all collateral-damage files to their pre-#419 main state (5662dafe), including the audio module split, lib decompose, Cargo.toml `windows` dep, animation-pause-on-blur logic, and `reducedAnimations` toggle plumbing in WaveformSeek/Settings. * Keeps the genuine #419 work intact: tri-state duration toggle, position counter, persistent Now Playing collapse, animated EQ indicator (in QueuePanel.tsx, 8 locales, authStore, components.css). * Merges authStore.ts so both `reducedAnimations` (from #426) and `queueNowPlayingCollapsed` (from #419) coexist. * Adds the `.eq-bars.paused` CSS rule manually since components.css needed a 5662dafe base + the single #419 addition. * Fixes a latent type error in OverlayScrollArea.tsx (`useRef<T>(null)` is `RefObject<T>` / read-only under current `@types/react`; widened to `useRef<T | null>(null)` so the existing `wrapRef.current = el` assignment compiles). Verified locally with `cargo check` and `npm run build` — both green.	2026-05-02 22:01:51 +02:00
Kveld.	18b4a982ef	feat: queue-ux-improvements (#419) ... * feat(queue): add ETA display, equalizer indicator and collapsible now playing * deleted endsAt and showDuration strings, changed eta update to 30s * feat(queue): ETA tooltip, persistent Now Playing collapse, EQ bar pause, remove redundant Play icon * feat(queue): fold ETA into existing total/remaining toggle as third mode The standalone ETA span next to the track counter is removed; instead the clickable duration label in the queue header now rotates through three modes per click: total → remaining → eta → total. Counter (N/M) stays where it was. ETA mode keeps the live-feel treatment from the original PR (accent colour while playing, muted at 50% opacity when paused). The other two modes use plain accent. i18n: queue.etaTooltip removed (no longer a separate descriptive label), queue.showEta added as the action tooltip ('Show estimated end time') in all 8 locales — matches the showRemaining / showTotal pattern. * docs(changelog): add #419 queue UX improvements entry Adds the [1.45.0] / Added entry for this PR's queue panel refinements (position counter, tri-state duration toggle including ETA, collapsible Now Playing section, animated EQ indicator). --------- Co-authored-by: Psychotoxical <171614930+Psychotoxical@users.noreply.github.com>	2026-05-02 21:45:55 +02:00
Frank Stellmacher	2e9618cf54	fix(audio): Windows playback stutter under GPU load (#334) (#426) ... * fix(audio): promote WASAPI render thread to MMCSS Pro Audio on Windows Wraps the outermost audio source in a `PriorityBoostSource` that calls `AvSetMmThreadCharacteristicsW("Pro Audio")` on its first sample. The cpal output-stream callback runs `Source::next` on the WASAPI render thread, which is otherwise normal-priority and gets preempted under WebView2 / DWM / GPU pressure — producing the audible click/stutter reported in issue #334. No-op on Linux/macOS (PipeWire/rtkit and CoreAudio promote their audio threads externally). * fix(build): repair Windows compile after audio split + lib decompose Two pre-existing build breakers on Windows that surfaced after the `use super::*;` cleanup (9cc74a7) and the lib-decompose refactor (cfeec22): - `audio/device_watcher.rs` lost the `output_enumeration_includes_pinned` import. Add it cfg-gated to `not(target_os = "linux")` since it's only called inside the non-Linux pinned-device fallback path. - `lib_commands/sync/tray.rs::is_tiling_wm()` is `#[cfg(target_os = "linux")]`, but its Tauri command wrapper `is_tiling_wm_cmd()` is unconditional. Add a `#[cfg(not(target_os = "linux"))]` stub returning `false`. No behavior change on Linux. Restores `cargo build` on Windows + macOS. * perf(ui): pause cosmetic animations when window loses OS focus Companion to the WASAPI MMCSS fix in this branch — issue #334 reported audible audio stutter on low-end laptops, partly traced to WebView2 still compositing CSS animations + waveform canvas at full rate while the user has alt-tabbed into another app. Existing `data-app-hidden` / `data-psy-native-hidden` flags pause animations only when the window is fully hidden (minimized or behind a tray). When the window is visible-but-unfocused — the common "music in the background while I work" case — every infinite keyframe + 60fps rAF loop keeps running. Add a parallel `data-app-blurred` flag driven by `window.focus`/ `window.blur`, plus matching `__psyBlurred` on the global window object for imperative checks. The CSS rule that pauses every `animation-play-state` on hidden gets a third selector for blurred. WaveformSeek's two 60fps rAF loops (animated styles + settings demo) extend their existing `document.hidden || __psyHidden` short-circuit to also include the new blurred flag, falling back to the same 400ms polling path that already exists for hidden. Verified visually on the dashboard: alt-tab → `<html data-app-blurred="true">`, mesh blobs in the fullscreen player + marquee + waveform 60fps loop all pause. Click back into the window → blob/marquee/waveform resume immediately. Cross-platform: focus/blur events fire reliably on all targets, so the optimization applies to Windows, Linux (incl. WebKitGTK with software compositing where the savings are largest), and macOS. * chore: remove stale app-icon.png from repo root * perf(ui): add 'Reduce animations' toggle that caps animated seekbar styles to 30 fps Off by default. When on, animated seekbar styles (pulsewave, particletrail, liquidfill, retrotape) skip every other rAF and advance the animation timer by a doubled delta, so wave speed is unchanged while draws are halved. Aimed at low-end Windows GPUs where the 60 fps shadow-blur loop drives ~40 % WebView2 GPU usage even when focused. Toggle lives directly under the seekbar style picker in Settings → Appearance. i18n in all 8 supported languages.	2026-05-02 21:10:32 +02:00
Frank Stellmacher	a14dba8167	feat(audio): rust track preview engine + inline play/preview buttons (#392) ... * feat(audio): rust preview engine with secondary sink Adds a parallel rodio Sink on the existing OutputStream for 30s mid-track previews. Two new Tauri commands (audio_preview_play, audio_preview_stop) plus three events (audio:preview-start / -progress / -end). The main sink is paused with Sink::pause() and auto-resumed on preview end iff it was playing beforehand. * feat(playlists): migrate suggestion preview to rust audio engine Replaces the HTML5 <audio> path with the new rust preview engine. previewStore mirrors the engine's start/progress/end events so any tracklist row can render preview UI from a single source of truth. Spacebar redirects to stopPreview while a preview plays, hardware mediakeys are silently dropped (Q5), and tray clicks cancel the preview before forwarding the original action. * feat(albums): inline play + preview buttons in tracklist rows Track number stays static on hover instead of swapping to a play icon — the dedicated Play and Preview buttons in the title cell take over click-to-play and click-to-preview. Active+playing rows keep the eq-bars (also on hover), active+paused rows fall back to the static accent-coloured number. Pilot for the wider rollout to other tracklists. * feat(tracklists): roll out inline play + preview buttons Mirrors the AlbumTrackList pilot across the remaining track-row based lists: PlaylistDetail main tracks, Favorites, ArtistDetail top tracks, RandomMix (both genre-mix and filtered-songs lists). Track number stays static, the dedicated Play + Preview buttons in the title cell take over click-to-play and click-to-preview. * feat(settings): track preview toggle + configurable position and duration Adds an opt-out switch and two sliders to Settings → Audio: start position (0-90 % of track length, default 33 %) and preview duration (5-60 s, default 30 s). The progress-ring animation follows the duration via a CSS variable so the visual matches the engine's auto-stop. Disabling the feature hides every inline preview button via a single root-level data attribute, no per-row conditional rendering required. i18n keys added in all 8 locales. * fix(audio): cancel preview when main playback (re)starts audio_play, audio_play_radio, audio_resume and audio_stop did not know about the parallel preview sink, so clicking Play on a track that was currently being previewed left the preview running on top of the freshly started main playback. New helper clears the resume flag, bumps the preview generation, drops the sink and emits an 'interrupted' end event before any of those commands touches the main sink. * feat(settings): per-location track preview toggles Splits the single trackPreviewsEnabled toggle into a master + 6 per-location sub-toggles (suggestions, albums, playlists, favorites, artist, randomMix). Master remains the kill switch; sub-toggles are only honoured when master is on. Each tracklist container is marked with `data-preview-loc="<id>"` and hidden via scoped CSS when the matching root attribute is "off". startPreview now takes a location argument so the store can guard logic too. i18n added in all 8 locales. * fix(contextmenu): use ChevronsRight for Play Next to distinguish from preview	2026-05-01 09:11:28 +02:00
cucadmuh	87373edb17	fix(loudness): target sync, effective pre-analysis trim, and queue/settings copy (#333) ... * fix(loudness): target sync, -14 pre-analysis ref, queue UI, and reseed - Front: coalesce loudness refresh by target LUFS; replay-gain IPC dedupe keys include norm target and effective pre-attenuation so TGT changes apply. - Rust: placeholder gain before integrated LUFS uses pivot at -14 LUFS; UI gain from effective trim; reseed loudness after delete when waveform cache would skip. - Pre-analysis: store attenuation relative to -14 LUFS; engine and UI use an offset for other targets; migrate legacy absolute values on rehydrate. - Queue/Settings: Loudness/TGT labels vs value buttons; styles; i18n for help. * fix(i18n): simplify loudness pre-analysis helper copy Remove reference-target wording from loudness pre-analysis helper text and keep only the effective adjustment shown for the current LUFS target in all locales.	2026-04-27 02:54:58 +03:00
Psychotoxical	ed76090a54	fix(seekbar): split waveform style into truewave (analyzed) + pseudowave (deterministic) ... The waveform-loudness-cache merge replaced the existing deterministic per-track-ID waveform with a bins-based one driven by the analysis cache. The bins-based variant is the better default but the old deterministic look is still valuable when no analysis is available (brand-new track, cache-miss, etc.) and several users prefer it. Split into two explicit options in the seekbar style picker: - 'truewave' (default, replaces old 'waveform') — bins from the analysis cache, with morph-on-arrival animation and flat-line fallback while empty. - 'pseudowave' — pseudo-random heights derived deterministically from the track ID. No analysis dependency, no morph, instant render. Existing persisted seekbarStyle: 'waveform' is migrated to 'truewave' in onRehydrateStorage so users keep the visual they have today. The useEffect that builds heightsRef now lists seekbarStyle in its deps so switching between the two is live. i18n labels added in all 8 locales. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-26 02:45:51 +02:00
Maxim Isaev	4b60495e38	feat(playback): loudness bind rules, analysis seeding, and normalization UI ... Resolve integrated loudness from SQLite only at decode bind; keep pre-trim until a row exists, then allow provisional gain from live updates. Pass DB-stable hints from the web app into play and gapless preload. Default pre-measurement attenuation -4.5 dB with an icon reset in Settings; drop redundant normalization copy and shorten pre-trim descriptions. analysis_cache seed_from_bytes returns an outcome and skips redundant waveform work on cache hits; wire callers and related frontend/backend glue.	2026-04-26 02:29:54 +03:00
Psychotoxical	453151f1fc	Merge branch 'main' into feat/waveform-loudness-cache ... # Conflicts: # src/store/playerStore.ts	2026-04-25 21:47:48 +02:00
Maxim Isaev	e009fd1823	fix(settings): make normalization modes exclusive and refine LUFS UI ... Replace the mixed ReplayGain/Loudness controls with a single exclusive mode selector, hide RG-specific controls when LUFS is active, and align the queue tech badge behavior between RG and LUFS. Also update LUFS targets to -10..-16 ordering and default loudness target to -12.	2026-04-25 22:36:55 +03:00
Maxim Isaev	86704473ed	fix(audio): stabilize loudness normalization and streaming startup behavior ... Improve normalization consistency by separating cache refresh for non-playing tracks, hardening track-id cache lookups, and keeping UI gain state aligned with actual playback. Also reduce startup stalls by preferring non-seekable streaming when format hints are missing and by tuning ALSA/analysis paths to avoid underrun-prone churn.	2026-04-25 22:09:38 +03:00
Psychotoxical	861d4c9616	chore(orbit): rename "Psy Orbit" → "Orbit" in user-visible strings ... Topbar trigger button + start-modal hero brand both drop the "Psy" prefix. Help-section copy and the settings toggle that references the button by name are renamed in lockstep so the UI stays consistent — otherwise the settings row would still read "Show Psy Orbit in the header" while the actual button reads "Orbit". 8 locales updated. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-25 01:51:38 +02:00
Psychotoxical	7378bdf820	chore(orbit): toggle to hide the Psy Orbit topbar trigger in Settings ... Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-24 19:53:59 +02:00
Maxim Isaev	ab5c8e0b48	feat(lucky-mix): instant mix from your preferences ... Lucky Mix targets ~50 tracks in one run: pick seeds from your most-played artists/albums and 4+ rated songs, add similar tracks, then fill the mix with random library picks, skipping anything you rated 1–2. On start it trims the old “upcoming” tail so the queue does not show stale next tracks, starts playback on the first viable seed, routes to Now Playing, and can emit structured steps to the backend debug log.	2026-04-23 18:42:52 +03:00
Frank Stellmacher	21d00889aa	fix(navidrome-admin): resilient admin API calls + UI polish (#260) ... * fix(navidrome-admin): force HTTP/1.1 + User-Agent + no idle pool for /auth and /api calls Replaces plain reqwest::Client::new() in all nd_* Tauri commands (navidrome_login, nd_list_users, nd_create_user, nd_update_user, nd_delete_user, nd_list_libraries, nd_set_user_libraries) with a shared nd_http_client() helper that: - sets a real User-Agent (Psysonic/<version> (Tauri)) - pins HTTP/1.1 (avoids HTTP/2 ALPN that some reverse proxies abort on) - disables the idle-connection pool so a second call doesn't reuse a TCP connection that the server or proxy has already half-closed (was producing intermittent "tls handshake eof" on external servers). Adds nd_err() to flatten the reqwest error source chain into the returned String, so the frontend surfaces the real cause (connection refused, tls handshake eof, etc.) instead of reqwest's opaque "error sending request for url (…)" wrapper. * fix(navidrome-admin): retry + graceful error + server row polish Rust (src-tauri/src/lib.rs): - nd_http_client: HTTP/1.1, TLS 1.2 only, no idle pool — browser-parity for /auth and /api so strict reverse proxies that abort reqwest's default HTTP/2+TLS-1.3 handshake mid-flight get through. - nd_retry: one retry after 500ms on connect/timeout errors only (ECONNRESET, TLS handshake EOF). Aggressive retries could push the nginx upstream probe into offline state; this is the minimal useful amount. - nd_err: flatten the reqwest error source chain so the UI surfaces the real cause instead of reqwest's opaque wrapper. User management UI: - Sequential load (users, then libraries) instead of parallel, to avoid racing two TLS connections on a single nginx upstream slot. - Friendlier failure state with a one-click Retry button that re-runs load(). Concrete Rust error is kept as muted sub-line. - User row layout: Magic-String button sits consistently next to last-seen + delete for every user, regardless of admin status or library-name length. No more mid-row jitter. Servers tab: - "Use" button no longer redirects to Home; stays on the Servers tab so the active-badge migration is visible. - Drag-and-drop reorder via grip handle (psyDnD), backed by a new setServers() action on authStore. - Active server row now has an accent-tinted background on top of the border — harder to miss. New i18n keys (userMgmtLoadFriendly, userMgmtRetry) added to all 8 locales. --------- Co-authored-by: Psychotoxical <dev@psysonic.app>	2026-04-22 03:13:09 +02:00
Frank Stellmacher	06140a490b	feat(queue): add Now-Playing Info tab with artist bio, song credits and Bandsintown tour dates (#244) ... * feat(queue): add Now-Playing Info tab with artist bio, song credits and Bandsintown tour dates A third tab in the right-side queue panel surfaces context for the currently playing track: - Artist card: image + biography from Subsonic getArtistInfo (Last.fm "Read more on Last.fm" anchor stripped), with read-more toggle that only appears when the bio actually overflows the 4-line clamp. - Song info: contributor credits from OpenSubsonic contributors[] rendered stacked (name prominent, role muted). Section is hidden entirely on servers without contributor support, and rows that just re-state the main artist under role "artist" are filtered out. - On tour: optional Bandsintown integration (opt-in, off by default). HTTP fetch + JSON parsing happen entirely on the Rust side; the frontend wrapper deduplicates concurrent calls and caches results in RAM for the session. Limited to 5 events with a "Show N more" toggle. When the toggle is off, the section becomes an in-place opt-in card with a privacy info-tooltip explaining what data is sent — same tooltip is also exposed on the matching toggle in Settings. Caching: artist info and song detail are memoised by stable IDs across component remounts, so jumping between tracks of the same album/artist does not refire the network calls. Implementation notes: - Bandsintown app_id "js_app_id" — arbitrary strings (e.g. "psysonic") now return HTTP 403 from rest.bandsintown.com; js_app_id is the ID Bandsintown's own embeddable widget uses and is broadly accepted. - Tour items use negative left/right margins so the date badge stays visually aligned with the section title while the hover background extends slightly past the section edges. - New i18n namespace nowPlayingInfo across all 8 locales (en, de, fr, nl, zh, nb, ru, es) including pluralised "Show N more" forms. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(now-playing-info): switch nested flex-columns to block layout to stop content-dependent drift Repeated reports of the Tour and Song-info sections rendering at inconsistent x-positions (sometimes left of the section title, sometimes centred, sometimes correctly aligned) — varying by artist, sidebar width, and even whether "Show more" was clicked. Root cause: nested flex-direction: column containers (.np-info → .np-info-section → .np-info-tour / .np-info-credits) where the cross-axis (horizontal) sizing on WebKitGTK occasionally inherits the intrinsic min-content of the longest child. With one "Naherholungsgebiet/Freizeitgelände Lago Alfredo"-style venue name that overflows the sidebar, the parent ul gets pushed past 100% width and the entire layout drifts. min-width: 0 on every level didn't help because cross-axis stretch in flex-column ignores it for content-driven overflow. Fix: collapse all the section/list containers to display: block. Block layout is content-agnostic — children always render at 100% parent width, left-aligned, deterministically. Spacing between siblings now uses the lobotomy selector (`> * + * { margin-top }`). Only the tour item itself stays flex (badge ↔ meta horizontal layout), and that one still has overflow: hidden + flex: 1 1 0 + min-width: 0 on the meta column to truncate venue/place text with ellipsis. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Psychotoxical <dev@psysonic.app> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-04-21 19:13:18 +02:00