itlxrd/Psychotoxical-psysonic
1
0
Fork 0
mirror of https://github.com/Psychotoxical/psysonic.git synced 2026-07-21 23:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(login): clarify that https:// URLs are accepted in server URL field (#171)

Browse Source 
https:// was already supported by the code (startsWith('http') check) but
the placeholder text only showed bare host:port examples, giving no hint
that a full URL with protocol is valid.

- Updated serverUrlPlaceholder in login namespace (all 8 locales) to show
  https://music.example.com as the domain example
- Added settings.serverUrlPlaceholder i18n key (all 8 locales) and wired it
  into AddServerForm — previously the placeholder was a hardcoded English string

Closes #171

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Psychotoxical
2026-04-13 17:59:19 +02:00
parent dba89cc4e4
commit 9b22327bb0
9 changed files with 17 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/locales/de.ts
+2 -1
View File
@@ -313,7 +313,7 @@ export const deTranslation = {
serverName: 'Server-Name (optional)',
serverNamePlaceholder: 'Mein Navidrome',
serverUrl: 'Server-URL',
serverUrlPlaceholder: '192.168.1.100:4533 oder music.example.com',
serverUrlPlaceholder: '192.168.1.100:4533 oder https://music.example.com',
username: 'Benutzername',
usernamePlaceholder: 'admin',
password: 'Passwort',
@@ -414,6 +414,7 @@ export const deTranslation = {
servers: 'Server',
serverName: 'Server-Name',
serverUrl: 'Server-URL',
serverUrlPlaceholder: '192.168.1.100:4533 oder https://music.example.com',
serverUsername: 'Benutzername',
serverPassword: 'Passwort',
addServer: 'Server hinzufügen',
src/locales/en.ts
+2 -1
View File
@@ -314,7 +314,7 @@ export const enTranslation = {
serverName: 'Server Name (optional)',
serverNamePlaceholder: 'My Navidrome',
serverUrl: 'Server URL',
serverUrlPlaceholder: '192.168.1.100:4533 or music.example.com',
serverUrlPlaceholder: '192.168.1.100:4533 or https://music.example.com',
username: 'Username',
usernamePlaceholder: 'admin',
password: 'Password',
@@ -416,6 +416,7 @@ export const enTranslation = {
servers: 'Servers',
serverName: 'Server Name',
serverUrl: 'Server URL',
serverUrlPlaceholder: '192.168.1.100:4533 or https://music.example.com',
serverUsername: 'Username',
serverPassword: 'Password',
addServer: 'Add Server',
src/locales/es.ts
+2 -1
View File
@@ -315,7 +315,7 @@ export const esTranslation = {
serverName: 'Nombre del Servidor (opcional)',
serverNamePlaceholder: 'Mi Navidrome',
serverUrl: 'URL del Servidor',
serverUrlPlaceholder: '192.168.1.100:4533 o music.example.com',
serverUrlPlaceholder: '192.168.1.100:4533 o https://music.example.com',
username: 'Usuario',
usernamePlaceholder: 'admin',
password: 'Contraseña',
@@ -417,6 +417,7 @@ export const esTranslation = {
servers: 'Servidores',
serverName: 'Nombre del Servidor',
serverUrl: 'URL del Servidor',
serverUrlPlaceholder: '192.168.1.100:4533 o https://music.example.com',
serverUsername: 'Usuario',
serverPassword: 'Contraseña',
addServer: 'Agregar Servidor',
src/locales/fr.ts
+2 -1
View File
@@ -313,7 +313,7 @@ export const frTranslation = {
serverName: 'Nom du serveur (facultatif)',
serverNamePlaceholder: 'Mon Navidrome',
serverUrl: 'URL du serveur',
serverUrlPlaceholder: '192.168.1.100:4533 ou music.exemple.com',
serverUrlPlaceholder: '192.168.1.100:4533 ou https://music.exemple.com',
username: 'Nom d\'utilisateur',
usernamePlaceholder: 'admin',
password: 'Mot de passe',
@@ -414,6 +414,7 @@ export const frTranslation = {
servers: 'Serveurs',
serverName: 'Nom du serveur',
serverUrl: 'URL du serveur',
serverUrlPlaceholder: '192.168.1.100:4533 ou https://music.exemple.com',
serverUsername: 'Nom d\'utilisateur',
serverPassword: 'Mot de passe',
addServer: 'Ajouter un serveur',
src/locales/nb.ts
+2 -1
View File
@@ -313,7 +313,7 @@ export const nbTranslation = {
serverName: 'Tjenernavn (valgfritt)',
serverNamePlaceholder: 'Mitt mediabibliotek',
serverUrl: 'Tjener-URL',
serverUrlPlaceholder: '192.168.1.100:4533 eller feks. musikk.eksempel.com',
serverUrlPlaceholder: '192.168.1.100:4533 eller https://musikk.eksempel.com',
username: 'Brukernavn',
usernamePlaceholder: 'admin',
password: 'Passord',
@@ -414,6 +414,7 @@ export const nbTranslation = {
servers: 'Tjenere',
serverName: 'Tjenernavn',
serverUrl: 'Tjener-URL',
serverUrlPlaceholder: '192.168.1.100:4533 eller https://musikk.eksempel.com',
serverUsername: 'Brukernavn',
serverPassword: 'Passord',
addServer: 'Legg til tjener',
src/locales/nl.ts
+2 -1
View File
@@ -312,7 +312,7 @@ export const nlTranslation = {
serverName: 'Servernaam (optioneel)',
serverNamePlaceholder: 'Mijn Navidrome',
serverUrl: 'Server-URL',
serverUrlPlaceholder: '192.168.1.100:4533 of music.voorbeeld.nl',
serverUrlPlaceholder: '192.168.1.100:4533 of https://music.voorbeeld.nl',
username: 'Gebruikersnaam',
usernamePlaceholder: 'admin',
password: 'Wachtwoord',
@@ -413,6 +413,7 @@ export const nlTranslation = {
servers: 'Servers',
serverName: 'Servernaam',
serverUrl: 'Server-URL',
serverUrlPlaceholder: '192.168.1.100:4533 of https://music.voorbeeld.nl',
serverUsername: 'Gebruikersnaam',
serverPassword: 'Wachtwoord',
addServer: 'Server toevoegen',
src/locales/ru.ts
+2 -1
View File
@@ -324,7 +324,7 @@ export const ruTranslation = {
serverName: 'Название сервера (необязательно)',
serverNamePlaceholder: 'Мой Navidrome',
serverUrl: 'Адрес сервера',
serverUrlPlaceholder: '192.168.1.100:4533 или music.example.com',
serverUrlPlaceholder: '192.168.1.100:4533 или https://music.example.com',
username: 'Логин',
usernamePlaceholder: 'admin',
password: 'Пароль',
@@ -429,6 +429,7 @@ export const ruTranslation = {
servers: 'Серверы',
serverName: 'Название',
serverUrl: 'Адрес',
serverUrlPlaceholder: '192.168.1.100:4533 или https://music.example.com',
serverUsername: 'Логин',
serverPassword: 'Пароль',
addServer: 'Добавить сервер',
src/locales/zh.ts
+2 -1
View File
@@ -312,7 +312,7 @@ export const zhTranslation = {
serverName: '服务器名称（可选）',
serverNamePlaceholder: '我的 Navidrome',
serverUrl: '服务器地址',
serverUrlPlaceholder: '192.168.1.100:4533 或 music.example.com',
serverUrlPlaceholder: '192.168.1.100:4533 或 https://music.example.com',
username: '用户名',
usernamePlaceholder: 'admin',
password: '密码',
@@ -409,6 +409,7 @@ export const zhTranslation = {
servers: '服务器',
serverName: '服务器名称',
serverUrl: '服务器地址',
serverUrlPlaceholder: '192.168.1.100:4533 或 https://music.example.com',
serverUsername: '用户名',
serverPassword: '密码',
addServer: '添加服务器',
src/pages/Settings.tsx
+1 -1
View File
@@ -168,7 +168,7 @@ function AddServerForm({ onSave, onCancel }: { onSave: (data: Omit<ServerProfile
</div>
<div className="form-group" style={{ marginBottom: '0.75rem' }}>
<label style={{ fontSize: 13 }}>{t('settings.serverUrl')}</label>
<input className="input" type="text" value={form.url} onChange={update('url')} placeholder="192.168.1.100:4533" autoComplete="off" />
<input className="input" type="text" value={form.url} onChange={update('url')} placeholder={t('settings.serverUrlPlaceholder')} autoComplete="off" />
</div>
<div className="form-row" style={{ marginBottom: '0.75rem' }}>
<div className="form-group">