fix(cover): follow connect-URL flips in library cover backfill (#952)

* fix(cover): follow connect-URL flips in library cover backfill

The native cover backfill was configured once with a snapshot of the runtime
connect URL. When a laptop moved off the LAN, the smart endpoint switch flipped
the sticky connect URL to the public address (playback/UI covers rebuild it per
request and followed it), but backfill kept fetching from the now-unreachable
local address — flooding the log with "error sending request" failures.

Make the connect cache observable (notify on effective flips) and have the
backfill hook reconfigure when the resolved URL changes, forcing a pass so the
.fetch-failed backoff from the stale address is cleared and those covers retry
on the reachable endpoint.

* docs(changelog): note cover backfill endpoint-switch fix (PR #952)

* fix(cover): abort stale backfill pass + rerun on connect-URL flip

Frontend reconfigure alone didn't fully cover the boot case: at startup the
first backfill pass starts on the primary (LAN) URL before the reachability
probe resolves, so when the probe flips to public the forced rerun was dropped
by the pass_running guard and the slow LAN pass (every cover timing out) ran to
completion with nothing re-running on the reachable address.

set_session now bumps a session generation; the running pass checks it on every
focus gate and abandons promptly when the URL flips (same server_index_key, new
rest_base_url). try_schedule_full_pass records a rerun when a pass is in flight
and drains it once the abandoned pass returns, so a fresh forced pass runs on
the new address.

* fix(cover-backfill): resolve connect URL per fetch instead of baking it into the queue

The backfill worklist no longer carries a URL. Each cover fetch reads the
current reachable address live from a single worker cell, so a LAN↔public flip
is honoured even by the pass already in flight — its remaining covers download
against the new endpoint without aborting/rebuilding the worklist.

- Drop rest_base_url from CoverBackfillSession; add live base_url cell read in
  ensure_one. Remove the session-generation abort machinery (no longer needed).
- New lightweight library_cover_backfill_set_base_url command pushes the URL on
  every connect-cache flip; a real change clears the stale .fetch-failed backoff
  and runs a forced pass so covers that timed out on the old address retry.
- Split useLibraryCoverBackfill into a configure effect (server/creds/strategy)
  and a flip effect that only pushes the URL.
- Keep a single rerun_pending flag for the boot case (flip mid-pass), since the
  finished pass re-arms the idle gate.

CHANGELOG.md

@@ -696,6 +696,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 * It now treats a release as multi-disc only when each disc has a single consistent cover that differs across discs (a genuine box set); per-song ids collapse to one cover per album (≈ albums + artists). Fixed on both the Rust backfill path and the on-demand TS `albumHasDistinctDiscCovers`.
 * Failed cover downloads are now logged with the album/artist name and the server error (e.g. `fetch failed for album "X" — Artist (coverArtId=…): cover HTTP 503`). Backfill failures log at the normal level; incidental on-demand misses stay at the debug level.
 
+### Cover backfill — follow the local/public endpoint switch
+
+**By [@cucadmuh](https://github.com/cucadmuh), PR [#952](https://github.com/Psychotoxical/psysonic/pull/952)**
+
+* On a dual-address server, library cover backfill was configured once with a snapshot of the connect URL and never followed the smart LAN↔public switch. Starting already off the LAN — or moving off it mid-session — (internet up, playback already on the public address) left backfill hammering the now-unreachable local address and flooding the log with `error sending request` failures.
+* The backfill worklist no longer carries a URL: each cover fetch now reads the current reachable address live, so a LAN↔public flip is honoured even by the pass already in flight (its remaining covers download against the new endpoint). The connect cache is observable and pushes the resolved URL to the native worker on every flip; a real change clears the stale `.fetch-failed` backoff and runs a forced pass so the handful of covers attempted against the old address retry on the reachable one. This also covers the boot case where the initial pass starts on the primary URL before the first reachability probe resolves. On-demand UI / playback covers already followed the switch.
+
 ## [1.46.0] - 2026-05-18
 
 > **🙏 Special thanks to [@zz5zz](https://github.com/zz5zz)** for his tireless quirk-spotting and bug reports on the [Psysonic Discord](https://discord.gg/AMnDRErm4u) — several of the polish fixes in this release landed directly off the back of his messages.

src-tauri/src/cover_cache/backfill_worker.rs

@@ -51,7 +51,6 @@ fn now_ms() -> u64 {
 pub struct CoverBackfillSession {
     pub server_index_key: String,
     pub library_server_id: String,
-    pub rest_base_url: String,
     pub username: String,
     pub password: String,
 }
@@ -86,6 +85,16 @@ pub struct CoverBackfillWorker {
     /// Epoch-ms of the last `sync-idle`-driven pass, to rate-limit the idle-gate
     /// disk walk against chatty syncs. 0 = never.
     last_sync_idle_ms: AtomicU64,
+    /// Live connect URL, resolved fresh per cover fetch rather than baked into
+    /// the worklist. The worklist holds URL-agnostic items; a LAN→public flip
+    /// just swaps this cell, so even the pass already in flight downloads its
+    /// remaining covers against the now-reachable endpoint.
+    base_url: std::sync::Mutex<String>,
+    /// A forced retry requested while a pass was already running (e.g. the
+    /// connect URL flipped LAN→public at boot). The in-flight pass already
+    /// adopts the new URL live, but the handful of covers it attempted against
+    /// the stale address need one more forced pass once it finishes.
+    rerun_pending: AtomicBool,
 }
 
 #[derive(Debug, Clone, Serialize)]
@@ -124,6 +133,8 @@ impl CoverBackfillWorker {
             parallel: AtomicUsize::new(LIBRARY_BACKFILL_PARALLEL_DEFAULT),
             settled: Mutex::new(None),
             last_sync_idle_ms: AtomicU64::new(0),
+            base_url: std::sync::Mutex::new(String::new()),
+            rerun_pending: AtomicBool::new(false),
         }
     }
 
@@ -168,9 +179,15 @@ impl CoverBackfillWorker {
         next
     }
 
-    pub async fn set_session(&self, enabled: bool, session: Option<CoverBackfillSession>) {
+    pub async fn set_session(
+        &self,
+        enabled: bool,
+        session: Option<CoverBackfillSession>,
+        base_url: String,
+    ) {
         self.enabled.store(enabled, Ordering::Relaxed);
         *self.session.lock().await = session;
+        *self.base_url.lock().unwrap() = base_url;
         // Server switch or enable/disable invalidates any settled state: re-arm
         // so the next idle event runs a real pass for the new focus.
         *self.settled.lock().await = None;
@@ -179,6 +196,23 @@ impl CoverBackfillWorker {
         }
     }
 
+    /// Current connect URL for backfill fetches. Read fresh per cover so a
+    /// LAN→public flip is honoured mid-pass without rebuilding the worklist.
+    pub fn base_url(&self) -> String {
+        self.base_url.lock().unwrap().clone()
+    }
+
+    /// Swap the live connect URL. Returns `true` when it actually changed, so the
+    /// caller can clear the now-stale fetch-failed backoff and kick a retry pass.
+    pub fn set_base_url(&self, url: String) -> bool {
+        let mut cell = self.base_url.lock().unwrap();
+        if *cell == url {
+            return false;
+        }
+        *cell = url;
+        true
+    }
+
     pub async fn reset_cursor(&self) {
         *self.cursor.lock().await = String::new();
     }
@@ -204,7 +238,10 @@ fn session_matches_server(session: &CoverBackfillSession, server_id: &str) -> bo
     server_id == session.server_index_key || server_id == session.library_server_id
 }
 
-/// Backfill runs only while this session is still the configured focus (active server).
+/// Backfill runs only while this session is still the configured focus (active
+/// server). A connect-URL flip keeps the same `server_index_key` and is picked
+/// up live via `worker.base_url()`, so it does not abort the pass — only a
+/// server switch or disable does.
 async fn session_still_focused(worker: &CoverBackfillWorker, expected: &CoverBackfillSession) -> bool {
     if !worker.enabled.load(Ordering::Relaxed) {
         return false;
@@ -267,7 +304,7 @@ async fn ensure_one(
         cache_entity_id: item.cache_entity_id,
         cover_art_id: item.fetch_cover_art_id,
         tier: LIBRARY_COVER_CANONICAL_TIER,
-        rest_base_url: session.rest_base_url,
+        rest_base_url: worker.base_url(),
         username: session.username,
         password: session.password,
         library_bulk: true,
@@ -531,13 +568,38 @@ pub async fn try_schedule_full_pass(app: &AppHandle, force: bool) -> bool {
         .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst)
         .is_err()
     {
+        // A pass is already running. It reads the connect URL live per cover, so
+        // any flip that landed mid-pass already applies to its remaining work.
+        // A forced retry (URL flip) still queues a rerun so the few covers the
+        // in-flight pass attempted against the stale address get re-fetched.
+        if force {
+            worker.rerun_pending.store(true, Ordering::SeqCst);
+        }
         return false;
     }
 
     let app = app.clone();
     tauri::async_runtime::spawn(async move {
-        run_full_pass(app, worker.clone(), force).await;
-        worker.pass_running.store(false, Ordering::SeqCst);
+        run_full_pass(app.clone(), worker.clone(), force).await;
+        // Drain a forced rerun queued mid-pass (always forced: it bypasses the
+        // idle gate the just-finished pass re-armed and clears the stale backoff).
+        loop {
+            worker.pass_running.store(false, Ordering::SeqCst);
+            if !worker.rerun_pending.swap(false, Ordering::SeqCst)
+                || !worker.enabled.load(Ordering::Relaxed)
+            {
+                break;
+            }
+            if worker
+                .pass_running
+                .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst)
+                .is_err()
+            {
+                worker.rerun_pending.store(true, Ordering::SeqCst);
+                break;
+            }
+            run_full_pass(app.clone(), worker.clone(), true).await;
+        }
     });
     true
 }

src-tauri/src/cover_cache/mod.rs

@@ -720,7 +720,6 @@ pub async fn library_cover_backfill_configure(
         Some(CoverBackfillSession {
             server_index_key,
             library_server_id,
-            rest_base_url,
             username,
             password,
         })
@@ -728,7 +727,7 @@ pub async fn library_cover_backfill_configure(
         None
     };
     worker
-        .set_session(enabled && session.is_some(), session)
+        .set_session(enabled && session.is_some(), session, rest_base_url)
         .await;
     if enabled {
         let _ = try_schedule_full_pass(&app, false).await;
@@ -736,6 +735,32 @@ pub async fn library_cover_backfill_configure(
     Ok(())
 }
 
+/// Push the current reachable connect URL without rebuilding the backfill
+/// session. The worklist holds URL-agnostic items and each fetch reads this
+/// value live, so a LAN→public flip is honoured by the in-flight pass too.
+/// When the URL actually changes, the stale `.fetch-failed` backoff (covers that
+/// timed out against the old address) is cleared and a pass is kicked so they
+/// retry on the now-reachable endpoint.
+#[tauri::command]
+pub async fn library_cover_backfill_set_base_url(
+    app: AppHandle,
+    rest_base_url: String,
+) -> Result<(), String> {
+    let worker = app
+        .try_state::<Arc<CoverBackfillWorker>>()
+        .ok_or_else(|| "cover backfill worker not initialized".to_string())?;
+    if !worker.set_base_url(rest_base_url) {
+        return Ok(());
+    }
+    // Forced retry: bypass the idle gate and clear the `.fetch-failed` backoff so
+    // covers that timed out against the old address are re-attempted on the new
+    // one. If a pass is in flight it already adopted the new URL live; the forced
+    // pass is queued to run right after it.
+    worker.rearm_idle_gate().await;
+    let _ = try_schedule_full_pass(&app, true).await;
+    Ok(())
+}
+
 #[derive(Debug, Clone, Deserialize)]
 #[serde(rename_all = "camelCase")]
 pub struct CoverCachePeekItem {

src-tauri/src/lib.rs

@@ -761,6 +761,7 @@ pub fn run() {
             cover_cache::library_cover_catalog_size,
             cover_cache::library_cover_clear_fetch_failures,
             cover_cache::library_cover_backfill_configure,
+            cover_cache::library_cover_backfill_set_base_url,
             cover_cache::library_cover_backfill_pulse,
             cover_cache::library_cover_backfill_reset_cursor,
             cover_cache::library_cover_backfill_set_ui_priority,

src/api/coverCache.ts

@@ -210,6 +210,16 @@ export async function libraryCoverBackfillConfigure(
   return invoke('library_cover_backfill_configure', args);
 }
 
+/**
+ * Push the current reachable connect URL to the native backfill worker without
+ * rebuilding the session. The worklist is URL-agnostic; each fetch reads this
+ * value live, so a LAN→public flip is honoured by the in-flight pass too. A real
+ * change clears the stale fetch-failed backoff and kicks a retry pass.
+ */
+export async function libraryCoverBackfillSetBaseUrl(restBaseUrl: string): Promise<void> {
+  return invoke('library_cover_backfill_set_base_url', { restBaseUrl });
+}
+
 export type CoverBackfillPulseResult = {
   scheduled: number;
   exhausted: boolean;

src/config/settingsCredits.ts

@@ -150,6 +150,7 @@ const CONTRIBUTOR_ENTRIES = [
       'Performance Probe: live runtime logs tab with depth switch, line cap, and ordered include/exclude word filter (PR #946)',
       'Performance Probe: on-demand (ui) cover throughput alongside backfill (lib) cpm (PR #947)',
       'Performance Probe: throughput (analysis tpm, cover cpm) measured over a trailing 5s window so the rate reacts promptly instead of coasting on minute-long inertia (PR #948)',
+      'Cover backfill: follow the smart local/public endpoint switch so off-LAN clients stop fetching covers from the unreachable local address (PR #952)',
     ],
   },
   {

src/hooks/useLibraryCoverBackfill.ts

@@ -1,9 +1,10 @@
-import { useEffect } from 'react';
+import { useEffect, useSyncExternalStore } from 'react';
 import {
   coverCacheRestHost,
   libraryCoverBackfillConfigure,
   libraryCoverBackfillResetCursor,
   libraryCoverBackfillRunFullPass,
+  libraryCoverBackfillSetBaseUrl,
   librarySqlServerId,
 } from '../api/coverCache';
 import { coverStrategyAllowsLibraryBackfill } from '../utils/library/coverStrategy';
@@ -11,6 +12,7 @@ import { useAuthStore } from '../store/authStore';
 import { useCoverStrategyStore } from '../store/coverStrategyStore';
 import { subscribeLibraryCoverBackfillWake } from '../utils/library/coverBackfillWake';
 import { serverIndexKeyForProfile } from '../utils/server/serverIndexKey';
+import { subscribeConnectCache } from '../utils/server/serverEndpoint';
 
 /**
  * Library cover warm-up — configure session in Rust; full pass runs natively.
@@ -26,7 +28,14 @@ export function useLibraryCoverBackfill(enabled = true): void {
   const server = useAuthStore(s =>
     s.activeServerId ? s.servers.find(srv => srv.id === s.activeServerId) : undefined,
   );
-  const getBaseUrl = useAuthStore(s => s.getBaseUrl);
+  // Runtime-probed connect URL: it flips when the sticky endpoint changes (e.g.
+  // laptop moves off the LAN). The native worklist is URL-agnostic — we push the
+  // live URL separately (below) rather than baking it into the session.
+  const connectBaseUrl = useSyncExternalStore(
+    subscribeConnectCache,
+    () => useAuthStore.getState().getBaseUrl(),
+    () => useAuthStore.getState().getBaseUrl(),
+  );
 
   useEffect(() => {
     const kick = () => {
@@ -36,6 +45,9 @@ export function useLibraryCoverBackfill(enabled = true): void {
     return unsubWake;
   }, []);
 
+  // Session config (server identity, credentials, strategy, enable). The connect
+  // URL is intentionally NOT a dependency here: it changes far more often than
+  // these, and the worklist no longer carries it — see the flip effect below.
   useEffect(() => {
     const disable = () => {
       void libraryCoverBackfillConfigure({
@@ -59,13 +71,14 @@ export function useLibraryCoverBackfill(enabled = true): void {
     }
 
     const indexKey = serverIndexKeyForProfile(server);
-    const baseUrl = getBaseUrl();
     void (async () => {
+      // Seed the URL with the current best guess; the flip effect keeps it fresh.
+      const seedUrl = useAuthStore.getState().getBaseUrl();
       await libraryCoverBackfillConfigure({
         enabled: true,
         serverIndexKey: indexKey,
         libraryServerId: librarySqlServerId(activeServerId),
-        restBaseUrl: baseUrl ? coverCacheRestHost(baseUrl) : '',
+        restBaseUrl: seedUrl ? coverCacheRestHost(seedUrl) : '',
         username: server.username,
         password: server.password,
       });
@@ -74,5 +87,22 @@ export function useLibraryCoverBackfill(enabled = true): void {
     })();
 
     return disable;
-  }, [enabled, strategy, activeServerId, server?.url, server?.username, server?.password, getBaseUrl]);
+  }, [enabled, strategy, activeServerId, server?.url, server?.username, server?.password]);
+
+  // Connect-URL flip: push the new reachable address live. The native worker
+  // swaps a single cell, so even an in-flight pass downloads its remaining
+  // covers against it; a real change also clears the stale fetch-failed backoff
+  // and kicks a retry pass for whatever failed on the old address.
+  useEffect(() => {
+    if (
+      !enabled
+      || !coverStrategyAllowsLibraryBackfill(strategy)
+      || !activeServerId
+      || !server
+      || !connectBaseUrl
+    ) {
+      return;
+    }
+    void libraryCoverBackfillSetBaseUrl(coverCacheRestHost(connectBaseUrl));
+  }, [connectBaseUrl, enabled, strategy, activeServerId, server?.url]);
 }

src/utils/server/serverEndpoint.test.ts

@@ -15,6 +15,7 @@ import {
   pickReachableBaseUrl,
   serverAddressEndpoints,
   serverShareBaseUrl,
+  subscribeConnectCache,
 } from './serverEndpoint';
 import type { ServerProfile } from '../../store/authStoreTypes';
 
@@ -377,6 +378,66 @@ describe('invalidateReachableEndpointCache', () => {
   });
 });
 
+describe('subscribeConnectCache — connect-URL flip notifications', () => {
+  beforeEach(() => {
+    invalidateReachableEndpointCache();
+    vi.mocked(pingWithCredentials).mockReset();
+  });
+
+  it('notifies when a probe resolves a new endpoint and on a later flip', async () => {
+    const listener = vi.fn();
+    const unsubscribe = subscribeConnectCache(listener);
+    const profile = makeProfile({
+      url: 'https://music.example.com',
+      alternateUrl: 'http://192.168.0.10',
+    });
+
+    // First probe: LAN answers → cache set → one notification.
+    vi.mocked(pingWithCredentials).mockResolvedValueOnce(pingOk());
+    await pickReachableBaseUrl(profile);
+    expect(listener).toHaveBeenCalledTimes(1);
+
+    // LAN drops, public answers → cached URL flips → another notification.
+    vi.mocked(pingWithCredentials)
+      .mockResolvedValueOnce(pingFail())
+      .mockResolvedValueOnce(pingOk());
+    await pickReachableBaseUrl(profile);
+    expect(listener).toHaveBeenCalledTimes(2);
+
+    unsubscribe();
+  });
+
+  it('does not notify when the sticky endpoint is unchanged', async () => {
+    const profile = makeProfile({ url: 'http://192.168.0.10' });
+    vi.mocked(pingWithCredentials).mockResolvedValueOnce(pingOk());
+    await pickReachableBaseUrl(profile);
+
+    const listener = vi.fn();
+    const unsubscribe = subscribeConnectCache(listener);
+    // Re-probe, same endpoint answers → cache value identical → no notification.
+    vi.mocked(pingWithCredentials).mockResolvedValueOnce(pingOk());
+    await pickReachableBaseUrl(profile);
+    expect(listener).not.toHaveBeenCalled();
+
+    unsubscribe();
+  });
+
+  it('notifies on explicit cache invalidation when an entry existed', async () => {
+    vi.mocked(pingWithCredentials).mockResolvedValueOnce(pingOk());
+    await pickReachableBaseUrl(makeProfile({ id: 'a' }));
+
+    const listener = vi.fn();
+    const unsubscribe = subscribeConnectCache(listener);
+    invalidateReachableEndpointCache('a');
+    expect(listener).toHaveBeenCalledTimes(1);
+    // No-op invalidation (nothing cached) must stay silent.
+    invalidateReachableEndpointCache('a');
+    expect(listener).toHaveBeenCalledTimes(1);
+
+    unsubscribe();
+  });
+});
+
 describe('serverShareBaseUrl', () => {
   it('returns the single address for a single-URL profile', () => {
     expect(serverShareBaseUrl({ url: 'https://music.example.com' })).toBe(

src/utils/server/serverEndpoint.ts

@@ -165,6 +165,33 @@ export function serverShareBaseUrl(
 
 const connectCache = new Map<string, string>();
 
+// ── Connect-cache change notifications ───────────────────────────────────────
+// The sticky connect URL flips silently (120-s probe tick / online event /
+// switch). Long-lived consumers that snapshot the URL once — notably the native
+// **library cover backfill**, which is configured with a fixed `rest_base_url`
+// — need to react when a laptop moves off the LAN, or they keep hammering the
+// now-unreachable local address. UI/playback rebuild the URL per request and
+// don't need this. Listeners are notified only when a profile's cached URL
+// actually changes value (set to a different endpoint, dropped, or cleared).
+const connectCacheListeners = new Set<() => void>();
+let connectCacheVersion = 0;
+
+function notifyConnectCacheChanged(): void {
+  connectCacheVersion += 1;
+  connectCacheListeners.forEach(cb => cb());
+}
+
+/** Subscribe to connect-URL flips (any profile). Returns an unsubscribe fn. */
+export function subscribeConnectCache(cb: () => void): () => void {
+  connectCacheListeners.add(cb);
+  return () => connectCacheListeners.delete(cb);
+}
+
+/** Monotonic version, bumped on every effective connect-cache change. */
+export function getConnectCacheVersion(): number {
+  return connectCacheVersion;
+}
+
 /**
  * In-flight probes keyed by `profile.id`. Three call sites (useConnectionStatus
  * 120-s tick, switchActiveServer, bindIndexedServer, plus retry / online
@@ -208,14 +235,17 @@ export function connectBaseUrlForServer(
  */
 export function invalidateReachableEndpointCache(profileId?: string): void {
   if (profileId === undefined) {
-    connectCache.clear();
     // Don't clear in-flight slots — they're already racing against the
     // network, letting their own `finally` clean up keeps the dedup
     // invariant. Their results will still write to the (now empty) cache,
     // which is the right behaviour: the freshest probe wins.
+    if (connectCache.size > 0) {
+      connectCache.clear();
+      notifyConnectCacheChanged();
+    }
     return;
   }
-  connectCache.delete(profileId);
+  if (connectCache.delete(profileId)) notifyConnectCacheChanged();
 }
 
 /**
@@ -250,14 +280,16 @@ export async function pickReachableBaseUrl(
     for (const endpoint of endpoints) {
       const ping = await pingWithCredentials(endpoint.url, profile.username, profile.password);
       if (ping.ok) {
+        const prev = connectCache.get(profile.id);
         connectCache.set(profile.id, endpoint.url);
+        if (prev !== endpoint.url) notifyConnectCacheChanged();
         return { ok: true, baseUrl: endpoint.url, endpoint, ping };
       }
     }
 
     // Every endpoint failed — drop any stale cache entry so the next probe
     // starts from the natural LAN-first order.
-    connectCache.delete(profile.id);
+    if (connectCache.delete(profile.id)) notifyConnectCacheChanged();
     return { ok: false, reason: 'unreachable' };
   })();