From d832dfb253a16b8d74654197e0cd4687aaf15b07 Mon Sep 17 00:00:00 2001
From: Psychotoxical <dev@psysonic.app>
Date: Wed, 8 Apr 2026 15:37:12 +0200
Subject: [PATCH] fix(statistics): remove Top Rated Songs/Artists sections

The implementation was unreliable (depended on starred songs + session-only
overrides) so the sections are removed entirely. All PR#130 rating logic
(StarRating, setRating API calls, userRatingOverrides) is untouched.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 src/pages/Statistics.tsx | 97 ++--------------------------------------
 1 file changed, 3 insertions(+), 94 deletions(-)

diff --git a/src/pages/Statistics.tsx b/src/pages/Statistics.tsx
index f8a941f3..9627d0c6 100644
--- a/src/pages/Statistics.tsx
+++ b/src/pages/Statistics.tsx
@@ -1,10 +1,9 @@
-import React, { useEffect, useMemo, useState } from 'react';
-import { getAlbumList, getArtists, getGenres, getRandomSongs, getStarred, SubsonicAlbum, SubsonicArtist, SubsonicGenre, SubsonicSong } from '../api/subsonic';
+import React, { useEffect, useState } from 'react';
+import { getAlbumList, getArtists, getGenres, getRandomSongs, SubsonicAlbum, SubsonicGenre } from '../api/subsonic';
 import AlbumRow from '../components/AlbumRow';
 import { useTranslation } from 'react-i18next';
 import { useAuthStore } from '../store/authStore';
 import { useNavigate } from 'react-router-dom';
-import { usePlayerStore } from '../store/playerStore';
 import { lastfmIsConfigured, lastfmGetTopArtists, lastfmGetTopAlbums, lastfmGetTopTracks, lastfmGetRecentTracks, LastfmPeriod, LastfmTopArtist, LastfmTopAlbum, LastfmTopTrack, LastfmRecentTrack } from '../api/lastfm';
 
 // eslint-disable-next-line @typescript-eslint/no-explicit-any
@@ -40,27 +39,6 @@ export default function Statistics() {
   const [recent, setRecent] = useState<SubsonicAlbum[]>([]);
   const [frequent, setFrequent] = useState<SubsonicAlbum[]>([]);
   const [highest, setHighest] = useState<SubsonicAlbum[]>([]);
-  const [starredSongs, setStarredSongs] = useState<SubsonicSong[]>([]);
-  const [topArtists, setTopArtists] = useState<SubsonicArtist[]>([]);
-  const userRatingOverrides = usePlayerStore(s => s.userRatingOverrides);
-  const queue = usePlayerStore(s => s.queue);
-  const currentTrack = usePlayerStore(s => s.currentTrack);
-
-  const topSongs = useMemo(() => {
-    const map = new Map<string, SubsonicSong>(starredSongs.map(s => [s.id, { ...s, userRating: userRatingOverrides[s.id] ?? s.userRating }]));
-    // Songs not yet in starredSongs but rated via override (e.g. from queue or currentTrack)
-    const candidates = currentTrack ? [currentTrack, ...queue] : queue;
-    for (const t of candidates) {
-      const r = userRatingOverrides[t.id];
-      if (r && !map.has(t.id)) {
-        map.set(t.id, { id: t.id, title: t.title, artist: t.artist, album: t.album, albumId: t.albumId, userRating: r } as SubsonicSong);
-      }
-    }
-    return [...map.values()]
-      .filter(s => (s.userRating ?? 0) > 0)
-      .sort((a, b) => (b.userRating ?? 0) - (a.userRating ?? 0))
-      .slice(0, 10);
-  }, [starredSongs, userRatingOverrides, queue, currentTrack]);
   const [artistCount, setArtistCount] = useState<number | null>(null);
   const [totalSongs, setTotalSongs] = useState<number | null>(null);
   const [totalAlbums, setTotalAlbums] = useState<number | null>(null);
@@ -87,8 +65,7 @@ export default function Statistics() {
       getAlbumList('highest', 12).catch(() => []),
       getArtists().catch(() => []),
       getGenres().catch(() => []),
-      getStarred().catch(() => ({ albums: [], artists: [], songs: [] })),
-    ]).then(([rc, fr, hi, a, g, starred]) => {
+    ]).then(([rc, fr, hi, a, g]) => {
       setRecent(rc);
       setFrequent(fr);
       setHighest(hi);
@@ -97,13 +74,6 @@ export default function Statistics() {
       setTotalAlbums(g.reduce((acc: number, genre: SubsonicGenre) => acc + genre.albumCount, 0));
       const sorted = [...g].sort((a, b) => b.songCount - a.songCount);
       setGenres(sorted);
-      setStarredSongs(starred.songs);
-      setTopArtists(
-        [...starred.artists]
-          .filter(a => (a.userRating ?? 0) > 0)
-          .sort((a, b) => (b.userRating ?? 0) - (a.userRating ?? 0))
-          .slice(0, 10),
-      );
       setLoading(false);
     }).catch(() => setLoading(false));
   }, [musicLibraryFilterVersion]);
@@ -317,67 +287,6 @@ export default function Statistics() {
             showRating
           />
 
-          {/* Top Rated Songs + Artists */}
-          <div style={{ display: 'grid', gridTemplateColumns: 'repeat(auto-fit, minmax(280px, 1fr))', gap: '1rem', marginBottom: '0.5rem' }}>
-            <div style={{ background: 'var(--glass-bg)', border: '1px solid var(--glass-border)', borderRadius: '12px', padding: '1.25rem', backdropFilter: 'blur(8px)' }}>
-              <h3 style={{ fontSize: '0.7rem', fontWeight: 700, textTransform: 'uppercase', letterSpacing: '0.1em', color: 'var(--accent)', marginBottom: '1rem' }}>
-                {t('statistics.topRatedSongs')}
-              </h3>
-              {topSongs.length === 0 ? (
-                <p style={{ fontSize: '0.8rem', color: 'var(--text-muted)' }}>{t('statistics.noRatedSongs')}</p>
-              ) : (
-                <ol style={{ listStyle: 'none', padding: 0, margin: 0, display: 'flex', flexDirection: 'column', gap: '0.75rem' }}>
-                  {topSongs.map((song, i) => (
-                    <li key={song.id} style={{ display: 'flex', alignItems: 'center', gap: '0.625rem', cursor: song.albumId ? 'pointer' : 'default' }}
-                      onClick={() => song.albumId && navigate(`/album/${song.albumId}`)}>
-                      <span style={{ fontSize: '1.1rem', fontWeight: 800, color: i === 0 ? 'var(--accent)' : 'var(--text-muted)', opacity: i === 0 ? 1 : 0.5, lineHeight: 1, flexShrink: 0, width: '1.5rem' }}>
-                        {i + 1}
-                      </span>
-                      <div style={{ flex: 1, minWidth: 0 }}>
-                        <div style={{ fontSize: '0.875rem', fontWeight: 500, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>{song.title}</div>
-                        <div style={{ fontSize: '0.75rem', color: 'var(--text-muted)', overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>{song.artist}</div>
-                      </div>
-                      <span style={{ fontSize: '11px', color: 'var(--accent)', flexShrink: 0, letterSpacing: '1px' }}>
-                        {'★'.repeat(song.userRating!)}{'☆'.repeat(5 - song.userRating!)}
-                      </span>
-                    </li>
-                  ))}
-                </ol>
-              )}
-            </div>
-
-            <div style={{ background: 'var(--glass-bg)', border: '1px solid var(--glass-border)', borderRadius: '12px', padding: '1.25rem', backdropFilter: 'blur(8px)' }}>
-              <h3 style={{ fontSize: '0.7rem', fontWeight: 700, textTransform: 'uppercase', letterSpacing: '0.1em', color: 'var(--accent)', marginBottom: '1rem' }}>
-                {t('statistics.topRatedArtists')}
-              </h3>
-              {topArtists.length === 0 ? (
-                <p style={{ fontSize: '0.8rem', color: 'var(--text-muted)' }}>{t('statistics.noRatedArtists')}</p>
-              ) : (
-                <ol style={{ listStyle: 'none', padding: 0, margin: 0, display: 'flex', flexDirection: 'column', gap: '0.75rem' }}>
-                  {topArtists.map((artist, i) => (
-                    <li key={artist.id} style={{ display: 'flex', alignItems: 'center', gap: '0.625rem', cursor: 'pointer' }}
-                      onClick={() => navigate(`/artist/${artist.id}`)}>
-                      <span style={{ fontSize: '1.1rem', fontWeight: 800, color: i === 0 ? 'var(--accent)' : 'var(--text-muted)', opacity: i === 0 ? 1 : 0.5, lineHeight: 1, flexShrink: 0, width: '1.5rem' }}>
-                        {i + 1}
-                      </span>
-                      <div style={{ flex: 1, minWidth: 0 }}>
-                        <div style={{ fontSize: '0.875rem', fontWeight: 500, overflow: 'hidden', textOverflow: 'ellipsis', whiteSpace: 'nowrap' }}>{artist.name}</div>
-                        {(artist.albumCount ?? 0) > 0 && (
-                          <div style={{ fontSize: '0.75rem', color: 'var(--text-muted)' }}>
-                            {t('artistDetail.albumCount_other', { count: artist.albumCount })}
-                          </div>
-                        )}
-                      </div>
-                      <span style={{ fontSize: '11px', color: 'var(--accent)', flexShrink: 0, letterSpacing: '1px' }}>
-                        {'★'.repeat(artist.userRating!)}{'☆'.repeat(5 - artist.userRating!)}
-                      </span>
-                    </li>
-                  ))}
-                </ol>
-              )}
-            </div>
-          </div>
-
           {/* Last.fm Stats */}
           {lastfmIsConfigured() && (
             <section style={{ marginTop: '2rem' }}>