fix(pr-review): address review findings for music folder filter

- Sidebar.tsx: title={} → data-tooltip + data-tooltip-pos="right" on
  scope subtitle (CLAUDE.md rule: never use native title= for tooltips)

- authStore.ts: merge two set() calls in setMusicFolders into one atomic
  update — avoids double render on folder list arrival

- locales (all 7): remove dead libraryScopeHint key (defined but never
  rendered in any component)

- Genres.tsx: remove musicLibraryFilterVersion from effect deps —
  getGenres is intentionally not folder-scoped, re-fetching on filter
  change was a no-op waste

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Psychotoxical
2026-04-07 13:53:44 +02:00
parent c36b1ea538
commit c779e8f587
10 changed files with 12 additions and 18 deletions
-1
View File
@@ -24,7 +24,6 @@ export const deTranslation = {
playlists: 'Playlists',
radio: 'Internetradio',
libraryScope: 'Bibliotheksumfang',
libraryScopeHint: 'Gesamten Server-Katalog oder nur einen Medienordner durchsuchen.',
allLibraries: 'Alle Bibliotheken',
},
home: {
-1
View File
@@ -24,7 +24,6 @@ export const enTranslation = {
playlists: 'Playlists',
radio: 'Internet Radio',
libraryScope: 'Library scope',
libraryScopeHint: 'Browse either your whole server catalog or a single media folder.',
allLibraries: 'All libraries',
},
home: {
-1
View File
@@ -24,7 +24,6 @@ export const frTranslation = {
playlists: 'Playlists',
radio: 'Radio Internet',
libraryScope: 'Portée de la bibliothèque',
libraryScopeHint: 'Parcourir tout le catalogue du serveur ou un seul dossier média.',
allLibraries: 'Toutes les bibliothèques',
},
home: {
-1
View File
@@ -24,7 +24,6 @@ export const nbTranslation = {
playlists: 'Spillelister',
radio: 'Internettradio',
libraryScope: 'Biblioteksomfang',
libraryScopeHint: 'Vis hele serverkatalogen eller én mediemappe.',
allLibraries: 'Alle biblioteker',
},
home: {
-1
View File
@@ -24,7 +24,6 @@ export const nlTranslation = {
playlists: 'Playlists',
radio: 'Internetradio',
libraryScope: 'Bibliotheekbereik',
libraryScopeHint: 'Doorzoek de hele servercatalogus of één mediabibliotheek.',
allLibraries: 'Alle bibliotheken',
},
home: {
-1
View File
@@ -25,7 +25,6 @@ export const ruTranslation = {
playlists: 'Плейлисты',
radio: 'Онлайн-радио',
libraryScope: 'Область медиатеки',
libraryScopeHint: 'Показывать весь каталог сервера или только одну медиапапку.',
allLibraries: 'Все библиотеки',
},
home: {
-1
View File
@@ -24,7 +24,6 @@ export const zhTranslation = {
playlists: '播放列表',
radio: '网络电台',
libraryScope: '资料库范围',
libraryScopeHint: '浏览整个服务器目录或仅单个媒体文件夹。',
allLibraries: '所有资料库',
},
home: {