itlxrd/psysonic
1
0
Fork 0
mirror of https://github.com/kilyabin/psysonic.git synced 2026-07-22 06:25:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(favorites): correct post-merge issues from PR #184

Browse Source 
- btn-sm: add global .btn-sm modifier to theme.css (was only scoped inside device-sync)
- year filter: exclude songs without year metadata when filter is active
- showing count: only render "X of Y" label when a filter is actually active

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
Psychotoxical
2026-04-14 22:38:41 +02:00
parent 117be0d85e
commit 19b7c8ec06
2 changed files with 16 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/pages/Favorites.tsx
+10 -8
View File
@@ -228,9 +228,9 @@ export default function Favorites() {
if (!hasMatchingGenre) return false; if (!hasMatchingGenre) return false;
} }
// Year range filter // Year range filter — only applied when range is non-default; songs without year are excluded
if (s.year !== undefined) { if (yearRange[0] !== MIN_YEAR || yearRange[1] !== CURRENT_YEAR) {
if (s.year < yearRange[0] || s.year > yearRange[1]) return false; if (s.year === undefined || s.year < yearRange[0] || s.year > yearRange[1]) return false;
} }
return true; return true;
@@ -316,11 +316,13 @@ export default function Favorites() {
{/* Title Row with showing X of Y indicator */} {/* Title Row with showing X of Y indicator */}
<div style={{ display: 'flex', alignItems: 'center', gap: '1rem', flexWrap: 'wrap' }}> <div style={{ display: 'flex', alignItems: 'center', gap: '1rem', flexWrap: 'wrap' }}>
<h2 className="section-title" style={{ margin: 0 }}>{t('favorites.songs')}</h2> <h2 className="section-title" style={{ margin: 0 }}>{t('favorites.songs')}</h2>
<span style={{ fontSize: '0.8rem', color: 'var(--muted)', fontStyle: 'italic' }}> {(selectedArtist || selectedGenres.length > 0 || yearRange[0] !== MIN_YEAR || yearRange[1] !== CURRENT_YEAR) && (
{selectedArtist <span style={{ fontSize: '0.8rem', color: 'var(--text-muted)', fontStyle: 'italic' }}>
? t('favorites.showingFiltered', { filtered: visibleSongs.length, total: songs.filter(s => starredOverrides[s.id] !== false).length, artist: selectedArtist }) {selectedArtist
: t('favorites.showingCount', { filtered: visibleSongs.length, total: songs.filter(s => starredOverrides[s.id] !== false).length })} ? t('favorites.showingFiltered', { filtered: visibleSongs.length, total: songs.filter(s => starredOverrides[s.id] !== false).length, artist: selectedArtist })
</span> : t('favorites.showingCount', { filtered: visibleSongs.length, total: songs.filter(s => starredOverrides[s.id] !== false).length })}
</span>
)}
</div> </div>
{/* Action Buttons */} {/* Action Buttons */}
src/styles/theme.css
+6
View File
@@ -3711,6 +3711,12 @@ body.psy-dragging * {
transform: translateY(0); transform: translateY(0);
} }
.btn-sm {
padding: 3px 8px;
font-size: 12px;
gap: var(--space-1);
}
/* ─── Input ─── */ /* ─── Input ─── */
.input { .input {
width: 100%; width: 100%;