itlxrd/psysonic
1
0
Fork 0
mirror of https://github.com/kilyabin/psysonic.git synced 2026-07-22 06:25:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(themes): serve the Theme Store from GitHub raw, not jsDelivr (#1051)

Browse Source 
Theme assets (registry.json, theme CSS, thumbnails) were served from the
jsDelivr CDN's mutable @main edge, which caches up to 12h. The registry is
purged on every themes push so updates were offered promptly — but the theme
CSS could still be served stale, so an update stored pre-update CSS under the
new version label and no further update was offered to correct it (a freshly
animated theme would install without its @keyframes).

Fetch everything from GitHub raw (permissive CORS, ~5-min server cache), which
is always current. jsDelivr is dropped entirely: our request volume does not
need a CDN, and its only real upside here (high-traffic edge serving) does not
apply, while its staleness actively caused the bug.

Rename cdnUrl -> assetUrl to reflect the source.
This commit is contained in:
Psychotoxical
2026-06-09 20:24:43 +02:00
committed by GitHub
parent 316c99ba07
commit 155ef88cc0
13 changed files with 47 additions and 63 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/components/settings/ThemeStoreSection.tsx
+7 -7
View File
@@ -10,7 +10,7 @@ import { formatRelativeTime } from '../../utils/format/relativeTime';
import { useThemeStore } from '../../store/themeStore';
import { useInstalledThemesStore, type InstalledTheme } from '../../store/installedThemesStore';
import {
cdnUrl,
assetUrl,
fetchRegistry,
type RegistryTheme,
} from '../../utils/themes/themeRegistry';
@@ -41,7 +41,7 @@ function pageItemsList(current: number, total: number): (number | 'gap')[] {
}
/**
* The community Theme Store: browse the jsDelivr-hosted registry, filter by name
* The community Theme Store: browse the GitHub-hosted registry, filter by name
* and light/dark, install (fetch + persist + runtime inject), apply, update and
* uninstall. Built-in themes are not in the registry, so they never appear here.
*/
@@ -82,12 +82,12 @@ export function ThemeStoreSection() {
.finally(() => { setLoading(false); setRefreshing(false); });
};
// Thumbnails live at a stable CDN path, so the webview caches them hard
// (jsDelivr sends max-age 7d). Tie a cache-buster to the registry's
// generatedAt — it changes on every themes push — so refreshed thumbnails
// show up after a registry refresh instead of being stuck on the old image.
// GitHub raw caches thumbnails only briefly, but the webview can still hold an
// old copy; tie a cache-buster to the registry's generatedAt — it changes on
// every themes push — so refreshed thumbnails show up after a registry refresh
// instead of being stuck on the old image.
const thumbUrl = (rel: string) =>
generatedAt ? `${cdnUrl(rel)}?v=${encodeURIComponent(generatedAt)}` : cdnUrl(rel);
generatedAt ? `${assetUrl(rel)}?v=${encodeURIComponent(generatedAt)}` : assetUrl(rel);
useEffect(() => { load(false); }, []);