mirror of
https://github.com/Psychotoxical/psysonic.git
synced 2026-07-21 23:05:46 +00:00
b68bddd034
Three file-private helpers + their shared module-scoped track id move into src/store/playbackUrlRouting.ts: recordEnginePlayUrl, playbackSourceHintForResolvedUrl, shouldRebindPlaybackToHotCache. The `lastOpenedWithHttpTrackId` mutable goes with them — only those three read it. No external callers, no re-exports needed. Adds 12 focused tests covering the source-kind classifier (stream / hot / offline), the rebind decision across stream:-prefix forms, the empty-serverId / un-recorded edge cases, and the test-only reset helper. playerStore 3490 → 3470 LOC.
112 lines
4.2 KiB
TypeScript
112 lines
4.2 KiB
TypeScript
/**
|
|
* Playback-URL routing characterization. The non-trivial behaviour is
|
|
* (a) the module-scoped `lastOpenedWithHttpTrackId` only persists for HTTP
|
|
* URLs (offline / hot-cache plays clear it), (b) the rebind check matches
|
|
* across the `stream:` / bare id forms, and (c) the source-kind classifier
|
|
* picks 'offline' vs 'hot' only when the offline store actually has a local
|
|
* URL for the track.
|
|
*/
|
|
import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
|
|
|
|
const { offlineStoreState } = vi.hoisted(() => ({
|
|
offlineStoreState: { localUrlByKey: new Map<string, string>() },
|
|
}));
|
|
|
|
vi.mock('./offlineStore', () => ({
|
|
useOfflineStore: {
|
|
getState: () => ({
|
|
getLocalUrl: (trackId: string, serverId: string) =>
|
|
offlineStoreState.localUrlByKey.get(`${serverId}:${trackId}`) ?? null,
|
|
}),
|
|
},
|
|
}));
|
|
|
|
vi.mock('../utils/resolvePlaybackUrl', () => ({
|
|
resolvePlaybackUrl: vi.fn((trackId: string, serverId: string) => {
|
|
if (offlineStoreState.localUrlByKey.has(`${serverId}:${trackId}`)) {
|
|
return `psysonic-local://${serverId}/${trackId}`;
|
|
}
|
|
return `https://mock/${serverId}/${trackId}`;
|
|
}),
|
|
}));
|
|
|
|
import {
|
|
_resetPlaybackUrlRoutingForTest,
|
|
playbackSourceHintForResolvedUrl,
|
|
recordEnginePlayUrl,
|
|
shouldRebindPlaybackToHotCache,
|
|
} from './playbackUrlRouting';
|
|
|
|
beforeEach(() => {
|
|
offlineStoreState.localUrlByKey.clear();
|
|
});
|
|
|
|
afterEach(() => {
|
|
_resetPlaybackUrlRoutingForTest();
|
|
});
|
|
|
|
describe('playbackSourceHintForResolvedUrl', () => {
|
|
it("classifies non-local URLs as 'stream'", () => {
|
|
expect(playbackSourceHintForResolvedUrl('t1', 'srv', 'https://mock/srv/t1')).toBe('stream');
|
|
});
|
|
|
|
it("classifies psysonic-local:// as 'offline' when the offline store has the file", () => {
|
|
offlineStoreState.localUrlByKey.set('srv:t1', 'file:///cache/t1.mp3');
|
|
expect(playbackSourceHintForResolvedUrl('t1', 'srv', 'psysonic-local://srv/t1')).toBe('offline');
|
|
});
|
|
|
|
it("classifies psysonic-local:// as 'hot' when no offline copy exists", () => {
|
|
expect(playbackSourceHintForResolvedUrl('t1', 'srv', 'psysonic-local://srv/t1')).toBe('hot');
|
|
});
|
|
});
|
|
|
|
describe('recordEnginePlayUrl + shouldRebindPlaybackToHotCache', () => {
|
|
it('records HTTP URLs and rebinds when the resolved URL later goes local', () => {
|
|
recordEnginePlayUrl('t1', 'https://mock/srv/t1');
|
|
offlineStoreState.localUrlByKey.set('srv:t1', 'file:///cache/t1.mp3');
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(true);
|
|
});
|
|
|
|
it('does not rebind when the recorded URL was already local', () => {
|
|
recordEnginePlayUrl('t1', 'psysonic-local://srv/t1');
|
|
offlineStoreState.localUrlByKey.set('srv:t1', 'file:///cache/t1.mp3');
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(false);
|
|
});
|
|
|
|
it('matches the recorded id across the stream: prefix', () => {
|
|
recordEnginePlayUrl('stream:t1', 'https://mock/srv/stream:t1');
|
|
offlineStoreState.localUrlByKey.set('srv:t1', 'file:///cache/t1.mp3');
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(true);
|
|
});
|
|
|
|
it('returns false for a different track id', () => {
|
|
recordEnginePlayUrl('t1', 'https://mock/srv/t1');
|
|
offlineStoreState.localUrlByKey.set('srv:t2', 'file:///cache/t2.mp3');
|
|
expect(shouldRebindPlaybackToHotCache('t2', 'srv')).toBe(false);
|
|
});
|
|
|
|
it('returns false when serverId is empty', () => {
|
|
recordEnginePlayUrl('t1', 'https://mock/srv/t1');
|
|
expect(shouldRebindPlaybackToHotCache('t1', '')).toBe(false);
|
|
});
|
|
|
|
it('returns false when nothing has been recorded yet', () => {
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(false);
|
|
});
|
|
|
|
it('returns false when the resolved URL is still HTTP (no hot-cache entry)', () => {
|
|
recordEnginePlayUrl('t1', 'https://mock/srv/t1');
|
|
// No entry in offlineStoreState → resolvePlaybackUrl mock returns https://...
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('_resetPlaybackUrlRoutingForTest', () => {
|
|
it('clears the recorded id', () => {
|
|
recordEnginePlayUrl('t1', 'https://mock/srv/t1');
|
|
_resetPlaybackUrlRoutingForTest();
|
|
offlineStoreState.localUrlByKey.set('srv:t1', 'file:///cache/t1.mp3');
|
|
expect(shouldRebindPlaybackToHotCache('t1', 'srv')).toBe(false);
|
|
});
|
|
});
|