Files
Psychotoxical-psysonic/src/store/albumBrowseSessionStore.test.ts
T
cucadmuh 4ac373a65b feat(search): scoped live search on browse pages (#938)
* feat(artists): scoped live search badge replaces page filter

Move Artists browse text search into the header Live Search with a page
scope badge (Users icon), field-local undo, and double-click/backspace
to clear scope. Block the live-search dropdown while scoped so results
only filter the Artists grid; mobile overlay follows the same rules.

* fix(artists): plain grid for scoped search fixes broken card layout

Route the browse grid through VirtualCardGrid, switch to non-virtual CSS
grid when live search filters the catalog, reset scroll on filter changes,
and skip content-visibility on plain tiles to avoid blank/black cards.

* fix(search): scope badge double-Backspace and single clear control

Require two Backspaces on an empty scoped field after prior text input;
one Backspace still clears the badge when the field was never filled.
Move live-search clear/advanced controls inside the field pill, drop the
extra outer clear button, and use type=text to avoid native search clears.

* fix(search): drop duplicate outer live-search clear button

Keep the native in-field clear on type=search and the original pill layout;
remove only the extra × control outside the search border. Reset dropdown
state when the query is cleared via the native control.

* refactor(search): generic scoped browse query helper, drop dead code

Rename artistsBrowseSearchQuery to scopedBrowseSearchQuery with an
expectedScope argument; wire Artists via useScopedBrowseSearchQuery.
Remove unused liveSearchScoped dropdown helper (scoped mode blocks it).

* feat(search): ghost scope badge and single-click badge remove

After clearing the artists scope on /artists, show a faded ghost chip to
restore page-only search while keeping the global search placeholder.
Active badge removes on one click; tooltips and styles updated.

* feat(search): scoped live search for All Albums and New Releases

Wire albums and newReleases scope badges with debounced album title search
(local index title-only FTS + filtered search3). Plain grid, scroll reset,
and session query restore on album grid browse pages.

* fix(browse): preserve scroll restore after album/artist detail back

Only reset in-page scroll when filter resetKey changes, not when
isScrollRestorePending clears after session restore.

* feat(search): scoped live search for Tracks browse

Wire /tracks to header live search with wide title/artist/album FTS,
hide hero and discovery rails while search is active, and remove the
inline search field from the browse list.

* fix(search): clear header query when leaving scoped browse pages

Prevent global live search from firing on album/detail routes after a
scoped browse query; browse session stashes still restore on back.

* fix(tracks): restore scroll after back from detail during scoped search

Hold stashed song results across fetchSongPage churn, defer leave-stash
teardown past AppShell scroll reset, restore tracks scroll after the list
is ready, and save scroll snapshot when opening artist from song context menu.

* fix(tracks): hide discovery headings during scoped search

Hide the page subtitle and "Browse all tracks" section title when
tracks search is active, matching hero/rails chrome behavior.

* feat(search): scoped live search for Composers browse

Wire /composers to header live search with composers scope badge,
session stash, scroll restore, and plain grid/list during text filter.
Remove the in-page filter input; add i18n and navigation helpers.

* docs: CHANGELOG and credits for scoped browse live search (PR #938)
2026-06-01 13:04:36 +03:00

159 lines
5.8 KiB
TypeScript

import { describe, expect, it, beforeEach } from 'vitest';
import type { SubsonicAlbum } from '../api/subsonicTypes';
import {
DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
DEFAULT_ALBUM_BROWSE_SORT,
albumBrowseSortForServer,
albumBrowseSurfaceForPath,
clearGenreDetailReturnStash,
isAlbumDetailPath,
isAlbumsBrowsePath,
isNewReleasesBrowsePath,
isGenreDetailPath,
genreDetailGenreFromPath,
peekAlbumBrowseScrollRestore,
peekGenreDetailReturnStash,
peekGenreDetailScrollRestore,
stashGenreDetailReturnFilters,
useAlbumBrowseSessionStore,
} from './albumBrowseSessionStore';
describe('albumBrowseSessionStore', () => {
beforeEach(() => {
useAlbumBrowseSessionStore.setState({ sortByServer: {}, returnStashByKey: {} });
});
it('keeps sort per server for the session', () => {
const { setSort } = useAlbumBrowseSessionStore.getState();
setSort('srv-a', 'alphabeticalByArtist');
setSort('srv-b', 'alphabeticalByName');
const { sortByServer } = useAlbumBrowseSessionStore.getState();
expect(albumBrowseSortForServer(sortByServer, 'srv-a')).toBe('alphabeticalByArtist');
expect(albumBrowseSortForServer(sortByServer, 'srv-b')).toBe('alphabeticalByName');
});
it('stashes and peeks return filters with scroll snapshot per surface', () => {
const { stashReturnFilters, peekReturnStash } = useAlbumBrowseSessionStore.getState();
stashReturnFilters('srv-a', 'albums', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
selectedGenres: ['Rock'],
yearFrom: '1990',
yearTo: '2000',
starredOnly: true,
scrollTop: 840,
displayCount: 120,
});
expect(peekReturnStash('srv-a', 'albums')).toEqual({
selectedGenres: ['Rock'],
yearFrom: '1990',
yearTo: '2000',
compFilter: 'all',
starredOnly: true,
losslessOnly: false,
scrollTop: 840,
displayCount: 120,
});
expect(peekReturnStash('srv-a', 'new-releases')).toBeNull();
});
it('peeks scroll restore target for a surface', () => {
const { stashReturnFilters } = useAlbumBrowseSessionStore.getState();
stashReturnFilters('srv-a', 'new-releases', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
scrollTop: 420,
displayCount: 180,
});
expect(peekAlbumBrowseScrollRestore('srv-a', 'new-releases')).toEqual({
scrollTop: 420,
displayCount: 180,
});
expect(peekAlbumBrowseScrollRestore('srv-b', 'new-releases')).toBeNull();
});
it('stashes cached album rows for grid surfaces', () => {
const albums = [{ id: 'a1', name: 'A', artist: 'X', artistId: 'x' }] as SubsonicAlbum[];
const { stashReturnFilters, peekReturnStash } = useAlbumBrowseSessionStore.getState();
stashReturnFilters('srv-a', 'random-albums', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
selectedGenres: ['Jazz'],
albums,
hasMore: false,
scrollTop: 100,
displayCount: 1,
});
expect(peekReturnStash('srv-a', 'random-albums')?.albums).toEqual(albums);
});
it('clears return stash for a surface only', () => {
const { stashReturnFilters, clearReturnStash, peekReturnStash } = useAlbumBrowseSessionStore.getState();
stashReturnFilters('srv-a', 'albums', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
selectedGenres: ['Jazz'],
});
stashReturnFilters('srv-a', 'new-releases', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
selectedGenres: ['Rock'],
});
clearReturnStash('srv-a', 'albums');
expect(peekReturnStash('srv-a', 'albums')).toBeNull();
expect(peekReturnStash('srv-a', 'new-releases')?.selectedGenres).toEqual(['Rock']);
});
it('defaults sort when server has no entry', () => {
const { sortByServer } = useAlbumBrowseSessionStore.getState();
expect(albumBrowseSortForServer(sortByServer, 'unknown')).toBe(DEFAULT_ALBUM_BROWSE_SORT);
});
it('stashes genre detail leave snapshot separately from album grid surfaces', () => {
stashGenreDetailReturnFilters('srv-a', 'Rock', {
...DEFAULT_ALBUM_BROWSE_RETURN_FILTERS,
selectedGenres: ['Rock'],
scrollTop: 640,
displayCount: 90,
});
expect(peekGenreDetailReturnStash('srv-a', 'Rock')?.scrollTop).toBe(640);
expect(peekGenreDetailScrollRestore('srv-a', 'Rock')).toEqual({
scrollTop: 640,
displayCount: 90,
});
clearGenreDetailReturnStash('srv-a', 'Rock');
expect(peekGenreDetailReturnStash('srv-a', 'Rock')).toBeNull();
});
});
describe('isAlbumDetailPath', () => {
it('matches album detail routes only', () => {
expect(isAlbumDetailPath('/album/abc')).toBe(true);
expect(isAlbumDetailPath('/album/abc/')).toBe(true);
expect(isAlbumDetailPath('/albums')).toBe(false);
expect(isAlbumDetailPath('/artist/abc')).toBe(false);
expect(isAlbumDetailPath('/album/abc/tracks')).toBe(false);
});
});
describe('isGenreDetailPath', () => {
it('matches single genre detail routes only', () => {
expect(isGenreDetailPath('/genres/Rock')).toBe(true);
expect(isGenreDetailPath('/genres/Rock%20%26%20Roll')).toBe(true);
expect(isGenreDetailPath('/genres')).toBe(false);
expect(isGenreDetailPath('/genres/Rock/albums')).toBe(false);
expect(genreDetailGenreFromPath('/genres/Rock%20%26%20Roll')).toBe('Rock & Roll');
});
});
describe('albumBrowseSurfaceForPath', () => {
it('maps album grid browse routes', () => {
expect(albumBrowseSurfaceForPath('/albums')).toBe('albums');
expect(isAlbumsBrowsePath('/albums')).toBe(true);
expect(isAlbumsBrowsePath('/albums/')).toBe(true);
expect(isAlbumsBrowsePath('/new-releases')).toBe(false);
expect(isNewReleasesBrowsePath('/new-releases')).toBe(true);
expect(isNewReleasesBrowsePath('/new-releases/')).toBe(true);
expect(albumBrowseSurfaceForPath('/new-releases')).toBe('new-releases');
expect(albumBrowseSurfaceForPath('/random/albums')).toBe('random-albums');
expect(albumBrowseSurfaceForPath('/artists')).toBeNull();
});
});