8 Commits

Author	SHA1	Message	Date
Psychotoxical	86ae462ad6	feat(hero): album-artist backdrop, configurable per-surface sources, and prefetch (#1193) ... * refactor(cover): extract shared pickArtistBackdrop priority helper * feat(hero): show the album artist's fanart as the mainstage hero backdrop * feat(settings): configurable per-surface artist backdrop sources Each artist-backdrop surface (mainstage hero, artist-detail header, fullscreen player) gets its own enable toggle + an ordered, individually-toggleable source list, configured under External Artwork Scraper on the Integrations tab (shown when the scraper is on). Reorder via the shared useDragSource/psy-drop drag infra plus keyboard-accessible up/down buttons; each source has its own on/off. The shared chooser pickArtistBackdrop is generalised to resolveBackdrop + backdropFromConfig (ordered candidate list with the same pending/miss/centred-framing semantics), so all three surfaces resolve identically. themeStore persist bumped to v2; defaults reproduce today's order, so there is no visible change without user action. Gating decoupled: the three surfaces are gated solely by their own per-surface flag, not by enableCoverArtBackground (which stays scoped to album/playlist-header cover blur). Reorder maths extracted to a pure, unit-tested module. i18n en + de (other locales TODO before PR). Tests: resolver (10) + reorder (7). * feat(cover): make the ensure queue surface-aware for artist backdrops coverEnsureQueued now threads optional CoverEnsureOpts through to the Rust ensure and weaves the external surface into the in-flight key, so the fanart and banner surfaces of one artist no longer collide on one download chain. External surfaces also bypass the disk-src memory short-circuit (their {tier}-{surface}.webp never seeds those caches, and the canonical cover must not read as a hit). New thin ensureArtistBackdropQueued wrapper. Backward-compatible: plain covers append nothing to the key; the 5 queue tests stay green. * fix(cover): reset the artist external-image hook synchronously on artist change The hook reset src in an effect (one render late), so for the render between an artist change and that effect a consumer read the *previous* artist's resolved image. The mainstage hero then froze (and cached into per-album memory) a neighbouring slide's banner. Reset synchronously via the React adjust-state-on-prop-change pattern. Also removes brief stale-image flashes on the artist-detail header and fullscreen player. * feat(hero): prefetch artist backdrops and show-ready-now / upgrade-on-re-entry warmHomeMainstageCovers now prefetches each hero slide's artist backdrop (banner/fanart) at static slide-index priorities (idx1=high, idx0=low, rest=middle; no reprioritise on navigation), then predecodes every slide already on disk. useHeroBackdrop shows the best source ready at entry (Navidrome on a cold first visit, the prefetched/cached external one on re-entry) and freezes that source choice for the visit so nothing swaps mid-dwell; the url is derived live from the frozen choice, with a per-album disk memory for re-entry. HeroBg now crossfades only after the image bytes load (onLoad/complete gate + onError + fallback). Inert when the scraper is off. Tests: per-album memory (5). * docs(changelog): configurable artist backdrops + mainstage hero (PR #1193) CHANGELOG Added entry, settingsCredits line, and the What's New Artist-artwork highlight extended to cover the mainstage hero backdrop and per-place source config. * docs(changelog): fold mainstage hero + per-place backdrops into the fanart entry (PR #1193) Merge the configurable-backdrops changes into the existing 'Artist artwork from fanart.tv' block (now PR #1137 and #1193) instead of a separate entry. * fix(hero): revert HeroBg load-gate that blanked the app (Maximum update depth) The byte-load gate I added drove the crossfade reveal from an inline img ref + onLoad that re-fires on every render and scheduled a setTimeout each call; frequent re-renders (playback, marquee) stacked nested updates until React threw 'Maximum update depth exceeded' — and with no ErrorBoundary the whole window blanked. Reverted HeroBg to the proven timer-based crossfade. The hero only ever receives ready/predecoded urls, so the gate was cosmetic. * fix(hero): gate the HeroBg crossfade on image load to stop the slide flicker The bare 20 ms reveal faded a layer in before its bytes were ready (notably the Navidrome raw url), so a slide change flickered. Now an Image() preloader in the [url] effect reveals the layer on load (or a cached complete check), with a fallback. Everything is scheduled once per url — no per-render <img> ref/onLoad — so unlike the reverted gate it can't stack nested updates. * feat(i18n): translate the backdrop-source settings into the remaining 10 locales Adds the per-surface backdrop config strings (es, fr, nl, zh, nb, ru, ro, ja, hu, pl) and extends externalArtworkDesc to mention the mainstage hero where the key exists (ja has none → falls back to en).	2026-06-27 00:42:32 +02:00
Psychotoxical	b6ac879b14	refactor(settings): SettingsSubCard primitives across all of Settings (#1182) ... * feat(settings): add SettingsSubCard primitives for sub-section controls Reusable wrappers (SettingsSubCard / SettingsField / SettingsRow / SettingsValue / SettingsCallout) that encapsulate the settings-norm-* sub-card styles. Per-mode and detail controls inside a settings section should use these instead of hand-rolling the box with inline padding or one-off classes — the lack of a shared primitive is what let recent additions drift off the pattern. * refactor(settings): move the Audio tab onto the SettingsSubCard primitives Normalization, Track transitions and Hi-Res now build their sub-cards from the shared primitives instead of raw settings-norm-* markup. Track Previews, which rendered its sub-options bare with inline styles and dividers, now uses the same sub-card so the whole Audio tab is consistent. Behaviour and styling unchanged; Track Previews' start/duration become labelled slider rows like Normalization. * refactor(settings): move the remaining tabs onto SettingsSubCard Apply the shared sub-card primitives across the rest of Settings so every tab matches the Audio-tab reference look: - Appearance: grid columns, window buttons, UI scale, font, seekbar - Library: random-mix blacklist, rating-filter detail - Input: in-app + global keybind lists - Integrations: Discord templates, external-artwork BYOK - System: language, Linux Wayland text render, clock format, logging - Storage: media dir, hot-cache detail, downloads folder - Backup: mode picker + per-mode export/import Detail/per-mode controls now sit in the bordered sub-card; toggle groups stay on SettingsToggle. Behaviour unchanged. * refactor(settings): box the data-heavy and shared sections in SettingsSubCard Bring the previously-skipped 'borderline' sections onto the sub-card too: - Playback speed: wrap the settings-mode controls in a sub-card; the compact player-popup path is left untouched (shares the component via the compact flag) - Theme scheduler: mode picker + theme/time selects move into the sub-card - Cover-cache + analytics strategy: the per-server tables sit in a sub-card Behaviour unchanged; the table layouts and the playback-rate-* internals stay as they are, only the surrounding sub-card is added for visual consistency.	2026-06-24 23:13:10 +02:00
Psychotoxical	b950d4704b	feat(cover): artist artwork from fanart.tv (off by default) (#1137) ... * feat(cover): add artist_artwork_lookup table + accessors Image-scraper P0 (design-review §12): additive library-SQLite migration 013 plus get/upsert/clear-per-server accessors for the external artist-artwork lookup (fanart.tv). Render never reads it; the on-demand cover ensure path and the mbid_ambiguous 24h negative cache use it. server_id = serverIndexKey. * feat(cover): add fanart.tv + getArtistInfo2 provider layer Image-scraper P0 (§7/§19/§23): new cover_cache/external.rs — Rust-side getArtistInfo2 tag-MBID resolution plus fanart.tv v3/music URL + first artistbackground fetch (BYOK client_key sent in addition to the project api_key per fanart.tv ToS, §22). Extract a shared build_subsonic_url helper in fetch.rs (cover URL behaviour unchanged). Add a dedicated low-concurrency fanart_http_sem so external HTTP never starves Navidrome (§26). URL builders unit-tested; wired into ensure_inner next. * feat(cover): wire fanart.tv external branch into ensure_inner Image-scraper P0 (§16): on-demand artist `fanart` ensures try fanart.tv before the Navidrome fallback. MBID resolved Rust-side via getArtistInfo2 (§23, tag MBID); on a miss it falls through WITHOUT a .fetch-failed marker so Navidrome stays the display fallback (§28). External tiers are written as {tier}-fanart.webp in the same entity dir (same cacheKind, §16) — 2000 + 512 (matryoshka §17); peek prefers them for the fanart surface. Dedicated low-concurrency fanart lane (§26); .miss-fanart ~30min negative marker. Additive IPC args (externalArtworkEnabled, surfaceKind), off by default and gated by PSYSONIC_FANART_KEY — inert until a render surface opts in (P1). Quality gate (§11), name->MusicBrainz (§19), and lookup-table writes are P1. * feat(cover): fanart-first peek for the fanart surface Image-scraper P0: for an artist `fanart` ensure, the early peek serves only the external {tier}-fanart.webp tiers; if none exist yet it returns None so ensure runs the external branch (fetch fanart) instead of short-circuiting on a cached Navidrome tier. Realises "fanart prioritised" (§18) for the opt-in surface; Navidrome stays the fallback inside the branch's miss path. * chore(cover): dev-only artist-fanart spike helper DEV-only window.psyFanartSpike(name) — resolves an artist by name and fires the real cover_cache_ensure with externalArtworkEnabled+surfaceKind=fanart to verify the P0 pipeline against a live server (with PSYSONIC_FANART_KEY set). Not wired in production. * feat(cover): §11 quality gate for the fanart surface Before an external fanart fetch, check whether a Navidrome tier already on disk is an HQ ~16:9 image (width >= 1280, aspect 1.6-2.0) and skip the fetch if so — square artist portraits never satisfy it, so the common case still fetches. Reads tier dimensions only (no full decode). Rust consts per the design review. Unit-tested predicate. * feat(cover): persist fanart resolution in artist_artwork_lookup (§12) Wire the lookup table as both the MBID resolution cache and the negative cache: a cached MBID skips the getArtistInfo2 round-trip; no_mbid/mbid_ambiguous back off 24h and miss 30min from updated_at before re-querying. Writes hit/miss/no_mbid with mbid/mbid_source/provider; transient network errors are not cached. All store reads/writes run off the async executor via spawn_blocking and no-op before login. Store reached via app.try_state::<LibraryRuntime>(). * feat(cover): compile-time fanart key fallback + album/name IPC args A runtime PSYSONIC_FANART_KEY still wins (dev), else the key baked in at build time via option_env! (release). Add additive artistName/albumTitle ensure args as context for the §19 name->MusicBrainz fallback (inert until the render passes them). Library backfill passes None. * feat(settings): add External Artwork Scraper toggle under Integrations Master toggle (themeStore, off by default per §20) in a new Integrations subsection, alongside the other opt-in third-party categories. Contacts fanart.tv only when enabled. i18n across all 9 locales. * feat(cover): wire fanart background into the fullscreen player (§28) New useArtistFanart hook resolves a fanart.tv 16:9 background via a dedicated cover_cache_ensure (surfaceKind=fanart) — it bypasses the shared peek/disk-src cache (the {tier}-fanart.webp surface is keyed differently) and reuses coverDiskUrl for the asset URL. Fullscreen background priority is now fanart -> Navidrome artist image (cover pipeline) -> album cover; the live useFsArtistPortrait probe is deleted (§28). Additive ensure opts (surfaceKind/artistName/albumTitle); externalArtworkEnabled is derived in ensureArgsFromRef from the master toggle and restricted to the artist fanart surface, so plain cover ensures are unaffected. * feat(cover): generalize external surface to fanart + banner (§13) surfaceKind='banner' fetches the fanart.tv musicbanner array -> {tier}-banner.webp in the same entity dir; fanart stays the 16:9 artistbackground. The ensure branch, peek, lookup rows (per-surface surface_kind), miss marker (.miss-<surface>) and tier suffix are all surface-parameterised. The §11 quality gate stays fanart-only (the banner strip has its own aspect). Unit test for the surface->fanart JSON key map. * feat(artist): fanart banner on the artist-detail header (§13, Option B) The artist-detail header gets an album-detail-style background layer: fanart.tv banner (musicbanner) -> the 16:9 fanart background cropped to the strip -> empty. Both via a shared useArtistExternalImage hook (useArtistBanner / useArtistFanart); each fetches on demand and shares the Rust cache, so the header and the fullscreen player warm each other's images. The header is its own stacking context (isolation) so a z-index:-1 banner clips behind the avatar + meta with no content wrapper; the album-style framing (padding/radius/clip) is applied only when a banner is shown, so the off-by-default case stays pixel-identical. * refactor(artist): reuse album-detail header structure for the fanart banner The artist-detail header now uses the same album-detail-* container classes as AlbumHeader (header/bg/overlay/content/hero) with the fanart banner as the background; the Back button moves inside the header. A surgical `artist-detail-bleed` cancels the artist page's .content-body padding so the banner is full-bleed to the container edges, matching the album header exactly instead of the earlier inset card. Reverts the experimental artist-specific bg CSS. * feat(cover): drop artist_artwork_lookup rows on clear-cover-cache (§12/B.4) cover_cache_clear_server already removed the server's whole cover dir (so the {tier}-fanart.webp / -banner.webp tiers + .miss-* markers go with it); also clear the artist_artwork_lookup rows for that server (off-thread) so no stale resolution state lingers. Automatic toggle-off purge deferred — turning the toggle off already hides external artwork (render is gated), and explicit cache-clear now cleans external state too. * feat(cover): name->MusicBrainz album-confirmed MBID resolution (§19) When getArtistInfo2 has no tag MBID and the ensure carries the artist name + an album in context (fullscreen), one MusicBrainz release-search query resolves the artist MBID: the primary artist across score>=90 releases wins, conflicting ids -> mbid_ambiguous (24h backoff), none -> no_mbid. Sends the required User-Agent; a single-permit musicbrainz_sem + >=1s spacing holds us under MB's rate limit. mbid_source=musicbrainz persisted. Banner surface (no album context) correctly skips this. Pure classify/escape helpers unit-tested. * fix(cover): enable banner surface in ensureArgsFromRef externalEnsureFields only set externalArtworkEnabled for surfaceKind 'fanart', so the 'banner' surface never fired — the artist-detail header always fell back to the fanart image instead of the fanart.tv musicbanner. Both external artist surfaces (fanart/banner) now enable the external branch. * feat(settings): optional BYOK personal fanart key field Add an optional personal fanart.tv API key field to the External Artwork Scraper block (shown when the toggle is on): a masked input, a saved/in-use status line, and the simple note that it is sent in addition to the app key. Persisted in themeStore and plumbed through cover_cache_ensure (externalArtworkByok); Rust prefers the settings key, falling back to the PSYSONIC_FANART_CLIENT_KEY dev env. i18n x9. * fix(cover): resolve artist-page fanart image collision on navigation The artist-detail header keyed its fanart/banner hooks on the route `id`, which flips immediately on navigation while `artist`/`albums` refetch a beat later. The mismatched ensure wrote the previous artist's image under the new artist's id (e.g. Sepultura's image under Lordi's id). - key on the loaded `artist.id`, not the route `id`, so id/name/album always describe the same artist - pick the §19 album context from an album that actually belongs to this artist (`albums.find(a => a.artistId === artist.id)`), so a stale album can't run a mismatched name→MusicBrainz query or cache a wrong `no_mbid` - reset `src` on every input change in `useArtistExternalImage` so a previous artist's image never lingers while the new one resolves * fix(cover): strip trailing album qualifier before MusicBrainz lookup Library titles like "Show No Mercy (2004 Remastered)" or "Album [Deluxe Edition]" failed the §19 MusicBrainz release query, blocking name-confirmed MBID resolution. `normalize_album_for_mb` strips a single trailing parenthetical/bracketed qualifier; leading qualifiers (e.g. "(What's the Story) Morning Glory?") are left intact. Unit-tested. * fix(cover): don't cache no_mbid when album context is unavailable The banner ensure could fire before the artist's albums loaded, with no album in context. The old code cached `no_mbid` there and the 24h backoff then blocked the later ensure that arrived *with* album context. Could-not-attempt is not tried-and-failed: the no-album branch now returns without persisting. * fix(cover): don't emit tier-ready for external fanart/banner surfaces `try_external_fanart` emitted `cover:tier-ready` with the `{tier}-{surface}.webp` path. That event is keyed by the canonical cover key (cacheKind/cacheEntityId/ tier, no surface), so the frontend `useCoverArtBridge` listener seeded the Navidrome artist cover's disk-src cache with the external image — leaking fanart/banner into the plain artist cover (avatar, fullscreen "navidrome-artist" fallback) even with the scraper toggled off. Remove the emit: the fanart/banner hooks read the path from the `cover_cache_ensure` return value, so no event is needed. (No disk-level overwrite — the suffixed files are never matched by `tier_exists`; this was frontend disk-src-cache cross-contamination.) * fix(cover): wait for the final external background before showing it, with fade-in The fullscreen player and artist-detail header flashed several backgrounds in sequence while the fanart resolved (upscaled album cover → Navidrome artist image → fanart), and the artist header could show the fanart first and then swap to the banner. - the album cover is no longer a background source — it only feeds the foreground thumbnail - the external-artwork hooks return `{ src, pending }` so callers can tell "still resolving" (hold back) from "resolved, no image" (fall back now) - fullscreen background: scraper on → fanart, empty while it resolves, Navidrome artist image only on a confirmed miss; scraper off → Navidrome artist image - artist header: the banner is preferred — nothing shows while it resolves (no fanart flash), fanart is the fallback only once the banner misses - both backgrounds preload the chosen image and fade it in (`onLoad` plus a `ref` `complete` check so an already-cached image, whose load event can fire before React attaches the handler, still appears). The header fade is a scoped inline opacity so the shared `album-detail-bg` class is untouched. * ci(release): pass PSYSONIC_FANART_KEY into the macOS + Linux builds * refactor(cover): extract external-artwork ensure into its own module Pure code move: the on-demand fanart/banner fetch, the quality gate, the surface-aware peek and the lookup-table cache move from cover_cache/mod.rs into cover_cache/external_ensure.rs. Behaviour unchanged; mod.rs 1877 -> 1488. * chore(cover): remove dev-only fanart spike helper The real render wiring now exercises the external ensure branch, so the dev-only window.psyFanartSpike helper is redundant. * feat(cover): purge external artwork on opt-out (B3) New cover_cache_purge_external command: when the External Artwork toggle is turned off, drop every fetched {tier}-{provider}.webp, .miss-{provider} marker and artist_artwork_lookup row across all configured servers, leaving the canonical Navidrome covers intact. Opting out now removes the third-party-sourced data instead of just hiding it (design-review §9/§12/B.4). * docs: changelog, credits and what's new for artist fanart (PR #1137)	2026-06-20 21:04:21 +02:00
Psychotoxical	d50c9c444d	refactor(settings): reusable SettingsGroup/SettingsToggle + boxed sections across tabs (#1126) ... * refactor(settings): extract reusable SettingsGroup component Pull the boxed sub-section pattern (bordered panel + accent uppercase header) introduced for the Audio tab into a reusable <SettingsGroup title desc> component, and migrate NormalizationBlock and PlaybackBehaviorBlock onto it. No visual change. * feat(settings): box the System behavior section into groups Split the System -> App Behavior card (which bundled tray toggles, Linux rendering tweaks and the clock format) into titled SettingsGroup panels (Tray / Linux rendering / Clock) for a clearer, consistent boxed look. Adds the group titles across all 9 locales. * feat(settings): box Appearance visual options; optional SettingsGroup title Split the Appearance -> Visual options card into a Display group and a Window group (Linux custom titlebar controls). SettingsGroup now allows an optional/omitted title for plain boxed panels. Group titles added across all 9 locales. * feat(settings): box Discord cover source and templates Group the Discord cover-source toggles and the activity templates into separate SettingsGroup panels (templates reuse their existing title/desc), dropping the manual indent and inline header. No new strings. * feat(settings): box the Music Network section Give the scrobble-master toggle, the enrichment-primary picker and the provider list each a boxed SettingsGroup with an accent header, and switch the add-a-service provider rows to the boxed panel style for consistent contrast with the rest of settings. * feat(settings): titled boxes for Integrations sections + cover source label Wrap the Discord enable toggle, the Discord cover-source picker (now with a "Cover art source" title and explainer), Bandsintown and Show-in-Now-Playing in titled SettingsGroup panels so each single-item section gets the same accent-headed boxed look. New cover-source strings across all 9 locales. * feat(settings): box Lyrics tab sections Wrap the lyrics-sources customizer and the sidebar-style picker in titled SettingsGroup panels (reusing the existing section titles). * refactor(settings): consistent content inset in SettingsGroup Add a body wrapper with a small left inset so every boxed section indents its controls uniformly (title stays flush at the box edge). Defined once in the component instead of per section. * feat(settings): box Storage tab sections incl. cover art cache Wrap media directory, cover art cache strategy, next-track buffering and downloads in titled SettingsGroup panels (reusing existing section titles); align the cover-cache table's first column flush with the new content inset. * feat(settings): box Library tab, relocate Lucky Mix, add SettingsToggle - Add a reusable SettingsToggle component for the repeated label/desc/switch row. - Box the Random Mix blacklist (grouping built-in keywords with the custom filter), Ratings and the Analytics strategy section. - Move the "Show Lucky Mix in menu" toggle out of the blacklist and up next to split-mix navigation and now-playing-at-top in the sidebar customizer. * feat(settings): box remaining Appearance sections Wrap library grid, UI scale, font and seekbar style in titled SettingsGroup panels (reusing the existing section titles). * feat(settings): box System language, logging and backup sections Wrap language and logging in titled SettingsGroup panels, and rework the backup section to drop its redundant inline header (the subsection already provides it) and box its content. About / Contributors / Licenses stay as free display content. * feat(settings): box remaining Audio sections Wrap Hi-Res, equalizer, playback speed, audio output device and track previews in titled SettingsGroup panels (reusing the existing section titles). * feat(settings): box Input tab keybinding sections Wrap the in-app and global shortcut lists in titled SettingsGroup panels. * feat(settings): box the Personalisation tab Convert every customizer (sidebar, home, artist, queue toolbar, playlist, player bar) to plain inner containers and wrap each in a titled SettingsGroup, so the boxed look is consistent without nested cards. Box the queue display mode picker too. * feat(settings): box the Themes sections above the store Add a boxed option to the flat Themes sections and apply it to Your Themes, Auto-Switch Theme and Import (the theme store stays unboxed). Drop the inner settings-card from InstalledThemes, ThemeImportSection and the scheduler so the SettingsGroup is the only frame. * fix(settings): give the Themes boxes a card carrier and accent header The flat Themes sections had no settings-card behind them, so the bg-app SettingsGroup had no contrast against the page. Box each above-store section as settings-card > titled SettingsGroup (accent header) like the rest. * fix(settings): clean up the server library sync status line Collapse the offline status to a single icon + phrase ("Server offline — sync deferred") instead of a redundant "Deferred" badge alongside it, and drop the now-unused string across all 9 locales. * fix(queue): keep toolbar toggle buttons coloured active while hovered The generic .queue-round-btn:hover rule outweighed .active in specificity, so an active button kept the hover colour until the pointer left — the toggle only looked on after moving the mouse away. Add an explicit active-hover rule (mirroring the mini player) so active wins immediately on click. * fix(settings): fix Lyrics triple title, drop dead Discord cover keys - Remove LyricsSourcesCustomizer's own section header (the subsection already titles it) and make its inner cards plain; the Lyrics boxes are now title-less. - Drop the dead discordCoverSource/discordCoverSourceDesc i18n keys (superseded by discordCoverTitle/Desc) and un-jam the libraryIndexServer status line in all 9 locales. * refactor(settings): drop redundant group titles and double frames Single-group sections duplicated the subsection title in the group header — make those groups title-less so the subsection header is the only title. A card whose sole child is one group now collapses via CSS so single-group sections render a single frame (matching the card-less Lyrics layout) instead of a card-in-group double border. Multi-group cards keep their frame as the grouping container. * fix(settings): keep the flat Themes cards framed when collapsing single-group cards The single-group card collapse also flattened the Themes section cards, which — not being inside an accordion — are themselves the contrast surface. Exclude .themes-section descendants from the collapse. * refactor(settings): use SettingsToggle for Appearance and System toggle rows Replace the hand-rolled toggle-row markup in the Appearance visual options and System tray/Linux/changelog rows with the shared SettingsToggle component, and extend it with a searchText prop and ReactNode descriptions for the remaining call sites. * refactor(settings): roll SettingsToggle out to Integrations, Audio and Storage Replace hand-rolled toggle rows in the Discord/Bandsintown/Now-Playing, Hi-Res, hot cache and playback behaviour/rate sections with SettingsToggle. Make its label optional (desc-only rows whose title is the group header) and add searchText/id pass-throughs. * refactor(settings): use SettingsToggle for the remaining standard toggle rows Track previews master, sidebar lyrics style, YouLyPlus/static-only, queue display mode and the sidebar split-nav/now-playing/lucky-mix rows now use the shared component. Genuinely custom rows (drag lists, the skip-star threshold, the AudioMuse row with its inline link, the fine-step advanced badge) stay hand-rolled. * fix(settings): drop duplicate titles on Hi-Res/Bandsintown/Now-Playing, un-jam locale line These single-toggle sections kept a group title identical to their subsection header; once the single-group card collapses the title rendered twice stacked. Make them title-less (the subsection header is the label). Also split the discordCoverTitle locale entry onto its own line in all 9 locales. * feat(settings): restore section icons in boxed Themes headers SettingsGroup gained an optional accent icon slot rendered before the title; ThemesTab forwards the Palette/Clock/Upload icons the boxed sections lost when they moved off the bespoke <h2> header. * style(settings): re-indent SettingsGroup children to nesting level Pure whitespace: children wrapped in SettingsGroup were left at their pre-wrap indent. No content change (git diff -w is empty). * fix(settings): clarify Native Hi-Res Playback description The old copy led with the disabled-state behaviour ("forces 44.1 kHz"), which read as if the toggle itself locked output to 44.1 kHz. Describe what enabling actually does: play each track at its native sample rate (reconfiguring the output device to match) instead of resampling to 44.1 kHz. Updated across all 9 locales. * docs: changelog + what's-new for the settings layout refactor (#1126)	2026-06-18 22:24:34 +02:00
Psychotoxical	3de7b57cc5	Fullscreen player polish + Discord Rich Presence fixes (#1068) ... * fix(fullscreen-player): drop track-number prefix from title, stop clipping descenders The big title showed a zero-padded queue position ("11. ") before the song name; remove it (the position still lives in the top bar). Also bump line-height 1.05 -> 1.25 so overflow:hidden no longer crops descenders (g, j, p, q, y) at 46px. * feat(settings): clarify built-in Discord RP vs official Navidrome plugin Add a bold notice atop the Discord Rich Presence block explaining it is the built-in integration, and that users wanting the official Navidrome Discord RP plugin should leave it off and enable "Show in Now Playing" instead. Add a matching bold note to the Now Playing setting. New i18n keys discordRichPresenceNotice / nowPlayingPluginNote across all 5 locales. * fix(discord-rp): use HTTPS cover URL instead of local file:// path Discord Rich Presence images are fetched by Discord's servers, so large_image must be a key or an https:// URL they can reach. Since the cover pipeline moved to an on-disk webp cache, coverArtUrlForDiscord returned a file://.../800.webp path on cache hit, which Discord cannot load and silently falls back to the app icon. Always hand it the getCoverArt URL; MPRIS keeps the local file:// path unchanged. * i18n(settings): fill discordRichPresenceNotice + nowPlayingPluginNote for es, nb, ro, ru The two new Discord-RP notice keys had only landed in 5 of the 9 locales; complete the set so no locale falls back to English. * docs(changelog): fullscreen title + Discord RP fixes (PR #1068)	2026-06-11 23:34:58 +02:00
Psychotoxical	1a82376f8c	feat(music-network): unified scrobble & enrichment framework (replaces hard-wired Last.fm) (#1066) ... * feat(music-network): core domain types and wire contracts Foundation for the Music Network framework: provider-agnostic domain types, capability model, typed errors, and account shapes under src/music-network/core, plus the ScrobbleWire / EnrichmentWire / PresetManifest / AuthStrategy contracts. No runtime wiring yet. * feat(music-network): generic audioscrobbler/listenbrainz/maloja transports Generalize the Rust remote layer for the Music Network framework. Add provider-agnostic transports parameterized by base_url: - audioscrobbler_request: Audioscrobbler v2 with caller-supplied endpoint (Last.fm, Libre.fm, Rocksky, custom GNU FM, Maloja compat share it) - listenbrainz_request: Token-header JSON (direct + Maloja LB compat) - maloja_request: native /apis/mlj_1 JSON lastfm_request stays as a thin transition delegate against the fixed host; it is removed once the framework owns all call sites. Wiremock tests cover audioscrobbler_request with a custom base_url and API-error mapping. * feat(music-network): audioscrobbler wire with last.fm + libre.fm presets Add the Audioscrobbler v2 wire, the behavioural successor to the legacy src/api/lastfm.ts, implementing the full EnrichmentWire surface (scrobble, now playing, love/unlove, loved sync, similar artists, track/artist stats, top lists, recent tracks, user profile, urls). - client.ts: transport wrapper over audioscrobbler_request, classifying failures into MusicNetworkError without touching any store - sign.ts: TS mirror of the api_sig base-string ordering rule (unit-tested) - auth/tokenPoll.ts: browser token-poll connect flow as a reusable strategy - presets/lastfm.ts, presets/librefm.ts: bundled, enrichment-capable, token-poll presets (both endpoints verified live) Extends WireContext with profileBase and ConnectContext with authBase so URL builders and connect flows need no preset lookup. * feat(music-network): listenbrainz + maloja-native wires, paste-auth presets Add the scrobble-destination wires and presets: - ListenBrainz wire (scrobble + now playing via playing_now), backing both the direct api.listenbrainz.org preset and the Maloja /apis/listenbrainz compat preset (one wire, two presets, differing only by base URL) - Maloja native wire (/apis/mlj_1/newscrobble, scrobble only — Maloja has no now-playing endpoint) - Shared api_key_only paste-auth strategy (token/key/session-key paste); the Audioscrobbler wire now dispatches token-poll vs paste by preset - Presets: listenbrainz, maloja_listenbrainz, maloja_native, rocksky (scrobble-only, session-key paste, bundled keys — verified live), and custom_gnufm (token-poll, user-supplied url/key/secret) - Contracts: ConnectContext.authStrategy, PresetManifest.selfHostedApiSuffix maloja_compat (the {url}/apis/audioscrobbler mode) is intentionally omitted: its protocol cannot be verified and is almost certainly the legacy handshake, not the 2.0 web API; Maloja is covered by the native and ListenBrainz modes. * feat(music-network): registry, orchestrator, enrichment router + runtime facade Wire the framework together behind a single facade: - registry: wireRegistry (WireId -> wire), presetRegistry (the 7 built-in presets), registerBuiltinWires (one-time side-effect registration) - CapabilityProbe: wire probe overlaid by manifest staticCapabilities as the final authority (lets two presets on one wire diverge, e.g. Rocksky's nowPlaying:false over the Audioscrobbler wire's optimistic yes) - ScrobbleOrchestrator: best-effort fan-out; flips the per-account session-error flag on AUTH_SESSION_INVALID and clears it on next success - EnrichmentRouter: resolves the single primary to its EnrichmentWire; the type guard rejects non-enrichment wires (Maloja/ListenBrainz) - MusicNetworkRuntime: the only app entry point — accounts, roles, fan-out, enrichment, urls, probe. Reads/writes state through the MusicNetworkStore port (Phase 5 backs it with the auth store) and a RuntimeHost for side effects - getMusicNetworkRuntime singleton + index.ts public barrel Tests cover fan-out, master toggle, capability gating, session-error flip/clear, primary eligibility, and enrichment routing. * feat(music-network): auth-store state + lossless legacy migration + runtime bridge Add the persisted Music Network state to the auth store and wire the runtime, all additively — nothing existing breaks yet. - authStoreTypes: musicNetworkAccounts / enrichmentPrimaryId / scrobblingMasterEnabled + actions; legacy lastfm* fields kept until Phase 6 - authMusicNetworkActions + defaults/wiring (synchronous localStorage) - accountPersistence: migrateLegacyLastfm (lossless — preserves session key, username and scrobbling preference; fills bundled Last.fm key from the preset; sets the migrated account as enrichment primary) + sanitizeAccounts - authStoreRehydrate: one-shot migration guarded by a sentinel so a later disconnect cannot resurrect the account from still-present legacy fields - musicNetworkBridge: backs the MusicNetworkStore port with the auth store and the RuntimeHost with the Tauri shell; initialized in pre-React bootstrap nowPlayingEnabled stays a global toggle (not a lastfm* field); the Phase 6 playback call-site will gate dispatchNowPlaying on it, preserving behaviour. * feat(music-network): route playback, enrichment and love through the runtime Migrate every Last.fm call-site onto the Music Network runtime, preserving behaviour: - playback (audioEventHandlers, playTrackAction): scrobble@50% and now-playing via dispatchScrobble/dispatchNowPlaying; loved-fetch via isTrackLoved. Now- playing follows scrobbling (as Last.fm did), Navidrome now-playing keeps the nowPlayingEnabled gate - enrichment: useArtistSimilarArtists, useNowPlayingFetchers, Statistics, and the ArtistDetail similar-artists gate now use the runtime, gated on an enrichment primary - love: PlayerBar, PlayerTrackInfo, all context menus, useNowPlayingStarLove and the startup loved-sync route through setTrackLoved / toggleNetworkLove - player store: lastfmLoved/lastfmLovedCache -> networkLoved/networkLovedCache; lastfmActions -> networkLoveActions; loved cache storage renamed with a lossless legacy-key fallback - getMusicNetworkRuntimeOrNull() for best-effort callers so they no-op (not throw) before the runtime is initialized src/api/lastfm.ts and the Integrations UI still use the legacy path; they are migrated and removed in the next phase. * feat(music-network): manifest-driven Integrations UI + scrobble batch format Replace the Last.fm Integrations card with a manifest-driven Music Network section, and fix Audioscrobbler scrobbling to the batch/array shape. - settings/musicNetwork/: MusicNetworkSection (master toggle, destination cards, enrichment-primary picker, Maloja proxy warning, add-a-service list) driven entirely off the preset registry; icon map from PresetManifest.icon - IntegrationsTab delegates to MusicNetworkSection (Discord/Bandsintown/ Navidrome now-playing unchanged) - i18n: musicNetwork.* across all 9 locales, incl. a per-field help hint for Rocksky's CLI session-key flow (rocksky login) - scrobble now uses the documented array form (artist[0]/track[0]/…); the bare single form is only tolerated by Last.fm, Rocksky requires the indexed form - auth-error detection keys off the response message (not the ambiguous numeric code) so a Rocksky server-500 no longer flips the account to a reconnect state - PresetManifest.PresetField gains an optional helpKey Rocksky's server rejects some non-ASCII track metadata with a 500 — a Rocksky backend bug; the client call is correct (verified). * fix(music-network): clearer Integrations layout + scrobble batch fix Address UI feedback on the Music Network section: - per-account scrobble toggle moves inside its account block (was a loose row between cards — unclear which account it belonged to) - master toggle and the primary-service picker are now boxed blocks at the top, not bare rows - primary-service copy reworked: 'Primary service' + a line spelling out that liked tracks/similar artists/stats come from it while scrobbling still goes to all enabled services - distinct zones separated by dividers (master/primary · connected · add) Also folds in the verified scrobble fixes: documented array form (artist[0]/track[0]/…) so Rocksky accepts scrobbles, and auth-error detection by message rather than the ambiguous numeric code (a Rocksky server-500 no longer flips the account to a reconnect state). Rocksky session-key field gains a CLI help hint (rocksky login), all 9 locales. * feat(music-network): indicator + remove legacy lastfm path Phase 7b/7c — finish the cutover and delete the old Last.fm path. - LastfmIndicator -> MusicNetworkIndicator (shows the enrichment primary's status, click -> Integrations) - delete src/api/lastfm.ts; remove Rust lastfm_request (remote.rs + lib.rs) - remove legacy authStore lastfm* fields, actions and types; delete authLastfmActions.ts; rehydrate migration reads the legacy blob via a cast - migrate the remaining NowPlaying call-sites (NowPlaying.tsx + the now-playing fetchers/prewarm/star-love hooks) off lastfmSessionKey/lastfmUsername onto the enrichment primary (gate + cache key) - type imports LastfmTrackInfo/LastfmArtistStats -> music-network TrackStats/ ArtistStats; drop 8 stale api/lastfm test mocks and the obsolete Last.fm auth tests; update settingsTabs + src/CLAUDE.md No lastfm imports remain outside src/music-network/; lastfm_request removed (acceptance §12). tsc clean, 1947 frontend tests + remote rust tests green. * test(music-network): cover scrobble shape + error classification, drop dead i18n keys Remove the 14 unused legacy scrobble/connection i18n keys across all 9 locales (settings.lfm*/scrobble*, connection.lastfm*); the live love, profile-link and now-playing keys stay. Add regression tests for the parity-critical transport logic: the indexed batch/array scrobble body, the auth-vs-network error classification (numeric codes collide across providers), and the manifest-overrides-probe capability merge. * feat(music-network): provider-agnostic UI + Maloja Audioscrobbler & Koito presets - de-hardcode the single provider name across every enrichment surface (love labels, now-playing badge, stats title); derive it from the enrichment primary and interpolate via {{provider}} i18n params - surface a toast when a paste-auth connect probe fails — a static 'supported' capability flag no longer masks a runtime probe error - add the Maloja Audioscrobbler (GNU FM) preset (the third Maloja wire mode) and a Koito preset (ListenBrainz-compatible), both data-only - generalise PRIVACY.md and the scrobbling help entry to the framework - rename residual lfm* identifiers to network*; strip legacy flat lastfm* fields from the persisted blob; neutral transport error prefix - tests: error classification, scrobble body, capability probe, registry * fix(music-network): validate paste-auth keys on connect + UI polish - AudioscrobblerWire.probe now validates an api_key_only session with a signed call and reports scrobble:'error' only on a genuine auth failure (a scrobble-only service that rejects user.getInfo is not a bad key), so an invalid Maloja Audioscrobbler / Rocksky key surfaces a connect toast instead of failing silently; WireContext carries the preset authStrategy - drop the unreachable Statistics empty-state branch and its dead lfmNotConnected i18n key; use the useEnrichmentPrimaryLabel hook there - drive the love-button glyph from the enrichment primary's manifest icon; neutral Music Network section icon; remove a dead LastfmIcon import - tests: paste-auth vs token-poll probe behaviour * chore(music-network): rename showLastfmSimilar → showNetworkSimilar, refresh stale comments Post-parity polish: the similar-artists toggle now sources from the generic enrichment runtime, so rename the lingering lastfm-flavoured identifier; drop stale 'Mirrors today's LastfmX' doc comments referencing the removed legacy types, and generalise the scrobble-point comment. * docs(changelog): Music Network entry (PR #1066) Co-Authored-By: cucadmuh <49571317+cucadmuh@users.noreply.github.com> * fix(music-network): bound request timeout on the provider transports audioscrobbler_request / listenbrainz_request / maloja_request built a reqwest client with no timeout, so a hung provider left scrobble / probe / loved-sync promises unresolved. Add a shared provider_http_client() with a 15s timeout, matching the sibling fetch_* commands. Addresses review C3. * refactor(music-network): dedupe wire transport + no-enrichment helpers The three provider clients repeated the same invoke -> classify-error -> MusicNetworkError boilerplate, and the three probe() bodies repeated the "mark every enrichment capability no" loop. Extract wires/shared/invokeTransport() (each wire keeps its own arg shape + auth rule) and markNoEnrichment() in core/capabilities.ts. Addresses review C4. * refactor(music-network): drop write-only malojaWireMode dead state malojaWireMode was written on connect but never read — the wire is resolved by wireId and the Maloja base URL by the preset's selfHostedApiSuffix. Remove the field, the MalojaWireMode type, the malojaWireModeFor helper, the AccountPatch entry, the PresetField union member, and the export. Addresses review C1. * refactor(music-network): one useEnrichmentPrimary hook, drop lastfm fallback The enrichment-primary lookup (accounts.find by enrichmentPrimaryId) was duplicated across two hooks and inlined in the indicator and both context-menu builders, two of them with a hardcoded 'lastfm' icon fallback. Add one music-network/ui/useEnrichmentPrimary() returning {account,label,icon}|null; useEnrichmentPrimaryLabel/Icon delegate to it and the indicator + context menus consume it directly. Icon fallback is the neutral 'custom' glyph, never a provider (provider-agnostic, §7.3). Addresses review C2. --------- Co-authored-by: cucadmuh <49571317+cucadmuh@users.noreply.github.com>	2026-06-11 22:56:30 +02:00
Frank Stellmacher	455aec4def	feat(discord): show track title in Discord member list (configurable name template) (#885) ... * feat(discord): override activity name in member list with track title (configurable template) The Discord member list and the collapsed Rich Presence card display the activity's `name` field next to the music icon. Without an override Discord falls back to the registered application name ("Psysonic"), so the line reads "Psysonic" while every track plays instead of the actual track title that comparable players show. Add a fourth user-configurable template `discordTemplateName` (Settings -> Integrations -> Discord Rich Presence). The Rust side passes it through `Activity::new().name(...)` when the rendered template is non-empty; an empty template falls back to Discord's default application name. Default template is "{title}". Tauri boundary: additive optional `nameTemplate` field on the existing `discord_update_presence` command. Existing call sites that omit it keep working -- the Rust handler applies the same "{title}" fallback. * i18n(settings): discord name template label in all locales Adds the discordTemplateName label across en, de, fr, es, nl, nb, ro, zh, ru -- shown next to the new "User list line (name)" template input under Discord Rich Presence. * docs(release): CHANGELOG and credits for discord name template (PR #885)	2026-05-28 20:32:41 +02:00
Frank Stellmacher	7737b35bf8	refactor(settings): G.57 — extract Integrations + Library tabs (#622) ... Move the Integrations tab (Last.fm connect/disconnect, scrobbling toggles, ListenBrainz, Discord RPC) into IntegrationsTab. The Last.fm token+session poll flow is now owned by IntegrationsTab as a useCallback closing over useAuthStore directly. Move the Library tab (Random Mix blacklist, Lucky Mix menu toggle, hard-coded audiobook genre badges, ratings sliders and mix min-rating thresholds) into LibraryTab; AUDIOBOOK_GENRES_DISPLAY and the per-row star sliders move with it. Settings.tsx 2741 → 2266 LOC (−475). Unused imports removed: lastfm api helpers, LastfmIcon, Shuffle, Star, StarRating, MIX_MIN_RATING_FILTER_MAX_STARS. Pure code move — no behaviour change.	2026-05-13 02:11:06 +02:00