6 Commits

Author	SHA1	Message	Date
cucadmuh	086c7e43b4	feat(psylab): rename probe, Tuning tab, log tools, and safe log sanitization (#1027) ... * feat(psylab): rename probe UI, add Tuning tab and log copy/export PsyLab (Ctrl+Shift+D): cover backfill threads move to Tuning; logs gain selectable text, toolbar copy/export, and a selection-only context menu. * fix(logging): redact secrets and mask remote hosts in runtime logs Sanitize lines at append time (buffer, CLI tail, export) and in PsyLab: Subsonic/auth query params, bearer tokens, password fields, URL userinfo; remote hostnames partially starred, LAN/localhost left readable. * fix(logging): UTF-8-safe log sanitization — unbreak playback on em dash Byte-indexed URL scanning panicked on multi-byte chars (e.g. "—" in stream logs), killing tokio workers and aborting playback. Iterate by char boundary; add infallible wrapper on the append hot path. * docs(changelog): PsyLab UI and safe log sanitization (PR #1027)	2026-06-08 02:29:23 +03:00
cucadmuh	2d3c723a6e	feat(offline): unify local playback, offline library, and favorites sync (#1008) ... * feat(local-playback): LP-1 media layout and download_track_local Add library-index-backed path builder in psysonic-core and a unified Tauri download command that writes under media/{cache|library}/ with layout fingerprints; legacy hot/offline commands unchanged for now. * feat(local-playback): LP-2 localPlaybackStore and media tier Rust helpers Add unified Zustand index with legacy offline/hot-cache import, media_layout TS mirror, and Rust commands for tier size/purge/delete/promote. * feat(local-playback): LP-3 wire prefetch and playback to unified index Route downloads through download_track_local, delegate hot/offline shims to localPlaybackStore, and update resolve/promote/prefetch plus key rewrite. * feat(local-playback): LP-4–LP-6 offline UI, invalidation, and mediaDir Offline Library loads pinned groups via library index; sync-idle invalidates stale paths; Settings uses a single mediaDir with cache/library tier sizes. * feat(local-playback): migrate legacy offline files to media/library layout Move flat psysonic-offline downloads into nested media/library paths using library index metadata, with retry on sync-idle when tracks are not yet indexed. * feat(local-playback): simplify offline disk migration and restore Offline Library UI Scan psysonic-offline on disk and relocate by library track id; restore pinSource and cover art for migrated pins; add find_live_by_id for segment/key resolution. * feat(local-playback): disk-first offline reconcile and fast library tier discovery Reconcile library-tier index against on-disk files using candidate track IDs instead of scanning the full catalog. Refresh Offline Library from disk on open and focus so deleted folders drop out of the UI. Add Rust discover/prune helpers and wire album/server reconcile through the unified path. * fix(offline): resolve local playback URLs across server index-key variants Offline Library play failed when library-tier files were indexed under a host key while playback looked up only the active profile UUID. Use findLocalPlaybackEntry for URL resolution, pin queueServerId to the card server, and build play queues from tracks that still have on-disk bytes. * fix(offline): playlist cards, playback from Offline Library, and local URL routing Show playlists with name and quad/custom cover instead of the first track's album artist. Build play queues with library-batch fallback and offline-only server switch. Prefer library-tier URLs in playTrack; add playback-unavailable toast and missing trackToSong import. * fix(cache): ephemeral disk reconcile, empty-dir prune, and Storage UI Sweep media/cache after eviction (orphan files, stale index, empty folders). Settings: split media folder from cover cache; in-browser image cache lives under Cover art cache with aligned columns; clear only IndexedDB images. * feat(offline): show library disk usage in Offline Library header Query media/library tier size on reconcile and display it in a right-aligned stat block beside the page title and album count. * fix(cache): defer unindexed hot-cache eviction; drop legacy offline size cap Reconcile ephemeral cache without deleting files from other app instances; evict unindexed hot-cache files oldest-first only when over hotCacheMaxMb. Remove the hidden maxCacheMb gate and offline-full banner on album pages. * feat(offline): play-all cache card and stable Offline Library grid rows Add a shuffle-and-play card for all on-disk library pins plus hot-cache tracks when buffering is enabled. Fix virtual row height for offline cards and reserve the year line so grid rows no longer overlap. * feat(offline): queue-cache grid card limited to media/cache Replace the full-width play-all banner with a playlist-style grid tile. Shuffle/enqueue only ephemeral hot-cache tracks when buffering is enabled, not offline library pins. * chore(licenses): regenerate bundled OSS list for 1.48.0-dev Set GPL-3.0-or-later on workspace crates and extend cargo-about accepted licenses so generate-licenses.mjs runs; refresh src/data/licenses.json. * feat(favorites): auto-sync starred tracks into separate media/favorites tier Keep manual Offline Library in media/library/ and favorites offline in favorite-auto/index + media/favorites/ so toggling sync cannot purge user-pinned bytes; playback resolves library before favorites. * feat(favorites): compact offline toggle with disk icon and sync semaphore Move control to the page header (disk + switch, tooltips); show red/yellow/green LED when enabled instead of the full-width save-offline card. * fix(favorites): trigger offline sync on star/unstar from anywhere Hook star/unstar API so favorites offline reconcile runs globally (songs, albums, artists); optimistic unstar removes local bytes; drop Favorites-page-only sync. * fix(cache): skip hot-cache prefetch when favorites or library bytes exist Treat favorite-auto tier like offline library for prefetch, stream promote, and same-track replay so synced favorites are not duplicated in media/cache. * fix(favorites): reconcile offline files on merged track union only Dedupe artist/album/song stars into one target set per track id; drop eager unstar deletes so overlapping favorites do not remove bytes still needed. * feat(offline): add Favorites card to Offline Library Mirror queue-cache card for favorite-auto tier with play, enqueue, and navigation to Favorites on card click. * feat(offline): show library+favorites disk total with icon breakdown Sum media/library and media/favorites in the On disk widget and open an icon popover on hover with per-tier sizes for screen readers and sighted users. * feat(favorites): enable offline Favorites tab when auto-save is on Keep Favorites in the sidebar when disconnected, land on /favorites without manual pins, and load starred rows from the local library index. * feat(favorites): cross-server offline browse with per-server covers When auto-save is on, Favorites merges starred items from every indexed server and syncs each server independently. Detail links carry ?server= for offline album/artist pages; cover art resolves disk cache by entity serverId instead of the active server only. * feat(playback): mixed-server queue scope and cross-server favorites sync Per-ref server identity for playback (URL index key in queue refs, profile UUID for API): trackServerScope, playbackServer helpers, gapless/scrobble/covers by playing ref. Remove cross-server enqueue block; remap queueItems on URL remigration. Favorites: star/unstar and favorite-auto sync target the owning serverId (not only active); queueSongStar passes server through pending sync. * fix(offline): suppress Subsonic calls during favorites and local playback Add reachability guards so offline favorites browse, album detail, queue sync, scrobble, and Now Playing metadata skip network when the server is down or the track plays from psysonic-local. Load starred albums/tracks from the library index only (not the full artist table), refresh favorites from index first, and pass server scope in favorites navigation. * fix(queue): export share and playlist save for active server only Mixed-server queues now filter queue refs by the browsed server profile before copying a share link or saving/updating a playlist from the toolbar. * fix(offline): complete album pins and resume interrupted downloads Prefer full getAlbum track lists when online so partial library index does not truncate offline pins; refresh songs before pin from album detail. Resume incomplete persisted pins after reconcile and reconnect, cancel in-flight work on delete, and chunk library batch fetches past 100 refs. * fix(offline): pin queue, queued UI, and re-pin after remove Serialize album and playlist offline pins so parallel enqueue no longer drops in-flight work. Show an explicit queued state on album and playlist actions with dequeue on repeat click, sidebar tooltips for long labels, and clear stale cancel flags so Make available offline works after remove. * fix(offline): remove Offline Library cards without full page reload Optimistically drop the deleted card from local grid state, show the loading spinner only on first visit, and ignore stale disk refreshes so pin updates no longer flash the whole library view. * fix(offline): artist discography pin state and queue handling Detect cached/queued/downloading from persisted album pins instead of ephemeral bulkProgress, skip already offline or in-flight albums when enqueueing discography, and show the correct hero button after revisit. * fix(local-playback): address LP-1 review handoff (B1, M1–M7) Harden media path sanitization and tier containment, align Rust/TS layout fingerprints, serialize per-track downloads, and fix favorites re-enable, multi-server debounce, prev-track promote key, now-playing reachability, and ephemeral prefetch soft-skip for unindexed tracks. * fix(offline): cancel in-flight favorites downloads on unstar Abort Rust streams with the real favorites downloadId when sync is rescheduled or disabled, and drop completed bytes that no longer belong in the starred set so unstar does not leave orphan files on disk. * fix(build): resolve TypeScript errors blocking prod nix build Align mediaLayout with LibraryTrackDto camelCase, extend analysis-sync reasons, fix OfflineLibrary grid cover typing, and tighten vitest mocks so `tsc && vite build` passes under the flake beforeBuildCommand. * fix(rust): satisfy clippy too_many_arguments for CI Bundle offline-library analysis and local path/migration helpers into parameter structs so `cargo clippy -D warnings` passes on the branch. * fix(settings): show correct hot-cache track count in Buffering section Count ephemeral localPlayback rows instead of prefix-matching index keys, which always missed host:port server segments and showed zero tracks. * fix(media-layout): align truncation threshold on code points (M1) Rust sanitize_and_truncate_segment now uses char count like TS so long non-ASCII metadata does not diverge layout fingerprints; add Cyrillic parity tests and clarify ephemeral cold-miss doc on download_track_local. * fix(test): use numeric cachedAt in hotCacheStore count test Align test fixture with LocalPlaybackEntry type so tsc passes in CI. * docs: add CHANGELOG and credits for offline experience PR #1008 * feat(offline): auto-sync manually cached playlists when track list changes Re-download new tracks and prune removed ones for playlist pins only, triggered from updatePlaylist, playlist detail load, smart-playlist polling, and reconnect. * docs: note cached-playlist sync in CHANGELOG and credits for PR #1008 * fix(offline): exclude smart playlists from manual offline cache and sync Hide cache-offline for psy-smart-* playlists, block download/sync paths, and document the distinction in CHANGELOG. * feat(offline): auto-sync cached albums and artist discographies Generalize pinned playlist reconcile into pinnedOfflineSync so manually pinned albums and artist discographies re-download added tracks and prune removed ones on reopen, reconnect, and catalog changes. * feat(offline): split pinned sync triggers by pin kind Album and artist pins reconcile after library index sync and reconnect; regular playlists reconcile hourly and on in-app playlist edits only. Remove reconcile-on-open for album, artist, and playlist detail views. * fix(offline): address PR #1008 review (N1, tests, pin queue) Scope playlist reconcile to the owning server via getPlaylistForServer. Add artist discography and mixed-server playlist tests; dedupe pending sync jobs; skip pinTasks overwrite during active downloads.	2026-06-06 22:43:03 +03:00
cucadmuh	df3533bb5a	fix(cover): Windows thumbnails, tier fallback, PNG decode, coverArt id (#878) ... * fix(cover): tier fallback for sparse surfaces and Windows asset URLs Sparse UI (player bar, queue) now reads disk covers via the same tier ladder as dense grids, so a warm 800.webp satisfies a 128px request. Reject non-asset convertFileSrc results on Windows, widen Tauri asset scope, and seed ladder keys on cover:tier-ready. applyDiskPath uses seedGridDiskSrcCache only to avoid notify/subscriber infinite loops. * fix(artist): top-track thumb uses album coverArt already warm in grid Song coverArt ids often differ from album cover ids (e.g. Octastorium in the grid vs empty track thumb). Prefer the album row's coverArt on artist pages and ensure high priority for 32px dense cells. * fix(cover): albumId for playback/queue; no broken img until disk URL ready Prefer albumId over track-id coverArt (Navidrome). Wire queue to CoverArtImage with playback scope. CoverArtImage renders a placeholder div until asset src exists to avoid the browser broken-image icon. * fix(test): add song id to resolveArtistPageSongCoverArtId fixture Pick<SubsonicSong, …> requires id; fixes tsc in CI/build. * fix(cover): resolve albumId for Now Playing and artist top tracks Prefer albumId when album.coverArt echoes track id; use sparse surface on artist suggestion thumbs; apply resolveSubsonicSongCoverArtId across playback surfaces (Now Playing, fullscreen, mobile, mini). * fix(cover): decode PNG from Subsonic before WebP tier encode Enable `png` in the image crate — some servers return PNG cover art; failed decode left `.fetch-failed` and empty thumbs for those albums. * refactor(cover): consolidate cover id resolution and align tests Move resolveSubsonicSongCoverArtId helpers to src/cover/resolveCoverArtId.ts with resolvePlaybackTrackCoverArtId for player surfaces; co-locate tests; fix FullscreenPlayer expectations for albumId-first resolution. * docs: CHANGELOG and credits for PR #878 * fix(cover): keep per-track coverArt when distinct from song id Address PR #878 review (b): albumId only when coverArt is missing or echoes track id; pin case with unit test; comment isRawFsPath symmetry. * chore(cover): address PR #878 review nits (scope, tests, rename) Narrow asset scope to cover-cache dirs only; add diskSrcCache Windows-path tests; rename ArtistTopTrackCover; CHANGELOG symptom-first wording. * fix(cover): restore asset scope to app data dirs (Windows regression) $APPDATA/cover-cache/** did not match Tauri scope resolution — covers were blocked after load. Use $APPDATA/** and $APPLOCALDATA/** (no $DATA). * fix(cover): Windows asset URLs — restore DATA scope, path normalize Regression after review nits: dropped $DATA/** and strict isAssetProtocolUrl blocked valid http://asset.localhost URLs on Windows. Normalize C:/ paths before convertFileSrc; CoverArtImage/Hero hide broken img on load error. * fix(cover): disk peek fallbacks when cache folder id differs Small surfaces resolve albumId while cover-cache often stores WebP under track id or album.coverArt from the grid. Peek batch now tries legacy ids; playback scope resolves server index key by URL key, not UUID-only lookup. * fix(cover): Navidrome al-* vs mf-* disk id mismatch UI used mf-* coverArtId while library backfill only cached al-* folders. Prefer album id for display/peek when coverArt is mf-*; backfill now queues both distinct album_id and cover_art_id values. * fix(cover): mf→al disk peek when mf folder missing in cache Navidrome Subsonic often returns mf-* coverArtId while backfill only creates al-* folders. Peek mf first, then al-* from hints; load albumId from library when Subsonic omits it; ensure fallback uses al-* id. * feat(cover): CoverArtRef, segment disk layout, library-index backfill Normalize cover caching around stable entity ids from the local library and Navidrome fetch ids. Disk paths live in psysonic_core::cover_cache_layout (album/<entityId>/); UI uses CoverArtRef with cacheEntityId + fetchCoverArtId. - Remove SQLite/mf peek helpers (diskPeekIds, peekCoverOnDisk, mergeDiskIdHints) - Backfill reads album/artist rows from library SQLite (bare Navidrome ids ok) - Use stored cover_art_id for HTTP; per-disc dirs only when discs differ - Migrate call sites to albumCoverRef / albumCoverRefForPlayback * feat(cover): central CoverEntry resolver (artist, album, track) Add resolveEntry.ts and Rust CoverEntry helpers as the single source of truth for cache_entity_id vs fetch_cover_art_id. ref.ts delegates to them; resolveCoverArtId becomes a thin compatibility shim. * feat(cover): resolve cover entries from local library index Add library_resolve_cover_entry IPC and cover_resolve.rs so album, artist, and track covers use SQLite cover_art_id + disc detection. TypeScript helpers in resolveEntryLibrary.ts prefer the index over live API fields when rows exist. * feat(cover): library-first hooks for grids and playback UI Add useAlbumCoverRef, useArtistCoverRef, useTrackCoverRef, and usePlaybackTrackCoverRef — sync fallback then SQLite index upgrade. Wire album/artist cards, album header, song card, and all player surfaces to resolve covers from the local library when indexed. * feat(cover): complete library-first migration across all UI surfaces Add Album/Artist/TrackCoverArtImage, useLibraryCoverPrefetch, and batch resolve helpers. Migrate grids, search, home, playback sidecars, warm peek, playlists, and share flows to hooks that upgrade from SQLite. Backfill normalizes album rows through cover_resolve; document paths in COVER_PATHS.md. Radio remains a deliberate non-library exception. * fix(cover): stop render loop from unstable serverScope in library hooks Default param `{ kind: 'active' }` created a new object every render, so every grid cell re-ran library_resolve IPC and setState in a loop. Use COVER_SCOPE_ACTIVE singleton, coverScopeKey deps, and guarded sync updates. * chore(cover): remove COVER_PATHS.md from app tree (lives in workdocs) Audit doc is team spec — see workdocs 2026-05-cover-art-pipeline/cover-paths-audit.md. * fix(cover): unstick library backfill after route changes (PR #870 regression) useCoverNavigationPriority cleanup called beginNavigation instead of end, leaking navigationHoldDepth so ui_priority_hold never released and backfill never downloaded. Also skip disk check after cover_resolve normalization. * fix(cover): segment progress, cap backfill CPU, include artists in catalog Progress and disk size now scan album/ and artist/ segments (canonical 800.webp). Prune legacy flat server/al-* dirs on startup and backfill pass. Backfill: max 2 concurrent ensures; JPEG decode and WebP encode run on the blocking pool behind a shared 2-permit semaphore so Tokio workers stay cool. Artists were missing because the catalog only read the empty artist table; add distinct artist_id from track and album rows. Paginate with a composite (kind, id) cursor so album and artist rows are not skipped. * fix(cover): drop legacy prune; backfill per-disc and artist catalog Remove prune_legacy_* and cover_cache_catalog_entry — layout is only cover_dir (album|artist segments); stale flat dirs clear on LAYOUT_STAMP change. Backfill: artists from track/album artist_id; expand albums to per-CD mf-* slots when discs differ; fix resolve_album_cover_entry when album row is missing. * fix(cover): reduce library IPC storms and fix multi-disc player art Skip per-row library_resolve on live search and artist album grids; warm grids from API coverArt after mount instead of blocking layout. Dedupe and cap concurrent library_resolve calls. Restore per-disc cache keys in the player and queue when track mf-* art differs from the album bucket. * fix(cover): skip library resolve on advanced and full search rows Use API coverArt for album/artist rails and lazy viewport artwork so result pages do not fire hundreds of library_resolve IPC calls at once. * fix(cover): default libraryResolve off for browse grids and rails Skip per-card library_resolve on album/artist/song browse UI by default; keep it on album/artist headers, playback queue rows, and orbit approval. * fix(cover): split UI/backfill CPU pools and restore mainstage hero carousel Library backfill no longer shares the 2-permit JPEG/WebP semaphore with visible cover ensures. Hero initializes albums from props, re-binds scroll visibility after mount, updates backdrop on slide change, and uses library resolve for correct cover art on the banner. * fix(analysis): resume full-library scan after candidates phase Reset the SQL cursor when entering full-library mode so tracks with partial analysis are not skipped. Tighten TS backfill completion and CPU queue watermarking; align cover-cache key tests with album-scoped storage keys. * fix(library): remove useless map_err in cover_resolve (clippy) CI treats clippy::useless-conversion as error on rusqlite optional() chains. * fix(cover): satisfy clippy on cover_cache_ensure IPC args Pass CoverCacheEnsureArgs as a single Tauri parameter instead of nine positional fields; align frontend invoke payload with { args }.	2026-05-28 03:15:08 +03:00
cucadmuh	003b280a77	feat(enrichment): oximedia BPM/mood facts, mood search, and queue display (#863) ... * feat(enrichment): oximedia BPM/mood facts, mood search, and queue UI Run client-side oximedia analysis after CPU seed and persist BPM, mood JSON, and searchable mood_tag facts. Add product mood groups (joy/sadness/dance/work/ romance) with Advanced Search filter on the local index, queue BPM/mood display, migration 008 mood_tag index, and refreshed licenses for oximedia crates. * fix(enrichment): keep mood_groups module comment in English * feat(search): virtual mood groups, anger filter, and Advanced Search UX Expand mood search via overlapping virtual groups (tag expansion only), add anger/Злость group, skip album/artist shortcuts for track-only filters, and simplify mood search UI (songs-only, hide type tabs). Fix CustomSelect spurious scrollbar on short option lists. * feat(analysis): unified track analysis plan and enqueue path Add TrackAnalysisPlan (waveform, LUFS, enrichment) with a single enqueue_track_analysis entry for all byte-backed triggers. Run enrichment when cache is full but library facts are missing; route playback, cache, and backfill through the planner. Fix browseTextSearch LocalSearchOpts tsc gap and remove obsolete read_seed_bytes_if_needed helper. * fix(analysis): wire playback dispatch, preload enrichment, and UI refresh Route stream, gapless, preload, and local-file playback through analysis_dispatch so BPM/mood enrichment runs when waveform/LUFS are already cached. Fix audio_preload cache-hit and hot-cache paths, emit preload-cancelled for retry, and add analysis:enrichment-updated plus content_cache_coverage key resolution. * fix(audio): preload local files from disk and stop analysis retry loop Seed hot/offline next tracks via LocalFilePlayback (512 MiB) instead of copying into the RAM preload slot. Keep bytePreloadingId set after preload-ready so progress ticks do not re-invoke audio_preload every second. * fix(enrichment): clippy, album bpm filter routing, and queue mood display Clippy-clean analysis_dispatch and engine imports; restrict track-derived album routing to mood_group/mood_tag only so bpm is skipped on album queries. Log enrichment plan errors with retry-all plan; filter queue mood labels to oximedia ids. * fix(enrichment): simplify mood_tag backfill branch in plan_track_enrichment Remove empty if-block; keep same behaviour when backfill fails and moods row exists. * docs: CHANGELOG and credits for track enrichment PR #863 * docs(credits): track enrichment PR #863 contributor line * chore(enrichment): clippy-clean plan branch and trim dead exports Collapse mood_tag backfill if for clippy; remove unused moodGroupById and OXIMEDIA_MOOD_LABELS re-exports; stop poll when server BPM is already known. * fix(enrichment): close R2/S1–S3 limits and Song Info BPM fallback Return TrackEnrichmentOutcome::Failed on oximedia errors so retries are not masked as complete; extract mood Advanced Search SQL, unify top-3 mood tag selection in mood_groups with TS invariant tests, and show measured BPM in Song Info when tag BPM is missing or zero. * fix(enrichment): restore offline coverage and show mood in Song Info Add unit tests for offline download cancel/clear registry after the analysis seed refactor dropped read_seed_bytes coverage; show localized mood labels in Song Info when library enrichment facts exist. * fix(enrichment): soft mood scoring and unblock offline cancel tests Replace oximedia quadrant happy/excited mapping with valence/arousal soft scores across all mood tags for display, storage, and backfill; fix offline cancel unit tests that deadlocked by calling clear while holding the global offline_cancel_flags mutex. * fix(enrichment): dedupe joy cluster and cap mood display at two labels Never show happy and excited together; pick one tag per V/A cluster, tighten oximedia recalibration, and limit queue/Song Info to two moods that pass a relative score floor. * fix(enrichment): disable oximedia mood labels in UI and search tags Oximedia 0.1.7 mood is a spectral energy heuristic, not independent mood weights; valence correlates with loud/bright audio and false-labels metal and lyrical tracks as happy. Hide queue/Song Info mood and stop writing mood_tag facts until a reliable detector lands; keep V/A/moods JSON stored. * fix(enrichment): disable oximedia mood analysis and add BPM advanced search Stop planning, running, and storing oximedia mood facts; purge accumulated mood rows via migration 009. Hide mood filters in Advanced Search, expose BPM range filter with dual-storage resolution, and show a BPM column in song results when that filter is active. * feat(search): analysis BPM priority, source tooltip, and filter UX Prefer analysis track_fact over file tags for BPM resolution; show source in list tooltips. Validate BPM range on blur, add clear button, fix double tooltip. * fix(enrichment): prefer analysis BPM in Song Info and queue tech row Show measured track_fact BPM before file tags until analysis completes; pick the highest-confidence analysis fact when several exist.	2026-05-23 18:54:04 +03:00
Psychotoxical	ff456dd823	refactor: extract psysonic-analysis crate (M2/7) ... Moves analysis_cache + analysis_runtime out of the top crate into a new psysonic-analysis crate, plus the runtime user-agent facade into psysonic-core. The audio↔analysis dependency cycle is broken via a PlaybackQueryHandle port registered as Tauri State. crates/psysonic-analysis/ new lib crate src/analysis_cache/{mod,store,compute} unchanged behaviour src/analysis_runtime.rs + enqueue_analysis_seed (was in lib_commands/cache/offline) crates/psysonic-core/src/ user_agent.rs subsonic_wire_user_agent + runtime/default helpers (was in top lib.rs) ports.rs PlaybackQueryHandle: closure wrapper, not Arc<dyn Trait>, so existing State<AudioEngine> callsites stay unchanged The shell setup hook registers the real PlaybackQueryHandle once the AppHandle is available; the closure captures it and re-resolves AudioEngine via try_state at each call. Top crate keeps `crate::analysis_cache`, `crate::analysis_runtime`, `crate::subsonic_wire_user_agent`, and `crate::submit_analysis_cpu_seed` working via re-exports — no audio/lib_commands callsite needed editing. Behaviour preserving. Cargo check + clippy --workspace clean (only pre-existing warnings carry over).	2026-05-09 13:25:04 +02:00
Psychotoxical	7718ac3ee5	refactor: introduce cargo workspace + psysonic-core crate (M1/7) ... First milestone of the workspace crate split. Sets up the workspace skeleton and extracts shared logging + cross-crate port traits into a new psysonic-core crate. src-tauri/Cargo.toml now defines [workspace]; top package becomes the workspace root. crates/psysonic-core/ new lib crate, no Tauri-handler code: src/logging.rs full logging facade (was src/logging.rs) src/ports.rs PlaybackQuery + AnalysisOrchestrator trait declarations (no impls yet) The top crate re-exports `psysonic_core::logging` and the `app_eprintln!` / `app_deprintln!` macros so every existing `crate::logging::*` and `crate::app_eprintln!` callsite keeps working unchanged. Port traits intentionally take `tauri::AppHandle` — psysonic-core is a workspace-internal crate, so depending on Tauri here is a feature, not a leak. Implementers will register themselves as `Arc<dyn PlaybackQuery>` / `Arc<dyn AnalysisOrchestrator>` Tauri State in M2/M3. Behaviour preserving. Cargo check + clippy --workspace clean.	2026-05-09 13:06:28 +02:00