3 Commits

Author	SHA1	Message	Date
Psychotoxical	d50c9c444d	refactor(settings): reusable SettingsGroup/SettingsToggle + boxed sections across tabs (#1126) ... * refactor(settings): extract reusable SettingsGroup component Pull the boxed sub-section pattern (bordered panel + accent uppercase header) introduced for the Audio tab into a reusable <SettingsGroup title desc> component, and migrate NormalizationBlock and PlaybackBehaviorBlock onto it. No visual change. * feat(settings): box the System behavior section into groups Split the System -> App Behavior card (which bundled tray toggles, Linux rendering tweaks and the clock format) into titled SettingsGroup panels (Tray / Linux rendering / Clock) for a clearer, consistent boxed look. Adds the group titles across all 9 locales. * feat(settings): box Appearance visual options; optional SettingsGroup title Split the Appearance -> Visual options card into a Display group and a Window group (Linux custom titlebar controls). SettingsGroup now allows an optional/omitted title for plain boxed panels. Group titles added across all 9 locales. * feat(settings): box Discord cover source and templates Group the Discord cover-source toggles and the activity templates into separate SettingsGroup panels (templates reuse their existing title/desc), dropping the manual indent and inline header. No new strings. * feat(settings): box the Music Network section Give the scrobble-master toggle, the enrichment-primary picker and the provider list each a boxed SettingsGroup with an accent header, and switch the add-a-service provider rows to the boxed panel style for consistent contrast with the rest of settings. * feat(settings): titled boxes for Integrations sections + cover source label Wrap the Discord enable toggle, the Discord cover-source picker (now with a "Cover art source" title and explainer), Bandsintown and Show-in-Now-Playing in titled SettingsGroup panels so each single-item section gets the same accent-headed boxed look. New cover-source strings across all 9 locales. * feat(settings): box Lyrics tab sections Wrap the lyrics-sources customizer and the sidebar-style picker in titled SettingsGroup panels (reusing the existing section titles). * refactor(settings): consistent content inset in SettingsGroup Add a body wrapper with a small left inset so every boxed section indents its controls uniformly (title stays flush at the box edge). Defined once in the component instead of per section. * feat(settings): box Storage tab sections incl. cover art cache Wrap media directory, cover art cache strategy, next-track buffering and downloads in titled SettingsGroup panels (reusing existing section titles); align the cover-cache table's first column flush with the new content inset. * feat(settings): box Library tab, relocate Lucky Mix, add SettingsToggle - Add a reusable SettingsToggle component for the repeated label/desc/switch row. - Box the Random Mix blacklist (grouping built-in keywords with the custom filter), Ratings and the Analytics strategy section. - Move the "Show Lucky Mix in menu" toggle out of the blacklist and up next to split-mix navigation and now-playing-at-top in the sidebar customizer. * feat(settings): box remaining Appearance sections Wrap library grid, UI scale, font and seekbar style in titled SettingsGroup panels (reusing the existing section titles). * feat(settings): box System language, logging and backup sections Wrap language and logging in titled SettingsGroup panels, and rework the backup section to drop its redundant inline header (the subsection already provides it) and box its content. About / Contributors / Licenses stay as free display content. * feat(settings): box remaining Audio sections Wrap Hi-Res, equalizer, playback speed, audio output device and track previews in titled SettingsGroup panels (reusing the existing section titles). * feat(settings): box Input tab keybinding sections Wrap the in-app and global shortcut lists in titled SettingsGroup panels. * feat(settings): box the Personalisation tab Convert every customizer (sidebar, home, artist, queue toolbar, playlist, player bar) to plain inner containers and wrap each in a titled SettingsGroup, so the boxed look is consistent without nested cards. Box the queue display mode picker too. * feat(settings): box the Themes sections above the store Add a boxed option to the flat Themes sections and apply it to Your Themes, Auto-Switch Theme and Import (the theme store stays unboxed). Drop the inner settings-card from InstalledThemes, ThemeImportSection and the scheduler so the SettingsGroup is the only frame. * fix(settings): give the Themes boxes a card carrier and accent header The flat Themes sections had no settings-card behind them, so the bg-app SettingsGroup had no contrast against the page. Box each above-store section as settings-card > titled SettingsGroup (accent header) like the rest. * fix(settings): clean up the server library sync status line Collapse the offline status to a single icon + phrase ("Server offline — sync deferred") instead of a redundant "Deferred" badge alongside it, and drop the now-unused string across all 9 locales. * fix(queue): keep toolbar toggle buttons coloured active while hovered The generic .queue-round-btn:hover rule outweighed .active in specificity, so an active button kept the hover colour until the pointer left — the toggle only looked on after moving the mouse away. Add an explicit active-hover rule (mirroring the mini player) so active wins immediately on click. * fix(settings): fix Lyrics triple title, drop dead Discord cover keys - Remove LyricsSourcesCustomizer's own section header (the subsection already titles it) and make its inner cards plain; the Lyrics boxes are now title-less. - Drop the dead discordCoverSource/discordCoverSourceDesc i18n keys (superseded by discordCoverTitle/Desc) and un-jam the libraryIndexServer status line in all 9 locales. * refactor(settings): drop redundant group titles and double frames Single-group sections duplicated the subsection title in the group header — make those groups title-less so the subsection header is the only title. A card whose sole child is one group now collapses via CSS so single-group sections render a single frame (matching the card-less Lyrics layout) instead of a card-in-group double border. Multi-group cards keep their frame as the grouping container. * fix(settings): keep the flat Themes cards framed when collapsing single-group cards The single-group card collapse also flattened the Themes section cards, which — not being inside an accordion — are themselves the contrast surface. Exclude .themes-section descendants from the collapse. * refactor(settings): use SettingsToggle for Appearance and System toggle rows Replace the hand-rolled toggle-row markup in the Appearance visual options and System tray/Linux/changelog rows with the shared SettingsToggle component, and extend it with a searchText prop and ReactNode descriptions for the remaining call sites. * refactor(settings): roll SettingsToggle out to Integrations, Audio and Storage Replace hand-rolled toggle rows in the Discord/Bandsintown/Now-Playing, Hi-Res, hot cache and playback behaviour/rate sections with SettingsToggle. Make its label optional (desc-only rows whose title is the group header) and add searchText/id pass-throughs. * refactor(settings): use SettingsToggle for the remaining standard toggle rows Track previews master, sidebar lyrics style, YouLyPlus/static-only, queue display mode and the sidebar split-nav/now-playing/lucky-mix rows now use the shared component. Genuinely custom rows (drag lists, the skip-star threshold, the AudioMuse row with its inline link, the fine-step advanced badge) stay hand-rolled. * fix(settings): drop duplicate titles on Hi-Res/Bandsintown/Now-Playing, un-jam locale line These single-toggle sections kept a group title identical to their subsection header; once the single-group card collapses the title rendered twice stacked. Make them title-less (the subsection header is the label). Also split the discordCoverTitle locale entry onto its own line in all 9 locales. * feat(settings): restore section icons in boxed Themes headers SettingsGroup gained an optional accent icon slot rendered before the title; ThemesTab forwards the Palette/Clock/Upload icons the boxed sections lost when they moved off the bespoke <h2> header. * style(settings): re-indent SettingsGroup children to nesting level Pure whitespace: children wrapped in SettingsGroup were left at their pre-wrap indent. No content change (git diff -w is empty). * fix(settings): clarify Native Hi-Res Playback description The old copy led with the disabled-state behaviour ("forces 44.1 kHz"), which read as if the toggle itself locked output to 44.1 kHz. Describe what enabling actually does: play each track at its native sample rate (reconfiguring the output device to match) instead of resampling to 44.1 kHz. Updated across all 9 locales. * docs: changelog + what's-new for the settings layout refactor (#1126)	2026-06-18 22:24:34 +02:00
Frank Stellmacher	02b2df1589	feat(lyrics): make lyrics fully disablable (independent YouLyPlus toggle) (#855) ... * feat(lyrics): independent YouLyPlus toggle + all-sources-off state Replace the binary lyricsMode ('standard' | 'lyricsplus') with an independent youLyPlusEnabled flag so YouLyPlus and the standard sources are no longer mutually exclusive — turning one off no longer forces the other on. YouLyPlus (when on) is tried first with the enabled sources as fallback; off uses only the enabled sources. When YouLyPlus is off and no source is enabled, useLyrics fetches nothing (issue #810). Fresh installs ship with every source off; the rehydrate migration only restores the old on-by-default set for genuine upgrades, not new installs. * feat(lyrics): YouLyPlus toggle UI + queue 'no sources' hint Settings: single YouLyPlus toggle replacing the two mutually exclusive mode switches; the source list is always visible with a context hint (fallback vs primary). Queue lyric tab shows a hint when no source is active. en + de strings; other locales fall back to en. * docs(changelog): lyrics fully disablable (#855)	2026-05-22 21:06:04 +02:00
Frank Stellmacher	cec175c4bc	refactor(settings): G.53 — extract seven customizer components (#618) ... Pull the 11 self-contained components at the bottom of Settings.tsx out into `src/components/settings/`: - `HomeCustomizer.tsx` — home-page section visibility toggles. - `QueueToolbarCustomizer.tsx` — drag-to-reorder queue toolbar buttons + per-button visibility. Includes the GripHandle + button icons/labels tables. - `SidebarCustomizer.tsx` — sidebar nav drag-reorder for library + system blocks. Includes the GripHandle and the random-nav-mode toggle. - `LyricsSourcesCustomizer.tsx` — lyrics fetch pipeline UI (mode switch + drag-reorder source list + static-only toggle). - `ArtistLayoutCustomizer.tsx` — artist page section drag-reorder. - `BackupSection.tsx` — export/import buttons with toast feedback. - `ServerGripHandle.tsx` — single-purpose grip handle used by the servers tab in the main Settings body. Each component owns its own DnD plumbing, label tables and drop target types. Settings.tsx now only imports the components; one local `ServerDropTarget` type kept inside `Settings()` because the main component still owns the server-list DnD state. Pure code-move. Settings.tsx: 5298 → 4568 LOC (−730). 13 unused imports trimmed (lucide icons, store types, shallow, layout helpers).	2026-05-13 01:28:07 +02:00