mirror of
https://github.com/Psychotoxical/psysonic.git
synced 2026-07-21 14:55:43 +00:00
fix(favorites): reflect player-bar song star in track lists (#1063)
* fix(favorites): reflect player-bar song star in track lists Liking a song from the player bar / fullscreen / shortcuts wrote only to the session `starredOverrides` map, which onStarSuccess deleted once the server sync resolved. List views (AlbumDetail, Favorites, RandomMix, playlists) seed their starred state from a one-shot fetch and reflect later changes only by merging that override, so the row reverted the instant the sync completed — the like never stuck in the list. Toggling from a list row also updated the row's own local state, which is why that direction already worked. Keep the star override as the durable session source of truth (stop deleting it on success); the in-memory Track / queue-cache patches stay. The override is unpersisted and superseded by the next toggle, so it never diverges from the server. Ratings keep their existing clear-on-success behavior.
This commit is contained in:
@@ -349,6 +349,15 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
|
||||
|
||||
|
||||
|
||||
### Favorites — player-bar star stays synced in track lists
|
||||
|
||||
**By [@artplan1](https://github.com/artplan1), PR [#1063](https://github.com/Psychotoxical/psysonic/pull/1063)**
|
||||
|
||||
* Liking a song from the **player bar**, fullscreen player, or global shortcuts now updates the star in album tracklists, playlists, Random Mix, and Favorites — the row no longer reverts the instant the server sync completes.
|
||||
* List views seed starred state from a one-shot fetch and merge session `starredOverrides`; clearing those overrides on sync success had only patched `currentTrack` and the queue cache, so rows fell back to stale fetched values.
|
||||
|
||||
|
||||
|
||||
## [1.47.0]
|
||||
|
||||
> **🙏 Thank you to our amazing Discord community.** This release would not have been possible without your tireless support, quality checks, bug reports and all-round collaboration. Every report, every repro and every bit of feedback shaped what shipped here — thank you. Come join us: [discord.gg/AMnDRErm4u](https://discord.gg/AMnDRErm4u)
|
||||
|
||||
Reference in New Issue
Block a user