itlxrd/Psychotoxical-psysonic
1
0
Fork 0
mirror of https://github.com/Psychotoxical/psysonic.git synced 2026-07-22 07:15:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

revert(orbit): drop maxPending cap feature, keep suggestion mute

Browse Source 
The pending counter desynced from the actual approval list (state.queue
holds approved items as history, so the count never decreased after a
host approve). The host-pushed pendingApprovalCount workaround didn't
hold up under live testing either, so we're rolling the whole cap
feature back rather than ship something flaky.

What's gone:
- OrbitSettings.maxPending + state.pendingApprovalCount
- cap branch in applyOutboxSnapshotsToState (now back to mute-only)
- maxPending number input in settings popover
- pending counter chip in OrbitQueueHead
- 'cap-reached' branch in evaluateOrbitSuggestGate / OrbitSuggestGateReason
- cap-related toasts in ContextMenu / useOrbitSongRowBehavior
- cap-related i18n keys (suggestBlockedCap, settingMaxPending*, pendingCounter*)
- cap CSS (.orbit-queue-head__pending, .orbit-settings-pop__number)

What stays: per-guest suggestion mute (works correctly) and everything
that fed into both features (OrbitState.suggestionBlocked,
setOrbitSuggestionBlocked, evaluateOrbitSuggestGate, the participants
popover Mic/MicOff toggle, the suggestBlockedMuted toast).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Psychotoxical
2026-04-25 01:40:22 +02:00
parent 7c379c2111
commit e4cc54a1b5
16 changed files with 14 additions and 224 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/styles/components.css
-36
View File
@@ -12388,22 +12388,6 @@ html[data-psy-native-hidden="true"] *::after {
.orbit-settings-pop__row--stacked:hover {
background: transparent;
}
.orbit-settings-pop__number {
width: 64px;
padding: 4px 6px;
border-radius: 6px;
background: var(--ctp-surface0, rgba(127, 127, 127, 0.12));
border: 1px solid color-mix(in srgb, var(--text-secondary) 18%, transparent);
color: var(--text-primary);
font-size: 12px;
font-variant-numeric: tabular-nums;
text-align: right;
flex-shrink: 0;
}
.orbit-settings-pop__number:focus {
outline: none;
border-color: var(--accent);
}
.orbit-settings-pop__preset-group {
display: flex;
@@ -12540,26 +12524,6 @@ html[data-psy-native-hidden="true"] *::after {
white-space: nowrap;
min-width: 0;
}
.orbit-queue-head__pending {
display: inline-flex;
align-items: center;
gap: 3px;
margin-left: auto;
padding: 1px 6px;
border-radius: 9px;
background: color-mix(in srgb, var(--accent) 12%, transparent);
border: 1px solid color-mix(in srgb, var(--accent) 28%, transparent);
color: var(--text-secondary);
font-size: 10px;
font-variant-numeric: tabular-nums;
flex-shrink: 0;
}
.orbit-queue-head__pending.is-full {
color: var(--ctp-red, #f38ba8);
background: color-mix(in srgb, var(--ctp-red, #f38ba8) 14%, transparent);
border-color: color-mix(in srgb, var(--ctp-red, #f38ba8) 40%, transparent);
}
.orbit-queue-head__pending svg { color: inherit; }
.orbit-guest-queue__current {
position: relative;