feat(genres): local index genre browse with Subsonic fallback (#937)

* feat(genres): genre detail browse via local index with aligned counts

Move genre detail albums/play/shuffle onto the local library index with
Albums-style in-page scroll, session restore, and genre-scoped stash. Unify
genre album totals between the cloud and detail pages via
library_get_genre_album_counts, and fix grouped browse totals to count
distinct albums rather than matching tracks.

* perf(genres): local genre browse with scoped counts cache

Add dedicated Rust genre album pagination and indexes, slice-mode grid
loading, library-filter-aware counts, and a long-lived in-memory catalog
cache invalidated on sync so genre pages avoid repeated full-library SQL.

* fix(genres): restore scroll after album back; play hold-to-shuffle

Pin restore display count in refs so clearing the return stash no longer
reloads the genre grid mid-restore. Load the first SQL page only (60 rows),
use long-press on Play for shuffle, and add genre play tooltips.

* fix(genres): fall back to Subsonic byGenre when local index unavailable

Genre detail album grid now matches All Albums: try library_list_albums_by_genre
first, then getAlbumsByGenre when the index is off, not ready, or errors.

* docs: add CHANGELOG and credits for PR #937
This commit is contained in:
cucadmuh
2026-06-01 04:20:18 +03:00
committed by GitHub
parent d3e5a6b704
commit ddf10ee01d
42 changed files with 1952 additions and 139 deletions
+36 -6
View File
@@ -1,7 +1,9 @@
import { useLayoutEffect, useRef, useState } from 'react';
import { useLocation, useNavigationType, type NavigationType } from 'react-router-dom';
import {
clearGenreDetailReturnStash,
peekAlbumBrowseScrollRestore,
peekGenreDetailScrollRestore,
type AlbumBrowseSurface,
useAlbumBrowseSessionStore,
} from '../store/albumBrowseSessionStore';
@@ -14,7 +16,10 @@ type PendingScroll = {
export type UseAlbumBrowseScrollRestoreArgs = {
serverId: string;
surface: AlbumBrowseSurface;
/** Album grid browse surface (All Albums, New Releases, Random Albums). */
surface?: AlbumBrowseSurface;
/** Genre detail page — uses genre-scoped stash instead of `surface`. */
genreName?: string;
scrollBodyEl: HTMLElement | null;
displayAlbumsLength: number;
loading: boolean;
@@ -30,12 +35,29 @@ export type UseAlbumBrowseScrollRestoreResult = {
function readPendingScrollRestore(
serverId: string,
surface: AlbumBrowseSurface,
surface: AlbumBrowseSurface | undefined,
genreName: string | undefined,
navigationType: NavigationType,
locationState: unknown,
): PendingScroll | null {
if (!shouldRestoreAlbumBrowseSession(navigationType, locationState) || !serverId) return null;
return peekAlbumBrowseScrollRestore(serverId, surface);
if (genreName) return peekGenreDetailScrollRestore(serverId, genreName);
if (surface) return peekAlbumBrowseScrollRestore(serverId, surface);
return null;
}
function clearScrollRestoreStash(
serverId: string,
surface: AlbumBrowseSurface | undefined,
genreName: string | undefined,
): void {
if (genreName) {
clearGenreDetailReturnStash(serverId, genreName);
return;
}
if (surface) {
useAlbumBrowseSessionStore.getState().clearReturnStash(serverId, surface);
}
}
/**
@@ -45,6 +67,7 @@ function readPendingScrollRestore(
export function useAlbumBrowseScrollRestore({
serverId,
surface,
genreName,
scrollBodyEl,
displayAlbumsLength,
loading,
@@ -60,11 +83,17 @@ export function useAlbumBrowseScrollRestore({
if (!initRef.current) {
initRef.current = true;
pendingRef.current = readPendingScrollRestore(serverId, surface, navigationType, location.state);
pendingRef.current = readPendingScrollRestore(
serverId,
surface,
genreName,
navigationType,
location.state,
);
}
const [isScrollRestorePending, setIsScrollRestorePending] = useState(
() => readPendingScrollRestore(serverId, surface, navigationType, location.state) !== null,
() => readPendingScrollRestore(serverId, surface, genreName, navigationType, location.state) !== null,
);
useLayoutEffect(() => {
@@ -84,7 +113,7 @@ export function useAlbumBrowseScrollRestore({
pendingRef.current = null;
doneRef.current = true;
setIsScrollRestorePending(false);
useAlbumBrowseSessionStore.getState().clearReturnStash(serverId, surface);
clearScrollRestoreStash(serverId, surface, genreName);
}, [
scrollBodyEl,
displayAlbumsLength,
@@ -94,6 +123,7 @@ export function useAlbumBrowseScrollRestore({
loadMore,
serverId,
surface,
genreName,
]);
return { isScrollRestorePending };