fix(playback): cross-server browse, Lucky Mix, and Now Playing (#768)

* fix(playback): keep browsed server when queue plays elsewhere

Lucky Mix on a non-playback server now clears the old queue and pins
the active server before building. Now Playing metadata uses
apiForServer against the queue server instead of forcing
ensurePlaybackServerActive on every activeServerId change.

* docs: note PR #768 in CHANGELOG and settings credits

* fix(now-playing): gate AudioMuse similar artists on playback server

Match getArtistInfoForServer credentials: when browsing another server
while the queue plays elsewhere, similar-artist count follows the queue
server's AudioMuse flag, not the browsed server.
This commit is contained in:
cucadmuh
2026-05-18 11:40:46 +03:00
committed by GitHub
parent 6e0f076f43
commit db98d30a78
16 changed files with 253 additions and 91 deletions
+15 -3
View File
@@ -11,6 +11,10 @@ import { usePlayerStore } from '../../store/playerStore';
import { useLuckyMixStore } from '../../store/luckyMixStore';
import { isLuckyMixAvailable } from '../../hooks/useLuckyMixAvailable';
import { showToast } from '../ui/toast';
import {
playbackServerDiffersFromActive,
prepareActiveServerForNewMix,
} from '../playback/playbackServer';
import {
filterSongsForLuckyMixRatings,
filterTopArtistsForMixRatings,
@@ -74,6 +78,7 @@ export async function buildAndPlayLuckyMix(): Promise<void> {
showLuckyMixMenu: auth.showLuckyMixMenu,
libraryFilter: activeServerId ? (auth.musicLibraryFilterByServer[activeServerId] ?? 'all') : 'all',
mixRatingFilter: mixRatingCfg,
crossServerPlayback: playbackServerDiffersFromActive(),
});
if (!available) {
logStep('abort_unavailable');
@@ -96,9 +101,16 @@ export async function buildAndPlayLuckyMix(): Promise<void> {
let unsubPlayer: (() => void) | null = null;
try {
// Drop the old "upcoming" tail immediately so the queue UI does not show stale
// next tracks while the mix is still building (first playTrack may be delayed).
usePlayerStore.getState().pruneUpcomingToCurrent(true);
// Browsed server ≠ queue server: stop A's stream so Now Playing does not call
// ensurePlaybackServerActive() and revert the UI mid-build.
if (playbackServerDiffersFromActive()) {
prepareActiveServerForNewMix();
logStep('cross_server_handoff', { activeServerId });
} else {
// Drop the old "upcoming" tail so the queue UI does not show stale next
// tracks while the mix is still building (first playTrack may be delayed).
usePlayerStore.getState().pruneUpcomingToCurrent(true);
}
lucky.start();
let startedPlayback = false;