itlxrd/Psychotoxical-psysonic
1
0
Fork 0
mirror of https://github.com/Psychotoxical/psysonic.git synced 2026-07-21 23:05:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(queue): resolve queue rows on scroll so off-window items stop showing '…' (#1236)

Browse Source
This commit is contained in:
cucadmuh
2026-07-05 14:07:16 +03:00
committed by GitHub
parent 32a21ec2c3
commit db645ca72f
7 changed files with 169 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/features/queue/components/QueueList.tsx
+18
View File
@@ -13,7 +13,9 @@ import { resolveQueueTrack } from '@/features/playback/store/queueTrackView';
import {
getQueueResolverVersion,
subscribeQueueResolver,
resolveBatch,
} from '@/features/playback/store/queueTrackResolver';
import { collectQueueResolveRefs } from '@/features/queue/utils/collectQueueResolveRefs';
import { findQueueItemRefIndex } from '@/features/playback/utils/playback/queueIdentity';
import type { TimelineDisplayRow } from '@/features/playback/utils/buildTimelineDisplayRows';
import { findTimelineScrollLocalIndex } from '@/features/playback/utils/buildTimelineDisplayRows';
@@ -77,6 +79,22 @@ export function QueueList({
const virtualItems = rowVirtualizer.getVirtualItems();
const totalSize = rowVirtualizer.getTotalSize();
// Resolve the rows the user is actually looking at (queue thin-state). The
// queueResolverBridge only warms a window around the *playing* index; scrolling
// the queue independently would otherwise leave rows stuck on the '…'
// placeholder (cache miss / evicted from the bounded LRU). Drive resolution off
// the virtualizer's visible range so any scrolled-to row fetches on demand.
const firstVisible = virtualItems.length > 0 ? virtualItems[0]!.index : 0;
const lastVisible = virtualItems.length > 0 ? virtualItems[virtualItems.length - 1]!.index : 0;
useEffect(() => {
if (rowCount === 0) return;
const refs = collectQueueResolveRefs({ usingTimeline, timelineRows, queue, firstVisible, lastVisible });
if (refs.length > 0) void resolveBatch(refs);
// Keyed on the visible range + mode; the resolver dedups against cache/in-flight,
// so re-running on scroll is cheap. Queue-content changes are covered by the bridge.
// eslint-disable-next-line react-hooks/exhaustive-deps
}, [firstVisible, lastVisible, rowCount, usingTimeline]);
useEffect(() => {
if (suppressNextAutoScrollRef.current) {
suppressNextAutoScrollRef.current = false;