fix(cards): selection ring clipping on browse grids (WebKitGTK) (#962)

* fix(artists): inset selection ring on grid cards, stop composer hover clip

Artist multi-select used a positive outline-offset that clipped in the
first grid row and sat outside the card border on hover. Match album
cards with an inset ring; drop composer-card hover translateY that
sheared the top edge in the in-page scrollport.

Reported by zunoz (v1.47.0-rc.3).

* fix(cards): selection ring via inset ::after overlay on WebKitGTK grids

Replace outline-based multi-select rings on album/artist/playlist cards
with the same inset ::after box-shadow pattern used for card focus rings
(card.css) — avoids clipping and the 1px gap vs the inner border on
overflow:hidden tiles in All Albums and related browse grids.

* docs: note browse grid selection ring fix in CHANGELOG (PR #962)

* docs(changelog): credit zunoz on Psysonic Discord for PR #962
This commit is contained in:
cucadmuh
2026-06-03 22:38:57 +03:00
committed by GitHub
parent a07e8e9593
commit c683b5e37b
6 changed files with 44 additions and 17 deletions
+7
View File
@@ -436,6 +436,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
* Scoped search on Composers no longer replaces the Navidrome role-scoped catalog with generic artist index/search3 hits that merge split composer credits into one joined name and id — results stay split like the scroll overview. * Scoped search on Composers no longer replaces the Navidrome role-scoped catalog with generic artist index/search3 hits that merge split composer credits into one joined name and id — results stay split like the scroll overview.
### Browse grids — multi-select ring no longer clips (WebKitGTK)
**By [@cucadmuh](https://github.com/cucadmuh), reported by zunoz on the Psysonic Discord, PR [#962](https://github.com/Psychotoxical/psysonic/pull/962)**
* Multi-select rings on Artists, All Albums, Playlists, and related card grids use an inset `::after` overlay (same approach as card focus rings) instead of `outline` on `overflow: hidden` tiles — fixes top-row clipping and the ~1px gap vs the inner border on Wayland/WebKitGTK.
### In-page browse — virtual scroll and cover-art priority ### In-page browse — virtual scroll and cover-art priority
**By [@cucadmuh](https://github.com/cucadmuh), PR [#783](https://github.com/Psychotoxical/psysonic/pull/783)** **By [@cucadmuh](https://github.com/cucadmuh), PR [#783](https://github.com/Psychotoxical/psysonic/pull/783)**
+1 -6
View File
@@ -24,7 +24,7 @@ type TilePropsShared = Omit<TileProps, 'artist'>;
function ArtistGridTile({ artist, ...rest }: TileProps) { function ArtistGridTile({ artist, ...rest }: TileProps) {
return ( return (
<div <div
className={`artist-card${rest.selectionMode && rest.selectedIds.has(artist.id) ? ' selected' : ''}${rest.selectionMode ? ' artist-card--selectable' : ''}`} className={`artist-card${rest.selectionMode ? ' artist-card--selectable' : ''}${rest.selectionMode && rest.selectedIds.has(artist.id) ? ' artist-card--selected' : ''}`}
onClick={() => { onClick={() => {
if (rest.selectionMode) { if (rest.selectionMode) {
rest.toggleSelect(artist.id); rest.toggleSelect(artist.id);
@@ -40,11 +40,6 @@ function ArtistGridTile({ artist, ...rest }: TileProps) {
rest.openContextMenu(e.clientX, e.clientY, artist, 'artist'); rest.openContextMenu(e.clientX, e.clientY, artist, 'artist');
} }
}} }}
style={rest.selectionMode && rest.selectedIds.has(artist.id) ? {
outline: '2px solid var(--accent)',
outlineOffset: '2px',
borderRadius: 'var(--radius-md)',
} : {}}
> >
{rest.selectionMode && ( {rest.selectionMode && (
<div className={`artist-card-select-check${rest.selectedIds.has(artist.id) ? ' artist-card-select-check--on' : ''}`}> <div className={`artist-card-select-check${rest.selectedIds.has(artist.id) ? ' artist-card-select-check--on' : ''}`}>
+1 -7
View File
@@ -43,7 +43,7 @@ export default function PlaylistCard({
return ( return (
<div <div
className={`album-card${selectionMode && selectedIds.has(pl.id) ? ' selected' : ''}`} className={`album-card${selectionMode && selectedIds.has(pl.id) ? ' album-card--selected' : ''}`}
onClick={(e) => { onClick={(e) => {
if (selectionMode) { if (selectionMode) {
toggleSelect(pl.id, { shiftKey: e.shiftKey }); toggleSelect(pl.id, { shiftKey: e.shiftKey });
@@ -60,12 +60,6 @@ export default function PlaylistCard({
} }
}} }}
onMouseLeave={() => { if (deleteConfirmId === pl.id) setDeleteConfirmId(null); }} onMouseLeave={() => { if (deleteConfirmId === pl.id) setDeleteConfirmId(null); }}
style={selectionMode && selectedIds.has(pl.id) ? {
position: 'relative',
outline: '2px solid var(--accent)',
outlineOffset: '2px',
borderRadius: 'var(--radius-md)'
} : { position: 'relative' }}
> >
{!selectionMode && ( {!selectionMode && (
<div className="playlist-card-actions"> <div className="playlist-card-actions">
+16 -3
View File
@@ -346,8 +346,21 @@
} }
.album-card--selected { .album-card--selected {
outline: 2px solid var(--accent); outline: none;
outline-offset: -2px; }
/* Inset overlay ring — same approach as `.card:focus-visible::after` in card.css:
outline + overflow:hidden clips on WebKitGTK/Wayland; inset box-shadow on ::after
paints above the cover without growing the card box. */
.album-card--selected::after,
.album-card.selected::after {
content: '';
position: absolute;
inset: 0;
border-radius: inherit;
box-shadow: inset 0 0 0 2px var(--accent);
z-index: 4;
pointer-events: none;
} }
.album-card-select-check { .album-card-select-check {
@@ -362,7 +375,7 @@
display: flex; display: flex;
align-items: center; align-items: center;
justify-content: center; justify-content: center;
z-index: 3; z-index: 5;
pointer-events: none; pointer-events: none;
} }
@@ -25,6 +25,25 @@
color: var(--ctp-crust); color: var(--ctp-crust);
} }
.artist-card--selectable {
cursor: pointer;
}
/* Inset overlay ring — see `.album-card--selected::after` / `.card:focus-visible::after`. */
.artist-card--selected {
outline: none;
}
.artist-card--selected::after {
content: '';
position: absolute;
inset: 0;
border-radius: inherit;
box-shadow: inset 0 0 0 2px var(--accent);
z-index: 4;
pointer-events: none;
}
/* ── Albums selection bar (portal) ── */ /* ── Albums selection bar (portal) ── */
.albums-selection-bar { .albums-selection-bar {
position: fixed; position: fixed;
@@ -34,7 +34,6 @@
.composer-card:hover { .composer-card:hover {
border-color: var(--accent); border-color: var(--accent);
background: var(--bg-hover); background: var(--bg-hover);
transform: translateY(-1px);
box-shadow: 0 4px 12px -6px rgba(0, 0, 0, 0.4); box-shadow: 0 4px 12px -6px rgba(0, 0, 0, 0.4);
} }