itlxrd/Psychotoxical-psysonic
1
0
Fork 0
mirror of https://github.com/Psychotoxical/psysonic.git synced 2026-07-22 15:25:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(app-shell): I.1 — split AppShell.tsx 691 → 248 LOC across 12 files (#671)

Browse Source 
* refactor(app-shell): extract appShellHelpers.ts

Move SIDEBAR_COLLAPSED_STORAGE_KEY + read/persist helpers and the
shouldSuppressQueueResizerMouseDown geometry helper out of AppShell.tsx
into utils/appShellHelpers.ts.

AppShell.tsx: 691 → 639 LOC.

* refactor(app-shell): extract usePlatformShellSetup hook

Bundle the one-shot platform/window-shell effects (tiling-WM detection,
no-compositing class, data-platform attr, custom titlebar sync, kinetic
scroll toggle, logging mode push) into hooks/usePlatformShellSetup.ts.
Returns isTilingWm so AppShell can still gate the custom titlebar.

AppShell.tsx: 639 → 604 LOC.

* refactor(app-shell): extract 5 lifecycle hooks

Pull these effect islands into hooks/:
- useOrbitBodyAttrs       — orbit role/phase → <html data-orbit-*> attrs
- useWindowFullscreenState — Tauri isFullscreen() tracker
- useNowPlayingTrayTitle  — title + tray tooltip sync
- useTrayMenuI18n         — tray menu labels via i18n
- useServerCapabilitiesProbe — music folders + rating support + orbit
                              orphan sweep on login

AppShell.tsx: 604 → 497 LOC.

* refactor(app-shell): extract useQueueResizer hook

Bundle queueWidth state, drag listeners, sidebar-aligned handle position,
and the click-vs-drag mousedown handler into hooks/useQueueResizer.ts.
AppShell drops shouldSuppressQueueResizerMouseDown wiring and 4 local
state pieces.

AppShell.tsx: 497 → 403 LOC.

* refactor(app-shell): extract 4 misc lifecycle hooks

- useGlobalDndAndSelectionBlockers — document-level DnD/select-all/
  selectstart blockers (Linux/WebKitGTK + Wayland workarounds).
- useAppActivityTracking — <html data-app-hidden> + <html data-app-blurred>
  so CSS can pause cosmetic animation when the app isn't being looked at.
- useMainScrollingIndicator — scroll-idle tracker for main + np viewports.
- useOfflineAutoNav — connStatus transitions push to /offline or back.

AppShell.tsx: 403 → 282 LOC.

* refactor(app-shell): extract AppShellQueueResizerSeam subcomponent

The 6px resizer strip and the round resize/toggle handle (~50 LOC of JSX
with embedded scrollbar-collision suppression + self-heal logic) move
into components/AppShellQueueResizerSeam.tsx. Desktop-only.

AppShell.tsx: 282 → 248 LOC.
This commit is contained in:
Frank Stellmacher
2026-05-13 23:48:03 +02:00
committed by GitHub
parent 988806e6b1
commit b591a1cb5f
14 changed files with 738 additions and 488 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/hooks/useOrbitBodyAttrs.ts
+25
View File
@@ -0,0 +1,25 @@
import { useEffect } from 'react';
import { useOrbitStore } from '../store/orbitStore';
/**
* Mirror the live Orbit role + phase onto `<html data-orbit-active>` and
* `<html data-orbit-role>` so global CSS can hide controls that conflict
* with an active Orbit session (e.g. track preview steps on shared
* playback) or style host-vs-guest UI states (read-only guest seekbar).
* Covers any pre-`active` phase so the marker spans the join lifecycle.
*/
export function useOrbitBodyAttrs(): void {
const orbitRole = useOrbitStore(s => s.role);
const orbitPhase = useOrbitStore(s => s.phase);
useEffect(() => {
const inOrbit = (orbitRole === 'host' || orbitRole === 'guest')
&& (orbitPhase === 'active' || orbitPhase === 'joining' || orbitPhase === 'starting');
if (inOrbit) {
document.documentElement.setAttribute('data-orbit-active', 'true');
document.documentElement.setAttribute('data-orbit-role', orbitRole as string);
} else {
document.documentElement.removeAttribute('data-orbit-active');
document.documentElement.removeAttribute('data-orbit-role');
}
}, [orbitRole, orbitPhase]);
}