Perf/UI cover cache mainstage (#468)

* Enhance CachedImage and ArtistDetail components with improved image caching and priority handling

- Refactor CachedImage to utilize a priority system for image loading based on viewport visibility, improving performance during scrolling.
- Update useCachedUrl to accept an optional getPriority function for better cache management.
- Optimize ArtistDetail and Artists components by using useMemo for cover art URLs, reducing redundant calculations and improving rendering efficiency.
- Adjust image loading logic in CachedImage to ensure smoother transitions and avoid unnecessary fetch requests.

* perf(ui): unblock IDB cover art, stabilize mainstage rails and virtual lists

Let IndexedDB reads bypass the network concurrency slot so cached thumbnails
paint without queueing behind remote fetches; debounce disk eviction during
heavy scrolling.

Fix mainstage horizontal rails: dedupe album/song ids for React keys, widen
artwork budget overscan, avoid resetting the budget on list append, and raise
Home initial artwork budgets. CachedImage treats already-decoded images as
loaded; rail cards load cover images eagerly.

Refresh dynamic color extraction and extend virtual scrolling / scroll roots on
Albums, Artists, Playlists, and related surfaces.


Remove local agent-only commit instructions from the repository tree.

* perf(virtual): viewport-based overscan for main scroll lists

Drive TanStack Virtual overscan from measured scroll height so each list
renders about one screen of extra rows above and below the viewport for
snappier scrolling on Albums, Artists (list mode), and Tracks virtual song list.

Introduce useResizeClientHeight helpers (ID + ref) for ResizeObserver-based
clientHeight tracking.

* docs(changelog): note PR #468 UI cover cache, rails, and virtual lists

Add a coarse summary under 1.46.0 Changed for cover-art pipeline,
mainstage rails, viewport-based overscan, and library/chrome polish.
This commit is contained in:
cucadmuh
2026-05-06 00:15:58 +03:00
committed by GitHub
parent d8d8a76e0f
commit 9d30285ff1
23 changed files with 895 additions and 279 deletions
+93 -33
View File
@@ -117,49 +117,109 @@ export function ensureContrast(
const FS_BG_LUMINANCE = 0.010;
const MIN_CONTRAST = 4.5;
function isRemoteHttpUrl(url: string): boolean {
return /^https?:\/\//i.test(url);
}
function isBlobOrDataUrl(url: string): boolean {
return url.startsWith('blob:') || url.startsWith('data:');
}
/**
* Samples decoded pixels from an HTMLImageElement (already loaded).
* Throws if the canvas is tainted (caller should catch).
*/
function sampleImageToAccent(img: HTMLImageElement): CoverColors {
const canvas = document.createElement('canvas');
canvas.width = 8;
canvas.height = 8;
const ctx = canvas.getContext('2d');
if (!ctx) return { accent: '' };
ctx.drawImage(img, 0, 0, 8, 8);
const { data } = ctx.getImageData(0, 0, 8, 8);
let bestSat = -1;
let bestR = 180;
let bestG = 100;
let bestB = 50;
for (let i = 0; i < data.length; i += 4) {
const r = data[i];
const g = data[i + 1];
const b = data[i + 2];
const [, s] = rgbToHsl(r, g, b);
if (s > bestSat) {
bestSat = s;
bestR = r;
bestG = g;
bestB = b;
}
}
const [fr, fg, fb] = ensureContrast([bestR, bestG, bestB], FS_BG_LUMINANCE, MIN_CONTRAST);
return { accent: `rgb(${fr},${fg},${fb})` };
}
function loadImage(url: string, crossOrigin: '' | 'anonymous'): Promise<HTMLImageElement> {
return new Promise((resolve, reject) => {
const img = new Image();
img.onload = () => resolve(img);
img.onerror = () => reject(new Error('image load failed'));
if (crossOrigin) img.crossOrigin = crossOrigin;
img.src = url;
});
}
/**
* Loads `imageUrl` into an 8×8 canvas and finds the most vibrant pixel
* (highest HSL saturation). Applies `ensureContrast` to guarantee
* WCAG AA readability against the FS player background.
*
* Remote `https?://` URLs would taint a canvas if drawn from a plain `<img>`
* without CORS — we prefer `fetch` → `blob:` for sampling, then fall back to
* `crossOrigin = "anonymous"` when the server allows it.
*
* Resolves with `{ accent: '' }` on any error — the caller's CSS
* `var(--dynamic-fs-accent, var(--accent))` then falls back to the theme accent.
*/
export function extractCoverColors(imageUrl: string): Promise<CoverColors> {
if (!imageUrl) return Promise.resolve({ accent: '' });
// Logo fallback has no meaningful color — skip extraction and use theme accent
if (imageUrl.includes('logo-psysonic')) return Promise.resolve({ accent: '' });
export async function extractCoverColors(imageUrl: string): Promise<CoverColors> {
if (!imageUrl) return { accent: '' };
if (imageUrl.includes('logo-psysonic')) return { accent: '' };
return new Promise(resolve => {
const img = new Image();
// Blob URLs are same-origin in Tauri WebKit — no crossOrigin needed.
img.onload = () => {
const safeSample = async (url: string, co: '' | 'anonymous'): Promise<CoverColors> => {
try {
const img = await loadImage(url, co);
try {
const canvas = document.createElement('canvas');
canvas.width = 8;
canvas.height = 8;
const ctx = canvas.getContext('2d');
if (!ctx) { resolve({ accent: '' }); return; }
ctx.drawImage(img, 0, 0, 8, 8);
const { data } = ctx.getImageData(0, 0, 8, 8);
// Pick pixel with highest HSL saturation (most vibrant).
let bestSat = -1;
let bestR = 180, bestG = 100, bestB = 50; // warm orange fallback
for (let i = 0; i < data.length; i += 4) {
const r = data[i], g = data[i + 1], b = data[i + 2];
const [, s] = rgbToHsl(r, g, b);
if (s > bestSat) { bestSat = s; bestR = r; bestG = g; bestB = b; }
}
const [fr, fg, fb] = ensureContrast([bestR, bestG, bestB], FS_BG_LUMINANCE, MIN_CONTRAST);
resolve({ accent: `rgb(${fr},${fg},${fb})` });
return sampleImageToAccent(img);
} catch {
resolve({ accent: '' });
return { accent: '' };
}
};
img.onerror = () => resolve({ accent: '' });
img.src = imageUrl;
});
} catch {
return { accent: '' };
}
};
if (isBlobOrDataUrl(imageUrl)) {
return safeSample(imageUrl, '');
}
if (isRemoteHttpUrl(imageUrl)) {
try {
const resp = await fetch(imageUrl);
if (resp.ok) {
const blob = await resp.blob();
const objectUrl = URL.createObjectURL(blob);
try {
return await safeSample(objectUrl, '');
} finally {
URL.revokeObjectURL(objectUrl);
}
}
} catch {
// CORS / network — try credentialed image load if server sends ACAO for art
}
return safeSample(imageUrl, 'anonymous');
}
return safeSample(imageUrl, '');
}