chore(eslint): add ESLint toolchain and clean src to strict 0/0 (#1165)

* chore(eslint): add eslint toolchain and configs

* fix(eslint): resolve gradual-config errors (rules-of-hooks, no-empty, prefer-const, …)

* chore(eslint): clear unused vars in config, contexts, app and test

* chore(eslint): clear unused vars in api and music-network

* chore(eslint): clear unused vars in utils

* chore(eslint): clear unused vars in store

* chore(eslint): clear unused vars in cover and hooks

* chore(eslint): clear unused vars in components

* chore(eslint): clear unused vars in pages

* chore(eslint): remove explicit any in src

* chore(eslint): align react-hooks exhaustive-deps

* chore(eslint): zero gradual config on src

* chore(eslint): strict hook rules in store and utils

* chore(eslint): strict hook rules in hooks and cover

* chore(eslint): strict hook rules in components

* chore(eslint): strict hook rules in pages and contexts

* chore(eslint): document scripts ignore in eslint config

* chore(eslint): add lint script and zero strict findings

* chore(eslint): address review round 1 (gradual 0/0, per-site disable reasons)

* chore(eslint): tighten two set-state disable comments (review round 2 LOW)

* chore(nix): sync npmDepsHash with package-lock.json

* docs(changelog): add Under the Hood entry for ESLint setup (PR #1165)

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

src/components/favorites/FavoritesSongsSectionHeader.tsx

@@ -140,6 +140,8 @@ export default function FavoritesSongsSectionHeader({
               </button>
               {showPlPicker && (
                 <AddToPlaylistSubmenu
+                  // React Compiler refs rule: ref read imperatively outside reactive rendering; not used to compute the render output.
+                  // eslint-disable-next-line react-hooks/refs
                   songIds={pickerSongIdsRef.current}
                   resolveSongIds={() => pickerSongIdsRef.current}
                   onDone={() => { setShowPlPicker(false); useSelectionStore.getState().clearAll(); }}

src/components/favorites/FavoritesSongsTracklist.tsx

@@ -142,6 +142,9 @@ export default function FavoritesSongsTracklist({
   const [scrollMargin, setScrollMargin] = useState(0);
   const viewportH = useElementClientHeightById(APP_MAIN_SCROLL_VIEWPORT_ID);
 
+  // Bulk bar show/hide shifts listWrapRef top — remeasure on that edge only.
+  const bulkBarVisible = selectedIds.size > 0;
+
   useLayoutEffect(() => {
     const sc = document.getElementById(APP_MAIN_SCROLL_VIEWPORT_ID);
     // scrollMargin must track height changes in sections above the list (filters, top artists).
@@ -159,9 +162,10 @@ export default function FavoritesSongsTracklist({
     if (root) ro.observe(root);
     measure();
     return () => ro.disconnect();
-  // selectedIds.size > 0 (boolean): bulk bar show/hide shifts listWrapRef top — remeasure on that edge only.
-  }, [tracklistRef, selectedIds.size > 0, pickerOpen, visibleSongs.length]);
+  }, [tracklistRef, bulkBarVisible, pickerOpen, visibleSongs.length]);
 
+  // React Compiler incompatible-library rule: third-party hook/value the compiler cannot analyze; usage is correct.
+  // eslint-disable-next-line react-hooks/incompatible-library
   const rowVirtualizer = useVirtualizer({
     count: visibleSongs.length,
     getScrollElement: () => document.getElementById(APP_MAIN_SCROLL_VIEWPORT_ID),

src/components/favorites/TopFavoriteArtists.tsx

@@ -1,7 +1,6 @@
 import React, { useEffect, useRef, useState } from 'react';
 import { useTranslation } from 'react-i18next';
 import { ChevronLeft, ChevronRight, Users } from 'lucide-react';
-import { CoverArtImage } from '../../cover/CoverArtImage';
 import { ArtistCoverArtImage } from '../../cover/ArtistCoverArtImage';
 import { COVER_DENSE_GRID_MIN_CELL_CSS_PX } from '../../cover/layoutSizes';
 import { coverServerScopeForServerId } from '../../cover/serverScope';