From 61430e147d7820d0bb7bd34d168aa61e32c9ce96 Mon Sep 17 00:00:00 2001
From: cucadmuh <49571317+cucadmuh@users.noreply.github.com>
Date: Fri, 1 May 2026 23:06:27 +0300
Subject: [PATCH] fix(release): create releases from verified tags without
 target_commitish (#410)

Use gh release create --verify-tag and remove target_commitish from release payload
now that tags are created upfront. This avoids server-side untagged release fallback
while preserving deterministic tag-to-release publication.
---
 .../workflows/reusable-channel-publish.yml    | 20 ++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/.github/workflows/reusable-channel-publish.yml b/.github/workflows/reusable-channel-publish.yml
index a4eac02c..29009da2 100644
--- a/.github/workflows/reusable-channel-publish.yml
+++ b/.github/workflows/reusable-channel-publish.yml
@@ -191,12 +191,11 @@ jobs:
 
           jq -n \
             --arg tag "$TAG" \
-            --arg target_commitish "$TARGET_COMMITISH" \
             --arg name "$RELEASE_NAME" \
             --rawfile body "$BODY_FILE" \
             --argjson draft "$([[ "${IS_DRAFT}" == "true" ]] && echo true || echo false)" \
             --argjson prerelease "$([[ "${IS_PRERELEASE}" == "true" ]] && echo true || echo false)" \
-            '{tag_name:$tag,target_commitish:$target_commitish,name:$name,body:$body,draft:$draft,prerelease:$prerelease}' > /tmp/release-payload.json
+            '{tag_name:$tag,name:$name,body:$body,draft:$draft,prerelease:$prerelease}' > /tmp/release-payload.json
 
           RELEASE_ID=""
           # 1) Preferred lookup: by tag
@@ -211,10 +210,21 @@ jobs:
             gh api --method PATCH "repos/${GITHUB_REPOSITORY}/releases/${RELEASE_ID}" --input /tmp/release-payload.json >/dev/null
             echo "Updated existing release id=${RELEASE_ID} for tag ${TAG}"
           else
-            gh api --method POST "repos/${GITHUB_REPOSITORY}/releases" --input /tmp/release-payload.json >/tmp/release-created.json
-            RELEASE_ID="$(jq -r '.id' /tmp/release-created.json)"
+            EXTRA_FLAGS=()
+            if [[ "${IS_DRAFT}" == "true" ]]; then
+              EXTRA_FLAGS+=(--draft)
+            fi
+            if [[ "${IS_PRERELEASE}" == "true" ]]; then
+              EXTRA_FLAGS+=(--prerelease)
+            fi
+            gh release create "$TAG" \
+              --verify-tag \
+              --title "$RELEASE_NAME" \
+              --notes-file "$BODY_FILE" \
+              "${EXTRA_FLAGS[@]}"
+            RELEASE_ID="$(gh api "repos/${GITHUB_REPOSITORY}/releases/tags/${TAG}" --jq '.id' || true)"
             if [[ -z "${RELEASE_ID:-}" || ! "$RELEASE_ID" =~ ^[0-9]+$ ]]; then
-              echo "::error::Release create response missing numeric id"
+              echo "::error::Release created but failed to resolve numeric id for tag '${TAG}'"
               exit 1
             fi
             echo "Created release id=${RELEASE_ID} for tag ${TAG}"