refactor(format): consolidate duration formatters into format/formatDuration (Phase L, part 2) (#690)

mirror of https://github.com/Psychotoxical/psysonic.git synced 2026-07-21 23:05:46 +00:00

The mm:ss track-time formatter was hand-rolled in 11 places and the
h:mm:ss total-duration formatter in 4 — extract two tested functions:

- formatTrackTime(seconds, fallback='0:00')  — m:ss, used for track /
  playback times. fallback param covers the '–' placeholder rows.
- formatLongDuration(seconds)                — h:mm:ss when >=1h, else
  m:ss, used for album / queue totals.

Behaviour preserved per call site: the unified guard
(!seconds || !isFinite || <0 -> fallback) produces identical output to
every prior variant for all real inputs; SongRow keeps its '–' via the
fallback arg. Removes the formatter exports from 6 componentHelpers
files (playerBarHelpers / fullscreenPlayerHelpers deleted — they only
exported the formatter) and 7 inline component copies.

+ formatDuration.test.ts

This commit is contained in:

Frank Stellmacher

2026-05-14 14:50:10 +02:00

committed by

GitHub

parent 7a7a9f5e6b

commit 5231169a71

34 changed files with 139 additions and 138 deletions

									
										src/pages/PlaylistDetail.tsx
									
		-1
	
												View File
												
				@@ -20,7 +20,6 @@ import { useDragDrop } from '../contexts/DragDropContext';

				import { useTranslation } from 'react-i18next';

				import StarRating from '../components/StarRating';

				import {

				  formatDuration,

				  formatSize,

				  totalDurationLabel,

				  isSmartPlaylistName,