feat(hero): prev / next arrows on the Mainstage featured strip (#735)

* feat(hero): prev / next arrows on the Mainstage featured strip

Adds left and right chevron buttons over the featured-album hero so a
single click flips to the previous / next album. Hitting the 8 px dot
indicators was awkward and often opened the underlying album by
mistake; the arrows give a generous 44 px touch target on each edge.

- New `goPrev` / `goNext` callbacks wrap with modulo, restart the
  auto-advance timer on click (same pattern the old dot handler used).
- Buttons live in a new `.hero-nav` flex wrapper with `inset: 0` and
  `justify-content: space-between`, so they pin to the hero's left and
  right edges regardless of theme padding. `pointer-events: none` on
  the wrapper + `auto` on the buttons keeps the rest of the hero
  click-through (navigate to album).
- Dots are now decorative spans, not buttons — `pointer-events: none`,
  no hover state, no `onClick`. Clicking near a dot used to navigate
  to the album because the dot was too small to land on.
- i18n: `previousAlbum` / `nextAlbum` keys in all 9 locales.

Reported by zunoz on Discord.

* docs(changelog): note Mainstage hero prev / next arrows (#735)
This commit is contained in:
Frank Stellmacher
2026-05-16 13:43:09 +02:00
committed by GitHub
parent 2233e8fb91
commit 31abdc03ef
12 changed files with 109 additions and 21 deletions
+43 -14
View File
@@ -4,7 +4,7 @@ import type { SubsonicAlbum } from '../api/subsonicTypes';
import { songToTrack } from '../utils/playback/songToTrack';
import React, { useEffect, useState, useRef, useCallback, useMemo } from 'react';
import { useNavigate } from 'react-router-dom';
import { Play, ListPlus } from 'lucide-react';
import { Play, ListPlus, ChevronLeft, ChevronRight } from 'lucide-react';
import CachedImage, { useCachedUrl } from './CachedImage';
import { usePlayerStore } from '../store/playerStore';
import { useTranslation } from 'react-i18next';
@@ -224,9 +224,18 @@ export default function Hero({ albums: albumsProp }: HeroProps = {}) {
};
}, [albums.length, heroInView, startTimer]);
const goTo = useCallback((idx: number) => {
setActiveIdx(idx);
startTimer(albums.length);
const goPrev = useCallback(() => {
const len = albums.length;
if (len <= 1) return;
setActiveIdx(prev => (prev - 1 + len) % len);
startTimer(len);
}, [albums.length, startTimer]);
const goNext = useCallback(() => {
const len = albums.length;
if (len <= 1) return;
setActiveIdx(prev => (prev + 1) % len);
startTimer(len);
}, [albums.length, startTimer]);
const album = albums[activeIdx] ?? null;
@@ -346,18 +355,38 @@ export default function Hero({ albums: albumsProp }: HeroProps = {}) {
</div>
</div>
{/* Carousel dot indicators */}
{/* Carousel navigation arrows + decorative dot indicators */}
{albums.length > 1 && (
<div className="hero-dots" onClick={e => e.stopPropagation()}>
{albums.map((_, i) => (
<>
<div className="hero-nav" aria-hidden="false">
<button
key={i}
className={`hero-dot${i === activeIdx ? ' hero-dot-active' : ''}`}
onClick={() => goTo(i)}
aria-label={`Album ${i + 1}`}
/>
))}
</div>
type="button"
className="hero-nav-arrow hero-nav-arrow--left"
onClick={e => { e.stopPropagation(); goPrev(); }}
aria-label={t('hero.previousAlbum')}
data-tooltip={t('hero.previousAlbum')}
>
<ChevronLeft size={24} />
</button>
<button
type="button"
className="hero-nav-arrow hero-nav-arrow--right"
onClick={e => { e.stopPropagation(); goNext(); }}
aria-label={t('hero.nextAlbum')}
data-tooltip={t('hero.nextAlbum')}
>
<ChevronRight size={24} />
</button>
</div>
<div className="hero-dots" aria-hidden="true">
{albums.map((_, i) => (
<span
key={i}
className={`hero-dot${i === activeIdx ? ' hero-dot-active' : ''}`}
/>
))}
</div>
</>
)}
</div>
);